From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE8C930B50A; Sun, 1 Mar 2026 13:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772372546; cv=none; b=IxtJzkRR1xlpls7u+9cfoXUs65eo5TuCzhd8gVa69Ae4pchvCt9h/4fKcFraG4Z1POhOuvhhp8DKvWWt7NKdQ5qEmVkyI3LeYr16oc695nln574S60y9Lwh88YKs7Nx6s39PizWzWVEZh9oytua4B/UNg2mS7dFpmrQeLrh4SI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772372546; c=relaxed/simple; bh=qVD4RKahyay8TGAHGHXvQhEtbsva9khTzVeRXDCOk/U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ghjlvg9EDs+svQHIH1ldP0r7YNH2Dmc6ddZDoq/LEntLCiL1UkQ/piKKfBcPCwLZ4oiDbQLX92jKafnpB0I4ElO+SJ5HI+H210wZCRP/fFdKt5+eHrSKH6g8u4RPFvwevPZXs45qorJuS/ZjTomslRtgOKYr0KbuzkZ30rSJM8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=mSynvnue; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="mSynvnue" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WpLeXtLyKHRcvN1WgzNsqUfY7g82mlvTHaVSolT+rAw=; b=mSynvnueSrkVI69YpKkbBjRG9f aDqJMD3Z92UYypxgYcWlSpCCtaGG2y5OYeYOflT/SvZk3WJSEFJHK+L4vcEl0QEUh/m7fdWN1X8nD UjUsf4wbB5jtulQNCeRci5aBAJSaol5Z3TYzHhfJ7KrF9ikCaGhXijMFvUJ8Xu7OiZS40PeV0uWKJ 6r9q6qFwUJLNJ9ROOSBrzNHPwcUQ2O7GDrXGAjhsH4CViafGcb9wnhbllqGjyN6QWTHhN663z4boG z14caRvnp4pi0+vYszyFsw7gFgYh3yopRncaw+ZSz/0GlrMYVQJy2mfwnHUizYlAXgzrjlVOLi4Ka qv/Sd9YA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41064) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vwh3p-0000000030E-41Ie; Sun, 01 Mar 2026 13:42:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vwh3n-0000000052j-1vRB; Sun, 01 Mar 2026 13:42:15 +0000 Date: Sun, 1 Mar 2026 13:42:15 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Jakub Kicinski , Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation Message-ID: References: <20260227165556.5cf9e844@kernel.org> <20260228083111.5df8550c@kernel.org> <20260301001453.lpd2rawy7bqxyivp@skbuf> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301001453.lpd2rawy7bqxyivp@skbuf> Sender: Russell King (Oracle) On Sun, Mar 01, 2026 at 02:14:53AM +0200, Vladimir Oltean wrote: > On Sat, Feb 28, 2026 at 08:31:11AM -0800, Jakub Kicinski wrote: > > On Fri, 27 Feb 2026 16:55:56 -0800 Jakub Kicinski wrote: > > > On Sat, 28 Feb 2026 00:11:29 +0000 Russell King (Oracle) wrote: > > > > The AI review for patch 7 says: > > > > > > > > This commit fixes a bug but lacks a Fixes: tag. The commit modifies > > > > behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add > > > > .set_mode() and .validate() methods") by making phy_power_on() call > > > > qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by > > > > making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on > > > > before attempting calibration. > > > > > > > > Should this commit include: > > > > > > > > Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods") > > > > > > > > which is _wrong_, this isn't a bug fix. > > > > > > Yes, that's what I thought but then I saw the other thread.. > > > > Trying to apply this now but stmmac parts don't apply on Linus's tree, > > and Vinod wants a tag :( What do we do? > > > > Could you, perhaps, send us a PR with this on top of Linus's tree > > (a resolution of the inevitable conflict with net-next would be helpful > > too). > > > > Or do we give up on the tag? > > Actually, I think it's mainly me who wants a stable tag. I'm working on > a series for phy-next which will conflict with this hunk from Russell's > patch 1: Is this because of the issues I raised with the quality of generic PHY API implementation by drivers? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!