public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: netdev@vger.kernel.org, Sabrina Dubroca <sd@queasysnail.net>,
	Tobias Brunner <tobias@strongswan.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	devel@linux-ipsec.org
Subject: Re: [PATCH ipsec-next] esp: Consolidate esp4 and esp6.
Date: Sun, 1 Mar 2026 17:03:37 +0000	[thread overview]
Message-ID: <aaRxaVEUi-vR5EwI@horms.kernel.org> (raw)
In-Reply-To: <aZ_8Adz1m47-yzhp@secunet.com>

On Thu, Feb 26, 2026 at 08:53:37AM +0100, Steffen Klassert wrote:

...

> diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
> index e75da98f5283..b90e93fc1a70 100644
> --- a/net/ipv6/esp6.c
> +++ b/net/ipv6/esp6.c
> @@ -11,130 +11,14 @@
>   *	This file is derived from net/ipv4/esp.c
>   */
>  
> -#define pr_fmt(fmt) "IPv6: " fmt
> -
>  #include <crypto/aead.h>
>  #include <crypto/authenc.h>
> -#include <linux/err.h>
> -#include <linux/module.h>
>  #include <net/ip.h>
> -#include <net/xfrm.h>
>  #include <net/esp.h>
> -#include <linux/scatterlist.h>
> -#include <linux/kernel.h>
> -#include <linux/pfkeyv2.h>
> -#include <linux/random.h>
> -#include <linux/slab.h>
> -#include <linux/spinlock.h>
> -#include <net/ip6_checksum.h>

Hi Steffen,

I think you need to keep including ip6_checksum.h
as the code still calls csum_ipv6_magic()

...

  reply	other threads:[~2026-03-01 17:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  7:53 [PATCH ipsec-next] esp: Consolidate esp4 and esp6 Steffen Klassert
2026-03-01 17:03 ` Simon Horman [this message]
2026-03-02 11:26 ` Sabrina Dubroca
2026-03-12  9:37   ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaRxaVEUi-vR5EwI@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=devel@linux-ipsec.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    --cc=steffen.klassert@secunet.com \
    --cc=tobias@strongswan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox