From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.aperture-lab.de (mail.aperture-lab.de [116.203.183.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9F01F2B88; Mon, 2 Mar 2026 08:09:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.183.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772438946; cv=none; b=jjg/koZ+EIY6FhcxHZ6GEos6u1hSBGwaqFJEgjryP8J6ytjsWllrUMzdazcqxnjVCwrFYoggpD2rSslrVw+RaJ8RvbFtjmHdAYSN9HjeEP9wdDN0yA+bcvFJPTuRETBgxPwm6juWuUE9E7uqskir+PKk91C8Qmm7YhBIUCQngc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772438946; c=relaxed/simple; bh=D3RZLvV0PsxmO/YS0/AtGcTqc0z3e2/zT9l56j2AvQQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QQ3rwOQOjJkXl8KQsTrprfSgpANURgXTWdET4GoVTo0oyLcLPSs98UYhEfLp7mMk9SXQeTtIWAhAso91em4wErzvae4Apr1xzZkdrDIR4SO3btid0sROzkYi9p25zhhmcb7LStEjMD5xkjHdHLhmQZG7fmJ6t5ApvgDWgtU2f6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=c0d3.blue; spf=pass smtp.mailfrom=c0d3.blue; arc=none smtp.client-ip=116.203.183.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=c0d3.blue Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=c0d3.blue Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B3F1154C45D; Mon, 2 Mar 2026 09:08:59 +0100 (CET) Date: Mon, 2 Mar 2026 09:08:58 +0100 From: Linus =?utf-8?Q?L=C3=BCssing?= To: bridge@lists.linux.dev Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Nikolay Aleksandrov , Ido Schimmel , Andrew Lunn , Simon Horman , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S . Miller" , Kuniyuki Iwashima , Stanislav Fomichev , Xiao Liang , shuah@kernel.org Subject: Re: [PATCH net-next v3 02/14] net: bridge: mcast: track active state, adding tests Message-ID: References: <20260302054008.21638-1-linus.luessing@c0d3.blue> <20260302054008.21638-3-linus.luessing@c0d3.blue> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260302054008.21638-3-linus.luessing@c0d3.blue> X-Last-TLS-Session-Version: TLSv1.3 On Mon, Mar 02, 2026 at 06:39:56AM +0100, Linus Lüssing wrote: > Before making any significant changes to the internals of the Linux > bridge add some tests regarding the multicast activity. This is > also to verify that we have the semantics of the new > *_MCAST_ACTIVE_{V4,V6} netlink attributes as expected. > > Signed-off-by: Linus Lüssing > --- Sorry, I might need some guidance on what the checks patchwork lists want from me here. I'm running the tests with the following command without any issues: PATH="/mnt/net/iproute2/ip/:/mnt/net/iproute2/bridge/:$PATH" make -C tools/testing/selftests TARGETS="net/forwarding" TEST_GEN_PROGS="" TEST_PROGS="bridge_mdb_active.sh" run_tests But why does shellcheck list so many errors with "This function is never invoked." Even though they are invoked with my above command? I also don't get what netdev/check_selftest wants from me. I only see "FAILED" here? https://netdev-ctrl.bots.linux.dev/logs/build/1059784/14444497/check_selftest/summary Regards, Linus