* [PATCH net-next v1 1/1] i40e: Add missing header
@ 2026-03-02 9:03 Andy Shevchenko
2026-03-02 9:10 ` [Intel-wired-lan] " Paul Menzel
2026-03-02 9:45 ` Loktionov, Aleksandr
0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2026-03-02 9:03 UTC (permalink / raw)
To: Andy Shevchenko, intel-wired-lan, netdev, linux-kernel
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
When cleaning up another header I have met this build error:
drivers/net/ethernet/intel/i40e/i40e_hmc.h:105:22: error: implicit declaration of function 'upper_32_bits' [-Wimplicit-function-declaration]
105 | val1 = (u32)(upper_32_bits(pa)); \
This is due to missing header, add it to fix the possible issue.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.h b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
index 480e3a883cc7..967711405919 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_hmc.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
@@ -4,6 +4,8 @@
#ifndef _I40E_HMC_H_
#define _I40E_HMC_H_
+#include <linux/wordpart.h>
+
#include "i40e_alloc.h"
#include "i40e_io.h"
#include "i40e_register.h"
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next v1 1/1] i40e: Add missing header
2026-03-02 9:03 [PATCH net-next v1 1/1] i40e: Add missing header Andy Shevchenko
@ 2026-03-02 9:10 ` Paul Menzel
2026-03-02 9:19 ` Andy Shevchenko
2026-03-02 9:45 ` Loktionov, Aleksandr
1 sibling, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2026-03-02 9:10 UTC (permalink / raw)
To: Andy Shevchenko
Cc: intel-wired-lan, netdev, linux-kernel, Tony Nguyen,
Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Dear Andy,
Thank you for the patch. In the summary/title I’d add the header name.
Should you resend, maybe:
i40e: Include missing wordpart.h header
Am 02.03.26 um 10:03 schrieb Andy Shevchenko:
> When cleaning up another header I have met this build error:
>
> drivers/net/ethernet/intel/i40e/i40e_hmc.h:105:22: error: implicit declaration of function 'upper_32_bits' [-Wimplicit-function-declaration]
> 105 | val1 = (u32)(upper_32_bits(pa)); \
>
> This is due to missing header, add it to fix the possible issue.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.h b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> index 480e3a883cc7..967711405919 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> @@ -4,6 +4,8 @@
> #ifndef _I40E_HMC_H_
> #define _I40E_HMC_H_
>
> +#include <linux/wordpart.h>
> +
> #include "i40e_alloc.h"
> #include "i40e_io.h"
> #include "i40e_register.h"
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next v1 1/1] i40e: Add missing header
2026-03-02 9:10 ` [Intel-wired-lan] " Paul Menzel
@ 2026-03-02 9:19 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2026-03-02 9:19 UTC (permalink / raw)
To: Paul Menzel
Cc: intel-wired-lan, netdev, linux-kernel, Tony Nguyen,
Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
On Mon, Mar 02, 2026 at 10:10:52AM +0100, Paul Menzel wrote:
>
> Thank you for the patch. In the summary/title I’d add the header name.
> Should you resend, maybe:
>
> i40e: Include missing wordpart.h header
Done in v2!
> Am 02.03.26 um 10:03 schrieb Andy Shevchenko:
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next v1 1/1] i40e: Add missing header
2026-03-02 9:03 [PATCH net-next v1 1/1] i40e: Add missing header Andy Shevchenko
2026-03-02 9:10 ` [Intel-wired-lan] " Paul Menzel
@ 2026-03-02 9:45 ` Loktionov, Aleksandr
2026-03-02 9:51 ` Andy Shevchenko
1 sibling, 1 reply; 6+ messages in thread
From: Loktionov, Aleksandr @ 2026-03-02 9:45 UTC (permalink / raw)
To: Andy Shevchenko, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Nguyen, Anthony L, Kitszel, Przemyslaw, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Andy Shevchenko
> Sent: Monday, March 2, 2026 10:03 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; intel-wired-
> lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>
> Subject: [Intel-wired-lan] [PATCH net-next v1 1/1] i40e: Add missing
> header
>
> When cleaning up another header I have met this build error:
>
> drivers/net/ethernet/intel/i40e/i40e_hmc.h:105:22: error: implicit
> declaration of function 'upper_32_bits' [-Wimplicit-function-
> declaration]
> 105 | val1 = (u32)(upper_32_bits(pa));
> \
>
> This is due to missing header, add it to fix the possible issue.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> index 480e3a883cc7..967711405919 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> @@ -4,6 +4,8 @@
> #ifndef _I40E_HMC_H_
> #define _I40E_HMC_H_
>
> +#include <linux/wordpart.h>
> +
> #include "i40e_alloc.h"
> #include "i40e_io.h"
> #include "i40e_register.h"
> --
> 2.50.1
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next v1 1/1] i40e: Add missing header
2026-03-02 9:45 ` Loktionov, Aleksandr
@ 2026-03-02 9:51 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2026-03-02 9:51 UTC (permalink / raw)
To: Loktionov, Aleksandr
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Nguyen, Anthony L,
Kitszel, Przemyslaw, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
On Mon, Mar 02, 2026 at 09:45:46AM +0000, Loktionov, Aleksandr wrote:
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Andy Shevchenko
> > Sent: Monday, March 2, 2026 10:03 AM
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Thanks!
I sent a v2 with fixed Subject already, please review that one.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net-next v1 1/1] i40e: Add missing header
@ 2026-01-24 0:56 Andy Shevchenko
2026-01-26 7:25 ` [Intel-wired-lan] " Loktionov, Aleksandr
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2026-01-24 0:56 UTC (permalink / raw)
To: Andy Shevchenko, intel-wired-lan, netdev, linux-kernel
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
When cleaning up another header I have met this build error:
drivers/net/ethernet/intel/i40e/i40e_hmc.h:105:22: error: implicit declaration of function 'upper_32_bits' [-Wimplicit-function-declaration]
105 | val1 = (u32)(upper_32_bits(pa)); \
This is due to missing header, add it to fix the possible issue.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.h b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
index 480e3a883cc7..967711405919 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_hmc.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
@@ -4,6 +4,8 @@
#ifndef _I40E_HMC_H_
#define _I40E_HMC_H_
+#include <linux/wordpart.h>
+
#include "i40e_alloc.h"
#include "i40e_io.h"
#include "i40e_register.h"
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next v1 1/1] i40e: Add missing header
2026-01-24 0:56 Andy Shevchenko
@ 2026-01-26 7:25 ` Loktionov, Aleksandr
0 siblings, 0 replies; 6+ messages in thread
From: Loktionov, Aleksandr @ 2026-01-26 7:25 UTC (permalink / raw)
To: Andy Shevchenko, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Nguyen, Anthony L, Kitszel, Przemyslaw, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Andy Shevchenko
> Sent: Saturday, January 24, 2026 1:57 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; intel-wired-
> lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>
> Subject: [Intel-wired-lan] [PATCH net-next v1 1/1] i40e: Add missing
> header
>
> When cleaning up another header I have met this build error:
>
> drivers/net/ethernet/intel/i40e/i40e_hmc.h:105:22: error: implicit
> declaration of function 'upper_32_bits' [-Wimplicit-function-
> declaration]
> 105 | val1 = (u32)(upper_32_bits(pa));
> \
>
> This is due to missing header, add it to fix the possible issue.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> index 480e3a883cc7..967711405919 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.h
> @@ -4,6 +4,8 @@
> #ifndef _I40E_HMC_H_
> #define _I40E_HMC_H_
>
> +#include <linux/wordpart.h>
> +
> #include "i40e_alloc.h"
> #include "i40e_io.h"
> #include "i40e_register.h"
> --
> 2.50.1
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-03-02 9:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-02 9:03 [PATCH net-next v1 1/1] i40e: Add missing header Andy Shevchenko
2026-03-02 9:10 ` [Intel-wired-lan] " Paul Menzel
2026-03-02 9:19 ` Andy Shevchenko
2026-03-02 9:45 ` Loktionov, Aleksandr
2026-03-02 9:51 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2026-01-24 0:56 Andy Shevchenko
2026-01-26 7:25 ` [Intel-wired-lan] " Loktionov, Aleksandr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox