From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89B1394470 for ; Mon, 2 Mar 2026 10:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772445675; cv=none; b=MBuVgux7K+jy2RWdK3kEC/RH9ikraVNyRdtPqYa9tNlRdOPwtsW1MB5v5+/jtwi6imkKtmdrh3zrq+5ZPFn9x4qUKAOHqe9NQr9rw+zzyL7Ze88tzbCnjrKOY4nbROnJ/fjiQBOAE826bDxJIjpstehXNK14uybe5GIUKnV1fv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772445675; c=relaxed/simple; bh=XcDBiF+tm+FToq8gICWmU+m/nRh9Ny7buWewqeSSE5s=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=sUNRtkBRF7quAylRkJDJsCWMenZDNMjP3voZh/dljqtafnC7dTSbqMxexQlu6DlhMj1UAOmU3VYZjFRt1pN2DSmBP6cYSWguMuZ9mf9Yu4xlgV666Kh5Hc26moT7GpjGhN/Gwg8SCvSm+Ker/r7SkKb1lbbdHvZSbSru362p5GM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pKcMeK5z; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pKcMeK5z" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4836b7c302fso43405975e9.1 for ; Mon, 02 Mar 2026 02:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772445672; x=1773050472; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tjS8FX592qmj/rFkafjn+lojx6cnlsSGWxK3ppaLTGU=; b=pKcMeK5zFCeuyEDqN9uC2KaA70X8zgbgjnqAslsyyaFYEXtkS9V6COy+BZIyCzxSmQ pOEovWK8dwfeI8hGnwiaqcOR0b2SAyvlou6AEigYeorhF6m2bin/+hJiFLV9gNI5yJ9X 5VbDb+pbUiHmxG/B6jxauf6w66cmYQoGlfDcBBhNz9g73G6Xfxxfk2cqgDlaiRQTKaSH 2TMAEi4ATjIBTiC2y3HnwO5ZQIREWjEyEayiTutzK8+3fCDcwXrIjy29bqj+MgfJewS+ TQdyTuXurfVHvukuPqLt4qL+/V7ElyQD1yki55tyknaGoKa4sg5MjKF7WPiUKOM217sF 9gCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772445672; x=1773050472; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tjS8FX592qmj/rFkafjn+lojx6cnlsSGWxK3ppaLTGU=; b=Y4vqq8vZglaCNYOGyQPuSz6itIkMJnDviOE1EBRubrQ/RolxM5U1Jqvn2idtPO9KFv DEUJcGYPolUxKZ3XLI+Yj9i7tF4pBEWXWq0gw8QIIorT9p+JMBg8WHGCijKXB6Unh5Yg 2wCQK7m1+8dxekruKPevCNZcMcrGBqdbqZOWzJGgd2U2nS5EfTrev+NavgCRuS4X7BXl zPO/JMMK6kSePt6iWv+4yXiMpBGg7duO0uMHz/t0wukFMSZovoBvDD41rGmIVzqpKZCm ZtZeKjNskMkp9X8zlMs/46/INm9gqZqjqi6avf/xSfag4hAuM6u+V3XSlBAuaomtQr5o kcGw== X-Forwarded-Encrypted: i=1; AJvYcCX5PzUoP+wkpdSl58dNbH+tffKRjQ8o8TcwPxGUO3KFXnP9E0AE35P/RCCWo9iK/AJLCq9etQw=@vger.kernel.org X-Gm-Message-State: AOJu0YxneV9jaEccPmk4gPNPyia2muQrmOByxTwoohEiCrRAyumzRMbj LvQJ0w+xbL5G7bcx8QxEa/nafF2ELISQDiKQaRzEQLl6kkOuOIET6aPI1G+RiqX47niex0Efvbo qe4Zrd3oytd471P03Kw== X-Received: from wmbg9.prod.google.com ([2002:a05:600c:a409:b0:483:7827:ade4]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3110:b0:480:2521:4d92 with SMTP id 5b1f17b1804b1-483c9c23ffbmr196674855e9.24.1772445671732; Mon, 02 Mar 2026 02:01:11 -0800 (PST) Date: Mon, 2 Mar 2026 10:01:10 +0000 In-Reply-To: <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Mon, Mar 02, 2026 at 09:18:45AM +0100, David Hildenbrand (Arm) wrote: > On 2/28/26 13:38, Alice Ryhl wrote: > > On Fri, Feb 27, 2026 at 09:08:33PM +0100, David Hildenbrand (Arm) wrote: > >> Nobody except memory.c should really set that parameter to non-NULL. So > >> let's just drop it and make unmap_mapping_range_vma() use > >> zap_page_range_single_batched() instead. > >> > >> Signed-off-by: David Hildenbrand (Arm) > > > >> diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > >> index da21d65ccd20..b8e59e4420f3 100644 > >> --- a/rust/kernel/mm/virt.rs > >> +++ b/rust/kernel/mm/virt.rs > >> @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, size: usize) { > >> // sufficient for this method call. This method has no requirements on the vma flags. The > >> // address range is checked to be within the vma. > >> unsafe { > >> - bindings::zap_page_range_single(self.as_ptr(), address, size, core::ptr::null_mut()) > >> + bindings::zap_page_range_single(self.as_ptr(), address, size) > >> }; > > > > Please run rustfmt on Rust changes. Here, rustfmt leads to this being > > formatted on a single line: > > Having to run tooling I don't even have installed when removing a single > function parameter; did not expect that :) Well, rustfmt comes with the compiler, and it would be ideal to build test changes before sending them :) But no worries, I took care of testing it. Thanks for taking the time to update the Rust code as well. Documentation/rust/quick-start.rst has details for most distros. Alice