From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Sean Chang <seanwascoding@gmail.com>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
trond.myklebust@hammerspace.com, anna@kernel.org,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/2] Fix compiler warnings/errors in SUNRPC and MACB
Date: Mon, 2 Mar 2026 14:26:11 +0100 [thread overview]
Message-ID: <aaWP88PplFTsAPg3@black.igk.intel.com> (raw)
In-Reply-To: <0a784056-f57f-4634-aa7a-fd0b5916f40a@lunn.ch>
On Sun, Mar 01, 2026 at 06:39:44PM +0100, Andrew Lunn wrote:
> > - Verified via .lst and nm that both variables (buf) and helper functions
> > (nlmdbg_cookie2a) are fully optimized out by the compiler when
> > CONFIG_SUNRPC_DEBUG is disabled.
>
> Thanks for doing this bit. It was needed to show my guess was correct.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
It already has your tag. My Q in v5 still stands: Why is this a series and not
standalone changes?
Also I just gave a tag, please split these two and send individually.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-02 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 16:17 [PATCH v6 0/2] Fix compiler warnings/errors in SUNRPC and MACB Sean Chang
2026-03-01 16:17 ` [PATCH v6 1/2] sunrpc: simplify dprintk macros and cleanup redundant debug guards Sean Chang
2026-03-02 13:27 ` Andy Shevchenko
2026-03-01 16:17 ` [PATCH v6 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Sean Chang
2026-03-01 17:39 ` [PATCH v6 0/2] Fix compiler warnings/errors in SUNRPC and MACB Andrew Lunn
2026-03-02 13:26 ` Andy Shevchenko [this message]
2026-03-02 16:28 ` Sean Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaWP88PplFTsAPg3@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andrew@lunn.ch \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=seanwascoding@gmail.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox