From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD17840149C for ; Mon, 2 Mar 2026 15:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772466106; cv=none; b=CeGEl/PuwXYyBEuGbhCbsMER472KiaF27A1jc04Zk09sx30QVzYjI9KJN8jWB+NIy1zJHTpKk5hjF/+pcplPDOCdEHNknveoTojYa2HpTREVfWuLPMZiytNW9X8b6pBz98ywbgk92bzLdKrdxDTaHk9/tFVyg4XKFEGXBQKH12U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772466106; c=relaxed/simple; bh=V5eDYyeSzEe01Qy0X2d3YjmdmOm2DlobDKTfwH81yIk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NUsio2EFPgOjY1KiADrTXK43zEWSZELS+uhK9+s/LVdjtEw7KI9iDtap/fCjWfMmAJKQaLUQloL4uADIpejBat9EP4bZphEEnEYVjmnSmXbLVeOy1gnlRy/0/4YZAMyuuIuvvhdAXSEbSPQNmtx5YwDurOh/EE3rPAZKDmc6/ZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NpcLcN9z; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NpcLcN9z" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso58425065e9.1 for ; Mon, 02 Mar 2026 07:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772466103; x=1773070903; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fvJ4Pj0Wo9ryI9xJ6mJ9OBJG9CVcmeBhutvadxQnZZs=; b=NpcLcN9zaHs6viT1xkKDJ6JmpmAjvhKns6ydmfiwCNU5XOvLSWikyNvN/hsLBDVKJz CQQPekhDUK//hEnOaLL8NjKhpzzxiWvoWaI4iDzJQ6VvtfYDpc2SIo7ODSRQiiQb7rqY T9pBkMdn8THxrSV2LAPfXGfKwuuA6tvQsEkDmBikv2i/8u0CaDqNDDwZ4e1s1FsnJO69 W3EqubJd3HDoLvp5I9MGEIOo2Qcwmg2YaPYpkcCM/kWWdJ5gcy7yhiwmQqY4q76okx0C xa7i0vCr56hW1eHA53+8TLarCTCI/Ivx3qE0J7nXzkaUQbXbHUIOfhT7j+CJYJPjammY XWeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772466103; x=1773070903; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fvJ4Pj0Wo9ryI9xJ6mJ9OBJG9CVcmeBhutvadxQnZZs=; b=JcrxmJyNtDigTk2SVPawU0JNodJEIk671kH8WsO1B+uMSu6DuoZqRACEEfKvCNqmDp h+oo4B0wPHUhQmtl8LY+nSzTarA0T5NYYroO6fn/lrvTXQ1qliRFtjiI0jddbQCWgAqs yHS34/ABUe3fk25TGuyfcZam26F9VBKY8RdAwmxxw5TguNjDPDhgayAmrE0zN7omuQsH e9qCgTVvxq8r/h40G8N2cWL1CSr/Y6rqnmfJBdbumRHMsCN3RUaO+dnhWUvsv9zMViAk uUYV/E3NeJrQqVaOCIU630aDuCxTZ3grcE3KzkIsqgitcNZ5Zky7DAeQrefbYO9c84CG YyeQ== X-Forwarded-Encrypted: i=1; AJvYcCW0oE7Q9AlNNSzpN5ZA6B9gyYsoMWVdTMHAzO4GWIIH/o3vQJNJUT1eoRnJra/nKSW7RBx7E2E=@vger.kernel.org X-Gm-Message-State: AOJu0YyTxEiQXTL4VIoszR/4GY0gCyW/iPyXakhHYlUIo0OpBNlhAP1u k31h98z0HZA2gMDkQo58dyeOCUS8QDqTGQLm5mdhT1GWWWkLx28qJcC9iF6XZNJTtaVSllGok6g 55kQkSHoYpN71PH35eg== X-Received: from wmby19.prod.google.com ([2002:a05:600c:c053:b0:480:690c:88de]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b18:b0:483:7432:a761 with SMTP id 5b1f17b1804b1-483c9bc558bmr213622465e9.24.1772466102970; Mon, 02 Mar 2026 07:41:42 -0800 (PST) Date: Mon, 2 Mar 2026 15:41:42 +0000 In-Reply-To: <5f8dcb7f-9e4f-4484-b160-3a9ce541d63c@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> <5f8dcb7f-9e4f-4484-b160-3a9ce541d63c@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Mon, Mar 02, 2026 at 04:01:44PM +0100, David Hildenbrand (Arm) wrote: > On 3/2/26 11:33, Alice Ryhl wrote: > > On Mon, Mar 02, 2026 at 11:27:40AM +0100, David Hildenbrand (Arm) wrote: > >> On 3/2/26 11:01, Alice Ryhl wrote: > >>> > >>> Well, rustfmt comes with the compiler, and it would be ideal to build > >>> test changes before sending them :) > >> > >> At least on Ubuntu on my notebook where I do most of the coding+patch > >> submissions it's a separate package? > >> > >> I do all my builds on a different (more powerful) machine where the > >> whole rust machinery's in place. Further, build bots that run on my > >> private branches did not report any issues. > > > > There are some build bots that check for rustfmt, though not all of > > them. > > > >>> But no worries, I took care of testing it. Thanks for taking the time to > >>> update the Rust code as well. > >> > >> I just did an allyesconfig and it does not report any warnings. > >> > >> So apparently, rustfmt problems not result in the compiler complaining? > >> > >> Or something else is off here that rust/kernel/mm/virt.rs won't get > >> compiled on my machine, even with allyesconfig. I can definitely see > >> some RUSTC stuff happening in the logs, like > >> > >> RUSTC L rust/kernel.o > >> > >> Thanks for the review and for pointing out rustfmt! > > > > Similar to kerneldoc and other similar targets, formatting isn't checked > > in the normal build, but make can be invoked on the rustfmtcheck target > > to check it. > > Thanks adding that to my cross-compile chain. Awesome, thanks! It's not relevant in this patch, but another thing that may be useful is to add CLIPPY=1 to the make invocation when building normally. This causes additional warnings to be checked using a tool called clippy. Alice