From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0123121FF4C for ; Tue, 3 Mar 2026 21:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772571847; cv=none; b=gLg8BKuZ3lxaRGJPnRZQ2k5AKzJS/nZ6Yhgqzg2y50psP+p4om8+1xfegQDokuDZW87QlMfsPBEn0hHhQKnF5BFhQpsbZUWvBM2BiQ1sMStHAJe+WQ78EJnV0f4jhS1OLNSacN9NezbYswOk3OaO2UBEAYV/08TAYrcR7u+MxHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772571847; c=relaxed/simple; bh=J6nDxFAmQuO1PEmxWaxGzQ5kcCpDKZy+Jnp91XAOmyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n7Sbp/eLsMSjvbWs4/Id4DtXt2Jf3tsT0neEArAjB5W9g4eHyzZ0Z82PhNg4uq8sf/EC4nSrwnesdLaNqOBB/w+ejxhy60PiS5HY681IyELrC9yaY7n4Efadaj3aT/1q5uNyj83ASpyuHKPNg3j5YEvK7Wl8Iz1Tr2ayOujc5x0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=Vntv1qKb; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="Vntv1qKb" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c6e1f417918so1832937a12.3 for ; Tue, 03 Mar 2026 13:04:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1772571845; x=1773176645; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=X0z9fzge2OCGffz7dX5wu5y2qLO9lb4LYFW2zmtJVxI=; b=Vntv1qKb1bp8CmvaXVtEBUatxXODyBYSl/+F/wrf9nSnao7+e7zvNMCNMZPN4vpInp Yj/XxeD5VMZ8vRdDMbSk2/YZqMPRcFJ9VcKsG7U0t/Fq/3c4L2fXjnWiwJNUFOz3AhRd zY89xZRe2I0uG9Ccgf2Ywhr9801jm9w4hk2cq04adRYPdoVb+IOsObfc9PNLfEFL3oSg lYoJBl0kjoZXHlWw/nM7kn5vWoR3xNx5H3SgmOGCNy/dk5aWrfQeS6Dwe9dDMNHE9pKc u/HmQoLgCrWqr3IDiokJEzEoPHgVUzNSSX2T9G4a+DNfX5kP9P6rCyWfE23UXgCpJXsH GKaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772571845; x=1773176645; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X0z9fzge2OCGffz7dX5wu5y2qLO9lb4LYFW2zmtJVxI=; b=kUYn/RBKZUeVitRePWzARj/EkFMdUXv5xv/fcIwu31joRRY/J20EbRDg5yi3KxdiAd EGwHv5w8iy693t8OtGELzMwm8xrZnXJt8bml24WIzdGQwgN+nbX1Dcs8K6HBzEsQ5N3k hWznVfv+yunx8c+Xe09jisX7aojBoNKmx2ANgOX+rtaEfPw+0emf94l/YMpdHnt0AAtA uUYT5MtaRJs7CH3VIV8Qkf6wQrwdZSFNG6fn2FU74kxRrm49CknEN0r0GYFeYIFt5+Qs TB1/XoQFqMjt1FHsf36OobWYJDpVvXXeTeldVFa9JJ4SbszoSqSUKqt56TQZCYSj168i UESQ== X-Forwarded-Encrypted: i=1; AJvYcCWT4Ph65WOKNJUO3kwc93zG/6JDRoHI31r9e9b3yVGBv5PGuSTZXJoiFBZQ+SpPl1w65Whp/9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxzUnt12Pa8GdrgaNccCAaUrqQCJlstVmsgMwYAPXjXZpLSf17w +/yj+0QTboDAIXRtZ16VVbseM82Gwi+O7EWCLeaayuWzwrpDAIR28khiI+HXwE/G4ABXOB0V6vU oc/PCot0= X-Gm-Gg: ATEYQzyqC5EtIhMjPYa6HxApJXbXYxTD4ooNHQ0rwjnyKfMmRgLmbR6fTSsA6+wNZC5 VeCn1rcKgFEDZuX9IyrvVO+nXlQHB5MEPy3n4U8aPH+AhG1I/RHbgraAl9yykSlSwqJf75TXMYs nc4390m7r/dzCQUQcNpaPAIm0jJ6Kb8+lBgrEHtNStVH+7eiAH0Y77DHXzoK0Jn2ZKIfnorYjbs Yo7sh4B4MsfqsUN5nADCznM5veeYj2HqSzJVbTRiRzlY7bvn8/VrRJ391I20wo/4Ok1brU3Npcv pxO7BECKop5CV/hpx+7zsIeFhvDqgO8eRNXO3V/sYQAnc804VV0tSZzjfvO9voJpWme5QYcTH+j frwB8757mLsH7j2+3NUVEaV34VRnAQV8fi/BfOLeKiFhV0kUK6yfJR4j69pbIWWIt/TQYjByTKE ukNHbc X-Received: by 2002:a17:903:2303:b0:2ae:6887:5c26 with SMTP id d9443c01a7336-2ae688763fbmr5513245ad.48.1772571845308; Tue, 03 Mar 2026 13:04:05 -0800 (PST) Received: from localhost ([2a03:2880:2ff:73::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3e4e34fesm108107565ad.28.2026.03.03.13.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 13:04:04 -0800 (PST) Date: Tue, 3 Mar 2026 13:04:04 -0800 From: Joe Damato To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Subject: Re: [PATCH net 2/5] nfc: digital: free skb on digital_in_send error paths Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org References: <20260303162346.2071888-1-kuba@kernel.org> <20260303162346.2071888-3-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303162346.2071888-3-kuba@kernel.org> On Tue, Mar 03, 2026 at 08:23:42AM -0800, Jakub Kicinski wrote: > digital_in_send() takes ownership of the skb passed by the caller > (nfc_data_exchange), make sure it's freed on all error paths. > > Found looking around the real driver for similar bugs to the one > just fixed in nci. > > Fixes: 7d0911c02fa2 ("NFC: digital: Add NFC-DEP Initiator-side send/receive support") > Signed-off-by: Jakub Kicinski > --- > net/nfc/digital_core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Joe Damato