From: Andrew Lunn <andrew@lunn.ch>
To: Mike Marciniszyn <mike.marciniszyn@gmail.com>
Cc: Alexander Duyck <alexanderduyck@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
kernel-team@meta.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jacob Keller <jacob.e.keller@intel.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] net: eth: fbnic: Fix addr validation in pcs write
Date: Wed, 29 Apr 2026 15:54:26 +0200 [thread overview]
Message-ID: <aadaf747-12fe-40dd-90f4-7f170b68c8f2@lunn.ch> (raw)
In-Reply-To: <afHfFj0CkBUIQxRT@PF5YBGDS.localdomain>
On Wed, Apr 29, 2026 at 06:36:06AM -0400, Mike Marciniszyn wrote:
> On Tue, Apr 28, 2026 at 08:11:30PM +0200, Andrew Lunn wrote:
> > On Tue, Apr 28, 2026 at 01:28:07PM -0400, mike.marciniszyn@gmail.com wrote:
> > > From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>
> > >
> > > This patch contains a fix for addr validation in fbnic_mdio_write_pcs().
> > >
> > > Cc: stable@vger.kernel.org
> > > Fixes: d0ce9fd7eae0 ("fbnic: Add SW shim for MDIO interface to PMD and PCS")
> > > Signed-off-by: Mike Marciniszyn (Meta) <mike.marciniszyn@gmail.com>
> >
> > Please don't mix fixed and going development work in one
> > patchset. They should be applied to different trees, etc.
> >
> > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> >
> > Andrew
> >
>
> So I'm guessing I need to send the bug fix to net instead of net-next
> and reissue the patch series?
Correct.
You also have access to some good mentors within Meta, maybe reach out
to them and do internal reviews before posting to netdev?
> BTW, the review notes that the patch wasn't sent to you
> (https://netdev-ctrl.bots.linux.dev/logs/build/1087030/14544928/cc_maintainers/)
> but that is because there are two addresses for you:
>
> grep Lunn MAINTAINERS
> M: Andrew Lunn <andrew@lunn.ch>
> M: Andrew Lunn <andrew@lunn.ch>
> M: Andrew Lunn <andrew@lunn.ch>
> M: Andrew Lunn <andrew@lunn.ch>
> M: Andrew Lunn <andrew+netdev@lunn.ch> <----
> M: Andrew Lunn <andrew@lunn.ch>
> M: Andrew Lunn <andrew@lunn.ch>
> M: Andrew Lunn <andrew@lunn.ch>
> M: Andrew Lunn <andrew@lunn.ch>
>
> That seems to foil my scripting. Is MAINTAINERS wrong?
No. The +netdev helps procmail separate traffic between run of the
mill netdev deluge, and email specifically for me, so they go into
different mailboxes.
Andrew
next prev parent reply other threads:[~2026-04-29 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 17:28 [PATCH net-next 0/4] first series for xpcs based rsfec configuration mike.marciniszyn
2026-04-28 17:28 ` [PATCH net-next 1/4] net: eth: fbnic: Fix addr validation in pcs write mike.marciniszyn
2026-04-28 18:11 ` Andrew Lunn
2026-04-29 10:36 ` Mike Marciniszyn
2026-04-29 13:54 ` Andrew Lunn [this message]
2026-04-28 17:28 ` [PATCH net-next 2/4] net: mdio: Add support for RSFEC Control register for PMA mike.marciniszyn
2026-04-28 18:15 ` Andrew Lunn
2026-04-28 17:28 ` [PATCH net-next 3/4] net: eth: fbnic: Consolidate register reads for ids and devs mike.marciniszyn
2026-04-28 17:28 ` [PATCH net-next 4/4] net: eth: fbnic: Add pma read and write access mike.marciniszyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aadaf747-12fe-40dd-90f4-7f170b68c8f2@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mike.marciniszyn@gmail.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox