From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, andrew+netdev@lunn.ch,
netdev@vger.kernel.org,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH net-next 3/4] i40e: Add missing header
Date: Wed, 4 Mar 2026 00:55:14 +0200 [thread overview]
Message-ID: <aadm0q5QuWM3hGNx@ashevche-desk.local> (raw)
In-Reply-To: <39f4c46c-4db9-4178-99e0-8e3f3a452ab4@intel.com>
On Tue, Mar 03, 2026 at 08:37:40AM -0800, Tony Nguyen wrote:
> On 3/3/2026 12:02 AM, Andy Shevchenko wrote:
> > On Mon, Mar 02, 2026 at 03:41:01PM -0800, Tony Nguyen wrote:
> >
> > > When cleaning up another header I have met this build error:
> > >
> > > drivers/net/ethernet/intel/i40e/i40e_hmc.h:105:22: error: implicit declaration of function 'upper_32_bits' [-Wimplicit-function-declaration]
> > > 105 | val1 = (u32)(upper_32_bits(pa)); \
> > >
> > > This is due to missing header, add it to fix the possible issue.
> >
> > There was a v2 with the other (missing here) tag is added (it was given against
> > v1 conditionally) and Subject amendeded.
>
> I assumed you had found another missing header with that other patch; guess
> I should've looked closer :(
I was talking about commit message tag and an updated Subject. The code is
the same.
> I'll update the PR with the new one.
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-03 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 23:40 [PATCH net-next 0/4][pull request] Intel Wired LAN Driver Updates 2026-03-02 (ice, i40e, ixgbe) Tony Nguyen
2026-03-02 23:40 ` [PATCH net-next 1/4] ice: Make name member of struct ice_cgu_pin_desc const Tony Nguyen
2026-03-02 23:41 ` [PATCH net-next 2/4] i40e: drop useless bitmap_weight() call in i40e_set_rxfh_fields() Tony Nguyen
2026-03-02 23:41 ` [PATCH net-next 3/4] i40e: Add missing header Tony Nguyen
2026-03-03 8:02 ` Andy Shevchenko
2026-03-03 16:37 ` Tony Nguyen
2026-03-03 22:55 ` Andy Shevchenko [this message]
2026-03-02 23:41 ` [PATCH net-next 4/4] ixgbe: refactor: use DECLARE_BITMAP for ring state field Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aadm0q5QuWM3hGNx@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox