From: Kory Maincent <kory.maincent@bootlin.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>, netdev@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Danielle Ratson <danieller@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next 06/10] netlink: specs: ethtool: re-align c33-pse-ext-state
Date: Mon, 14 Sep 2026 14:17:06 +0200 [thread overview]
Message-ID: <aaeb3d28-facd-4980-a102-f18f52975095@bootlin.com> (raw)
In-Reply-To: <20260911214148.1184806-7-ast@fiberby.net>
On 9/11/26 23:41, Asbjørn Sloth Tønnesen wrote:
> enum ethtool_c33_pse_ext_state is mis-aligned with YNL:
>
> - ETHTOOL_C33_PSE_EXT_STATE_OVLD_DETECTED is 6.
> - ETHTOOL_C33_PSE_EXT_STATE_PD_DLL_POWER_TYPE is 7 (not in YNL).
> - ETHTOOL_C33_PSE_EXT_STATE_POWER_NOT_AVAILABLE is 8, not 7.
> - ETHTOOL_C33_PSE_EXT_STATE_SHORT_DETECTED is 9, not 8.
>
> In commit c8149739af86 ("netlink: specs: Expand the PSE netlink command
> with C33 new features") the PD_DLL_POWER_TYPE enum member was skipped,
> leading incorrect values for power-not-available and short-detected.
>
> As PD_DLL_POWER_TYPE is not used, then skip it, but set the value for
> power-not-available to 8.
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-09-14 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 21:41 [PATCH net-next 00/10] netlink: specs: enum alignment fixes Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 01/10] netlink: specs: rt-link: re-align IPv4 devconf Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 02/10] netlink: specs: rt-link: re-align ifla-inet6-stats Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 03/10] netlink: specs: rt-link: fix ifinfo-flags names Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 04/10] netlink: specs: rt-link: fix netkit-policy names Asbjørn Sloth Tønnesen
2026-09-11 22:26 ` Jakub Kicinski
2026-09-12 0:36 ` Jakub Kicinski
2026-09-14 7:53 ` Daniel Borkmann
2026-09-11 21:41 ` [PATCH net-next 05/10] netlink: specs: devlink: fix resource-scope type Asbjørn Sloth Tønnesen
2026-09-17 14:35 ` Moshe Shemesh
2026-09-11 21:41 ` [PATCH net-next 06/10] netlink: specs: ethtool: re-align c33-pse-ext-state Asbjørn Sloth Tønnesen
2026-09-14 12:17 ` Kory Maincent [this message]
2026-09-11 21:41 ` [PATCH net-next 07/10] netlink: specs: ethtool: re-align module-fw-flash-status Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 08/10] netlink: specs: nl80211: fix naming of enum members Asbjørn Sloth Tønnesen
2026-09-11 21:41 ` [PATCH net-next 09/10] netlink: specs: tc: fix typo in cls-flags Asbjørn Sloth Tønnesen
2026-09-12 8:25 ` Toke Høiland-Jørgensen
2026-09-11 21:41 ` [PATCH net-next 10/10] netlink: specs: fix incorrect name-prefixes Asbjørn Sloth Tønnesen
2026-09-11 22:29 ` [PATCH net-next 00/10] netlink: specs: enum alignment fixes Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaeb3d28-facd-4980-a102-f18f52975095@bootlin.com \
--to=kory.maincent@bootlin.com \
--cc=andrew@lunn.ch \
--cc=ast@fiberby.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox