From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7597E839F4 for ; Sun, 12 Jan 2025 22:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736719381; cv=none; b=TS0Ur4E79hJDbkNgmRClT1WIJcomEhOCi+rI5VtZCkf+guY5SVr9vORSbC7AuzZ36qbPd8CFPuAd9vOQ2/fGS7/N3Kmm+DS9QO1Zd85QrsLRRCIMCz84phZz0plLAevgXvSfpNZJeD/47ZpCWAEn/H+9olGO14pSFj+bmSrfCQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736719381; c=relaxed/simple; bh=4JhZr4ryUubF7Lq6yJs+tz212gQdOJGn9KYFuCJbp+4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=WK1nPpTlCosjQ4MxNbHwULLwI6UqUZIv0t5COQtgi5NlUbDlcVxgwBnxbcN6jDeWdy25ZjGPwv/NjJ8A26WJOwHXpG7VCvql1bZo91ERGeudDSckf8Xk3xJiVLUDQtarAh8qOtFEEj+K33a7495wXXJBLEzOgyvz+bIaZr3UCy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KYOX/Xdb; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KYOX/Xdb" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4364a37a1d7so39221085e9.3 for ; Sun, 12 Jan 2025 14:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736719378; x=1737324178; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=M9wtmnOh+l+tL+4OG8X7I9GpBH22dRW87P+JGsleYy4=; b=KYOX/XdbpyJmR/OKXJv1jj0TGNCHpukNfX2eWJJ/ZjTWXXzbZwwmgnv0+SRfMjgtrs IzglF0W+VQTVxOqQRT3ez0q1E6scX68Z7tKBvXpOtfutn9Zi3vs2kG5b2ilLt2Q/KVmj SwCednA+m27GxMP3BJ0/c8f59Zd8Yj8iCTGxQ/OJLjS65644YhtDoQa8Sqc0ys3i4LK8 xnHlba2TXF6xka+ZtiD1Br3TzGaED07Rsj5aGhdjqrF7eIfserk15NxK/CWsXokD28NB YQ08w4KFTjCgEo59LhEjw33uzzMG4mSMpj4cg8cLDfkgLdjf1R4W6qp9B0bowTtBL2AS v1Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736719378; x=1737324178; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M9wtmnOh+l+tL+4OG8X7I9GpBH22dRW87P+JGsleYy4=; b=orOB9f14mgpQW18jCUKEHeb+pZNNUXJKrTzgfkdiTupTuZETjEQdisPheJ7PNrWL3K 7DE87tK8tQUwx8hUscPotdKOUDAhpdYn6Y6DH3Yd4yq7i1FhPAIoaqYrqxswh2v8+u9i 2A8HxnX97yP5gyCF1+JS3t3GopC/qZYWFeXrTOJnruYXgrZuRJ9NapY9DPBAxVDVL4Wm NV16+gwcz64frt5SrqTHHrvzQRalacoWapih6PKooHaMru/ckL39bEhhdM6Mk6T4OYuF 4TFxGig7iObS2hVmIBg2aQjo75avu52tIfyRG9etm+UJqH0NYyqBVC/27qvw98C3n+fj hkVA== X-Forwarded-Encrypted: i=1; AJvYcCUBUugsTbIiMEH0QBweLKwsWCoYR+d0/TvDHqZcXNupUQmo2O3HUOD0i757jLozuhwpw1zQHIM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy30XBHhhORAppGzmqqgf8dd+nyDVCClaWHWWRGX23q+VDjvbn/ TwLL3TtxsisUI0YzF50fQdJtJ18g6NP46AWbzyCtorFm16185rpL X-Gm-Gg: ASbGnctXpyNvvx6ZKLEN5uWZqMiSvqxSor0NnQdcDGJ2xp0Ww11jjYBsV+cfV0MwzFl jXTw8YA8ZT+TSTU1SWsQWyMiFOL76CxANimFeUyFL/YfzR9JkxQqLLmu+dlu3k+dGk+HFAAN7UQ Fvch+5SHf+auGpyWPUMeMbjPm9ebxmCtUlNQ/ZTF0vD/24kRTbzzFdF2qcehsiAaVlKSQXrq1qp qLiw435mpjxpcodziroKsSwnEF5ZlF4qc0h/cjx1/6bkAra/QJ1yoasbjQgA2wuFzL8VevVG/T5 EKFVqHIDVRjxYAbGE/EUbHGgYYc3PMrkDVKUEUI0whuV3vbKZNZKqi8xnRe6uoQ0i5aUBjQXpRR M8qDwoCEsqLwadAD4AwA+EO7561BH3HJT2xprwSa+uo6Vf9uK X-Google-Smtp-Source: AGHT+IF2ZFHKe+vDdO7ickY1WwnU9JQTqwx6MGUrLGYHX4GwDz3r5ge4Alhbv7yNtiGkZ+lQTvWnkg== X-Received: by 2002:a05:600c:1c1a:b0:434:f753:600f with SMTP id 5b1f17b1804b1-436e26ba95dmr151262265e9.19.1736719377611; Sun, 12 Jan 2025 14:02:57 -0800 (PST) Received: from ?IPV6:2a02:3100:b0d5:ab00:44ab:526d:76d3:604a? (dynamic-2a02-3100-b0d5-ab00-44ab-526d-76d3-604a.310.pool.telefonica.de. [2a02:3100:b0d5:ab00:44ab:526d:76d3:604a]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-436e9e37d7fsm122170155e9.32.2025.01.12.14.02.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jan 2025 14:02:56 -0800 (PST) Message-ID: Date: Sun, 12 Jan 2025 23:02:56 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: ethernet: xgbe: re-add aneg to supported features in PHY quirks From: Heiner Kallweit To: Paolo Abeni , Jakub Kicinski , David Miller , Eric Dumazet , Simon Horman , Andrew Lunn , Shyam Sundar S K Cc: Andrew Lunn , Russell King - ARM Linux , "netdev@vger.kernel.org" References: <46521973-7738-4157-9f5e-0bb6f694acba@gmail.com> Content-Language: en-US Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <46521973-7738-4157-9f5e-0bb6f694acba@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12.01.2025 22:59, Heiner Kallweit wrote: > In 4.19, before the switch to linkmode bitmaps, PHY_GBIT_FEATURES > included feature bits for aneg and TP/MII ports. > > SUPPORTED_TP | \ > SUPPORTED_MII) > > SUPPORTED_10baseT_Full) > > SUPPORTED_100baseT_Full) > > SUPPORTED_1000baseT_Full) > > PHY_100BT_FEATURES | \ > PHY_DEFAULT_FEATURES) > > PHY_1000BT_FEATURES) > > Referenced commit expanded PHY_GBIT_FEATURES, silently removing > PHY_DEFAULT_FEATURES. The removed part can be re-added by using > the new PHY_GBIT_FEATURES definition. > Not clear to me is why nobody seems to have noticed this issue. > > I stumbled across this when checking what it takes to make > phy_10_100_features_array et al private to phylib. > > Fixes: d0939c26c53a ("net: ethernet: xgbe: expand PHY_GBIT_FEAUTRES") > Cc: stable@vger.kernel.org > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 19 ++----------------- > 1 file changed, 2 insertions(+), 17 deletions(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > index 6a716337f..268399dfc 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > @@ -923,7 +923,6 @@ static void xgbe_phy_free_phy_device(struct xgbe_prv_data *pdata) > > static bool xgbe_phy_finisar_phy_quirks(struct xgbe_prv_data *pdata) > { > - __ETHTOOL_DECLARE_LINK_MODE_MASK(supported) = { 0, }; > struct xgbe_phy_data *phy_data = pdata->phy_data; > unsigned int phy_id = phy_data->phydev->phy_id; > > @@ -945,14 +944,7 @@ static bool xgbe_phy_finisar_phy_quirks(struct xgbe_prv_data *pdata) > phy_write(phy_data->phydev, 0x04, 0x0d01); > phy_write(phy_data->phydev, 0x00, 0x9140); > > - linkmode_set_bit_array(phy_10_100_features_array, > - ARRAY_SIZE(phy_10_100_features_array), > - supported); > - linkmode_set_bit_array(phy_gbit_features_array, > - ARRAY_SIZE(phy_gbit_features_array), > - supported); > - > - linkmode_copy(phy_data->phydev->supported, supported); > + linkmode_copy(phy_data->phydev->supported, PHY_GBIT_FEATURES); > > phy_support_asym_pause(phy_data->phydev); > > @@ -964,7 +956,6 @@ static bool xgbe_phy_finisar_phy_quirks(struct xgbe_prv_data *pdata) > > static bool xgbe_phy_belfuse_phy_quirks(struct xgbe_prv_data *pdata) > { > - __ETHTOOL_DECLARE_LINK_MODE_MASK(supported) = { 0, }; > struct xgbe_phy_data *phy_data = pdata->phy_data; > struct xgbe_sfp_eeprom *sfp_eeprom = &phy_data->sfp_eeprom; > unsigned int phy_id = phy_data->phydev->phy_id; > @@ -1028,13 +1019,7 @@ static bool xgbe_phy_belfuse_phy_quirks(struct xgbe_prv_data *pdata) > reg = phy_read(phy_data->phydev, 0x00); > phy_write(phy_data->phydev, 0x00, reg & ~0x00800); > > - linkmode_set_bit_array(phy_10_100_features_array, > - ARRAY_SIZE(phy_10_100_features_array), > - supported); > - linkmode_set_bit_array(phy_gbit_features_array, > - ARRAY_SIZE(phy_gbit_features_array), > - supported); > - linkmode_copy(phy_data->phydev->supported, supported); > + linkmode_copy(phy_data->phydev->supported, PHY_GBIT_FEATURES); > phy_support_asym_pause(phy_data->phydev); > > netif_dbg(pdata, drv, pdata->netdev, + Shyam Sundar S K