From: wenxu <wenxu@ucloud.cn>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Paul Blakey <paulb@mellanox.com>, Oz Shlomo <ozsh@mellanox.com>,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [resend] Solution for the problem conntrack in tc subsystem
Date: Mon, 2 Nov 2020 14:08:03 +0800 [thread overview]
Message-ID: <aafb3b96-dc50-8e9d-fdfe-4abb0e5a27f6@ucloud.cn> (raw)
In-Reply-To: <20201029225936.GM3837@localhost.localdomain>
On 10/30/2020 6:59 AM, Marcelo Ricardo Leitner wrote:
> Cc'ing Cong, Paul, Oz and Davide.
>
> On Thu, Oct 29, 2020 at 10:22:04AM +0800, wenxu wrote:
>> Only do gso for the reassembly big packet is also can't fix all the
>> case such for icmp packet.
> Good point. And as we can't know that a fragment was for an icmp
> packet before defraging it, this is quite impactful.
>
>> So there are some proper solution for this problem. In the Internet
>> we can't avoid the fragment packets.
> I agree. One other idea is to add support for some hook to mirred,
> that gets executed before xmiting the packet. Then, when act_ct (or
> another specific act module, say act_frag, as act_ct might not be the
> only one interested in defragging in the future) gets loaded, it
> configs that hook.
>
> So that mirred would something like:
> if (xmit_hook)
> xmit_hook(skb, dev_queue_xmit);
> else
> dev_queue_xmit(skb);
> Even protect it with a static branch key.
>
Good idea, The act _mirror almost untouched.
The fragment function can be put in a common place for shared
by other modules.
>
> Marcelo
>
prev parent reply other threads:[~2020-11-02 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7821f3ae-0e71-0d8b-5ef9-81da69ac29dc@ucloud.cn>
2020-10-29 2:22 ` [resend] Solution for the problem conntrack in tc subsystem wenxu
2020-10-29 22:59 ` Marcelo Ricardo Leitner
2020-10-30 12:19 ` Marcelo Ricardo Leitner
2020-11-02 6:08 ` wenxu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aafb3b96-dc50-8e9d-fdfe-4abb0e5a27f6@ucloud.cn \
--to=wenxu@ucloud.cn \
--cc=dcaratti@redhat.com \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).