* [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read
@ 2026-03-04 19:57 Alok Tiwari
2026-03-04 20:13 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alok Tiwari @ 2026-03-04 19:57 UTC (permalink / raw)
To: hkallweit1, linux, quan, keyur, iyappan, andrew, kuba, davem,
edumazet, pabeni, netdev
Cc: alok.a.tiwarilinux, alok.a.tiwari
xgene_xfi_mdio_read() prints "write failed" when the MDIO management
interface remains busy and the read times out. Update the message to
"read failed" to match the operation.
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/net/mdio/mdio-xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mdio/mdio-xgene.c b/drivers/net/mdio/mdio-xgene.c
index a8f91a4b7fed..ede6b9ddc426 100644
--- a/drivers/net/mdio/mdio-xgene.c
+++ b/drivers/net/mdio/mdio-xgene.c
@@ -250,7 +250,7 @@ static int xgene_xfi_mdio_read(struct mii_bus *bus, int phy_id, int reg)
} while ((status & BUSY_MASK) && timeout--);
if (status & BUSY_MASK) {
- pr_err("XGENET_MII_MGMT write failed\n");
+ pr_err("XGENET_MII_MGMT read failed\n");
return -EBUSY;
}
--
2.50.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read
2026-03-04 19:57 [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read Alok Tiwari
@ 2026-03-04 20:13 ` Andrew Lunn
2026-03-04 21:14 ` Russell King (Oracle)
2026-03-06 3:32 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2026-03-04 20:13 UTC (permalink / raw)
To: Alok Tiwari
Cc: hkallweit1, linux, quan, keyur, iyappan, kuba, davem, edumazet,
pabeni, netdev, alok.a.tiwarilinux
On Wed, Mar 04, 2026 at 11:57:36AM -0800, Alok Tiwari wrote:
> xgene_xfi_mdio_read() prints "write failed" when the MDIO management
> interface remains busy and the read times out. Update the message to
> "read failed" to match the operation.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/net/mdio/mdio-xgene.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mdio/mdio-xgene.c b/drivers/net/mdio/mdio-xgene.c
> index a8f91a4b7fed..ede6b9ddc426 100644
> --- a/drivers/net/mdio/mdio-xgene.c
> +++ b/drivers/net/mdio/mdio-xgene.c
> @@ -250,7 +250,7 @@ static int xgene_xfi_mdio_read(struct mii_bus *bus, int phy_id, int reg)
> } while ((status & BUSY_MASK) && timeout--);
>
> if (status & BUSY_MASK) {
> - pr_err("XGENET_MII_MGMT write failed\n");
> + pr_err("XGENET_MII_MGMT read failed\n");
It is not even a plain cut/paste error. xgene_xfi_mdio_write() does
not print an error message!
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read
2026-03-04 19:57 [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read Alok Tiwari
2026-03-04 20:13 ` Andrew Lunn
@ 2026-03-04 21:14 ` Russell King (Oracle)
2026-03-06 3:32 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2026-03-04 21:14 UTC (permalink / raw)
To: Alok Tiwari
Cc: hkallweit1, quan, keyur, iyappan, andrew, kuba, davem, edumazet,
pabeni, netdev, alok.a.tiwarilinux
On Wed, Mar 04, 2026 at 11:57:36AM -0800, Alok Tiwari wrote:
> xgene_xfi_mdio_read() prints "write failed" when the MDIO management
> interface remains busy and the read times out. Update the message to
> "read failed" to match the operation.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read
2026-03-04 19:57 [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read Alok Tiwari
2026-03-04 20:13 ` Andrew Lunn
2026-03-04 21:14 ` Russell King (Oracle)
@ 2026-03-06 3:32 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-06 3:32 UTC (permalink / raw)
To: Alok Tiwari
Cc: hkallweit1, linux, quan, keyur, iyappan, andrew, kuba, davem,
edumazet, pabeni, netdev, alok.a.tiwarilinux
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 4 Mar 2026 11:57:36 -0800 you wrote:
> xgene_xfi_mdio_read() prints "write failed" when the MDIO management
> interface remains busy and the read times out. Update the message to
> "read failed" to match the operation.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/net/mdio/mdio-xgene.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read
https://git.kernel.org/netdev/net-next/c/54f5a89da9e0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-06 3:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04 19:57 [PATCH net-next] net: mdio: xgene: Fix misleading err message in xgene mdio read Alok Tiwari
2026-03-04 20:13 ` Andrew Lunn
2026-03-04 21:14 ` Russell King (Oracle)
2026-03-06 3:32 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox