public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Frank Wunderlich <frankwu@gmx.de>, Chad Monroe <chad@monroe.io>,
	Cezary Wilmanski <cezary.wilmanski@adtran.com>,
	Liang Xu <lxu@maxlinear.com>,
	"Benny (Ying-Tsan) Weng" <yweng@maxlinear.com>,
	Jose Maria Verdu Munoz <jverdu@maxlinear.com>,
	Avinash Jayaraman <ajayaraman@maxlinear.com>,
	John Crispin <john@phrozen.org>
Subject: Re: [PATCH net-next 0/2] net: dsa: mxl862xx: add support for bridge offloading
Date: Sat, 7 Mar 2026 03:39:20 +0000	[thread overview]
Message-ID: <aaud6NQWZB5eol-8@makrotopia.org> (raw)
In-Reply-To: <cover.1772853341.git.daniel@makrotopia.org>

On Sat, Mar 07, 2026 at 03:29:15AM +0000, Daniel Golle wrote:
> As a next step to complete the mxl862xx DSA driver, add support for
> offloading forwarding between bridged ports to the switch hardware.
> 
> This works pretty much without any big surprises, apart from two
> subtleties:
>  * per-port control over flooding behavior has to be implemented by
>    (ab)using a 0-rate QoS meters as stopper in lack of any better
>    option.
>  * STP state transition unconditionally enables learning on a port
>    even if it was previously explicitely disabled (a firmware bug)
> 
> Note that as the driver is still lacking all VLAN features (which
> are going to be added next), at this point some of the
> bridge_vlan_aware.sh tests are failing after applying this series.
> 
> This is expected and cannot be avoided without implementing
> port_vlan_filtering + port_vlan_add/del. And adding both bridge and
> VLAN offloading at the same time would be too much for anyone to
> review.
> 
> All other relevant selftests (including bridge_vlan_unaware.sh) are
> still passing.

I forgot to add that (as expected) also test

VLAN-aware bridge with different PVIDs: Checking which packets were received

now fails in no_forwarding.sh, and will be fixed by implementing VLAN
operations in the next series.


> 
> Daniel Golle (2):
>   dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark()
>   net: dsa: mxl862xx: implement bridge offloading
> 
>  drivers/net/dsa/mxl862xx/mxl862xx-api.h | 171 +++++++
>  drivers/net/dsa/mxl862xx/mxl862xx-cmd.h |  19 +-
>  drivers/net/dsa/mxl862xx/mxl862xx.c     | 576 ++++++++++++++++++++++--
>  drivers/net/dsa/mxl862xx/mxl862xx.h     |  21 +
>  net/dsa/tag_mxl862xx.c                  |   2 +
>  5 files changed, 757 insertions(+), 32 deletions(-)
> 
> -- 
> 2.53.0

      parent reply	other threads:[~2026-03-07  3:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07  3:29 [PATCH net-next 0/2] net: dsa: mxl862xx: add support for bridge offloading Daniel Golle
2026-03-07  3:30 ` [PATCH net-next 1/2] dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark() Daniel Golle
2026-03-07  9:57   ` Jonas Gorski
2026-03-08 15:18     ` Daniel Golle
2026-03-08 20:15       ` Jonas Gorski
2026-03-09  0:02         ` Daniel Golle
2026-03-09  8:07           ` Jonas Gorski
2026-03-09 12:23             ` Daniel Golle
2026-03-09 23:33             ` Vladimir Oltean
2026-03-07  3:31 ` [PATCH net-next 2/2] net: dsa: mxl862xx: implement bridge offloading Daniel Golle
2026-03-09 23:22   ` Jakub Kicinski
2026-03-09 23:27   ` Vladimir Oltean
2026-03-07  3:39 ` Daniel Golle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaud6NQWZB5eol-8@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=ajayaraman@maxlinear.com \
    --cc=andrew@lunn.ch \
    --cc=cezary.wilmanski@adtran.com \
    --cc=chad@monroe.io \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=frankwu@gmx.de \
    --cc=horms@kernel.org \
    --cc=john@phrozen.org \
    --cc=jverdu@maxlinear.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lxu@maxlinear.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=yweng@maxlinear.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox