From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C32D1A76DE; Sat, 7 Mar 2026 03:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772854768; cv=none; b=KeG7DAUQfuUST5cDMojl2z7rwG949Nr3BaBNoj38q6e47WHQeFA3aG3TvMfrPs2eW5nSwWRIPe9x8hAKmNbAa3rOO56tKmj+hck4+byCIyrv/AGb2sXip7WDSxU8/oZ8YpYQmbsrlgsLkBZSc6ZXIGm+G1CzaQQyblMDt4RthiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772854768; c=relaxed/simple; bh=KscHdiSEQiii0HKqx4eJDbtIJ199rOzryEaumQFHEQw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hEiACriQOa1AEuy1kHo4rZKVTCAOxvOxxHmyGji33ev58cYZY0ZEz6/dqxjqis1wWCO87OOIGucxfwDrFjV2Od8VpY+LQ2vXhIndsMeIBtliFCYFYh23ORaZmf7oSFT/hZH+QIqr0poib6hda7YqPUMbZOGOOBCj4Z7CSiQqryo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vyiVf-0000000040j-2Zqp; Sat, 07 Mar 2026 03:39:23 +0000 Date: Sat, 7 Mar 2026 03:39:20 +0000 From: Daniel Golle To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Liang Xu , "Benny (Ying-Tsan) Weng" , Jose Maria Verdu Munoz , Avinash Jayaraman , John Crispin Subject: Re: [PATCH net-next 0/2] net: dsa: mxl862xx: add support for bridge offloading Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Mar 07, 2026 at 03:29:15AM +0000, Daniel Golle wrote: > As a next step to complete the mxl862xx DSA driver, add support for > offloading forwarding between bridged ports to the switch hardware. > > This works pretty much without any big surprises, apart from two > subtleties: > * per-port control over flooding behavior has to be implemented by > (ab)using a 0-rate QoS meters as stopper in lack of any better > option. > * STP state transition unconditionally enables learning on a port > even if it was previously explicitely disabled (a firmware bug) > > Note that as the driver is still lacking all VLAN features (which > are going to be added next), at this point some of the > bridge_vlan_aware.sh tests are failing after applying this series. > > This is expected and cannot be avoided without implementing > port_vlan_filtering + port_vlan_add/del. And adding both bridge and > VLAN offloading at the same time would be too much for anyone to > review. > > All other relevant selftests (including bridge_vlan_unaware.sh) are > still passing. I forgot to add that (as expected) also test VLAN-aware bridge with different PVIDs: Checking which packets were received now fails in no_forwarding.sh, and will be fixed by implementing VLAN operations in the next series. > > Daniel Golle (2): > dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark() > net: dsa: mxl862xx: implement bridge offloading > > drivers/net/dsa/mxl862xx/mxl862xx-api.h | 171 +++++++ > drivers/net/dsa/mxl862xx/mxl862xx-cmd.h | 19 +- > drivers/net/dsa/mxl862xx/mxl862xx.c | 576 ++++++++++++++++++++++-- > drivers/net/dsa/mxl862xx/mxl862xx.h | 21 + > net/dsa/tag_mxl862xx.c | 2 + > 5 files changed, 757 insertions(+), 32 deletions(-) > > -- > 2.53.0