From: Florian Westphal <fw@strlen.de>
To: Hyunwoo Kim <imv4bel@gmail.com>
Cc: pablo@netfilter.org, phil@nwl.cc, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] netfilter: nf_flow_table_offload: fix heap overflow in flow_action_entry_next()
Date: Sat, 7 Mar 2026 20:04:41 +0100 [thread overview]
Message-ID: <aax2yZtJce0d19gd@strlen.de> (raw)
In-Reply-To: <aaxe-uH2Qr6qM4E9@v4bel>
Hyunwoo Kim <imv4bel@gmail.com> wrote:
> flow_action_entry_next() increments num_entries and returns a pointer
> into the flow_action_entry array without any bounds checking. The array
> is allocated with a fixed size of NF_FLOW_RULE_ACTION_MAX (16) entries,
> but certain combinations of IPv6 + SNAT + DNAT + double VLAN (QinQ)
> require 17 or more entries, causing a slab-out-of-bounds write in the
> kmalloc-4k slab.
>
> The maximum possible entry count is:
> tunnel(2) + eth(4) + VLAN(4) + IPv6_NAT(10) + redirect(1) = 21
>
> Increase NF_FLOW_RULE_ACTION_MAX to 24 (with headroom) to cover the
>
> -#define NF_FLOW_RULE_ACTION_MAX 16
> +#define NF_FLOW_RULE_ACTION_MAX 24
This fix looks rather fragile.
What guarantees that this stays right-sized?
Can you add a BUILD_BUG_ON or if needed, run-time check?
next prev parent reply other threads:[~2026-03-07 19:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 17:23 [PATCH net] netfilter: nf_flow_table_offload: fix heap overflow in flow_action_entry_next() Hyunwoo Kim
2026-03-07 19:04 ` Florian Westphal [this message]
2026-03-16 10:53 ` Florian Westphal
2026-03-16 11:23 ` Hyunwoo Kim
2026-03-16 11:31 ` Hyunwoo Kim
2026-03-16 11:48 ` Florian Westphal
2026-03-16 11:56 ` Pablo Neira Ayuso
2026-03-16 14:17 ` Hyunwoo Kim
2026-03-16 14:58 ` Florian Westphal
2026-03-25 14:27 ` Florian Westphal
2026-03-25 15:18 ` Pablo Neira Ayuso
2026-03-08 10:41 ` Pablo Neira Ayuso
2026-03-26 21:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aax2yZtJce0d19gd@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imv4bel@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox