From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 709BF39A06B; Fri, 20 Mar 2026 12:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774008519; cv=none; b=glExonf8n06qLpNcqqeKUtwEvbVlcORUtXvpl2dPHoopem9A6AIvqmwPQzRCZOjw1pb5NXMleBx3qHE2VCuVU/MQRHlltS/TYygMoVXxCIWIUal3XbCagcymwhP1cHFaBDR/PK5RCDdEfBGWYoezWZquZJJXp/JnmfNn061cP10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774008519; c=relaxed/simple; bh=rt5mAqVgT2DpnDuBJS+RgFzkBgiqbY7caCPN2LAI86M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i+HrDL5QomWq82MkMhuMqIbFi3nD0zYnimSbA1kZRO2mBN4dytOs5n9E9v6qls5C+6dFjojUHtKul+flGU/Z+LbcXS//gBQd482C6Vk4tQ9AswvWPSiZ94LQMOPfkhLYwS8YSboD9kbyMc/f6v2eDkBet03DJdiz/1XoeLRnisE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ND1ESRaH; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ND1ESRaH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774008519; x=1805544519; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rt5mAqVgT2DpnDuBJS+RgFzkBgiqbY7caCPN2LAI86M=; b=ND1ESRaHpxHvYdrBOzW/ecdMwpwPCLCMFdhYshpqGfigO0XzPmgAwJwN jq+g7kZztdO0gVExJAXEXz1JI5x3Z/ijPE7TxxMIaTYQ1rw+8TmOe101e JEosQ4MASLJNWqUdZ513ZQa6+6/tbPGsbF8cufL9+OSNQSV72lmbtCbiE QGacXZ22O5HGKNEodpU3oUCrtcG/C1h7phWr4pgVB1sNkVImSguI9ibsj EOUhkcfUB4ZF46qaAas5avCTXqjWSPjfrZhgb83FYZrBiCJOmnMycCI5V ayedkqYdh5i5g5UrD0/uO61tFH+RI3ghxPdeNmzC4oMyVNMn2qU4pnxOM Q==; X-CSE-ConnectionGUID: fxGVwqtCTGuECCT/egMyrw== X-CSE-MsgGUID: rESNOd8SRWOhux3XRuOaWw== X-IronPort-AV: E=McAfee;i="6800,10657,11735"; a="74981525" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="74981525" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 05:08:38 -0700 X-CSE-ConnectionGUID: QnkFAKxkSRyO93ncc+2hmg== X-CSE-MsgGUID: aCVnXZOuT4KHWhsptBu7bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="219080561" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa010.fm.intel.com with ESMTP; 20 Mar 2026 05:08:36 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id E488295; Fri, 20 Mar 2026 13:08:34 +0100 (CET) Date: Fri, 20 Mar 2026 13:08:34 +0100 From: Andy Shevchenko To: Sean Chang Cc: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros Message-ID: References: <20260319141846.78222-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319141846.78222-1-seanwascoding@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Mar 19, 2026 at 10:18:43PM +0800, Sean Chang wrote: > This series cleans up redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards > across sunrpc, nfsd, and lockd, as these checks are already handled > within the dprintk macros. > > Additionally, it refactors the nfs_errorf() macros into a safer > do-while(0) pattern and removes unused nfs_warnf() macros to improve > code maintainability. Shall we also revert the commit ebae102897e7 ("nfsd: Mark variable __maybe_unused to avoid W=1 build break") as it seems related to dprintk() issues? -- With Best Regards, Andy Shevchenko