From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97F543C9450 for ; Fri, 20 Mar 2026 15:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774021767; cv=none; b=th6rzericKB2U+y3voNbpsQCKoLssHGuiulVG+LRfVVo/oadZLVKhNOCCCJ1VhoFmBJaf2QXVALegx7CBG+X53irHr5vz6CyIA/nR5AEZ0WkOS/g1c3M4t3NwOGctlhn8VuxvpPLhBfFy+GzCn1qgcgWNiCHHvhp6oUYzikIpUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774021767; c=relaxed/simple; bh=5bNAXGs4cIMFl6Jp32gKXXVAunXQc+McFM1c11Lf6k8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pgTwKHZMg4u7mMmaH2yK2ckV5SHNlVfPKn7Rk3q8BPCT9xAme4Bs2Y18QzWPmrfsuQpoOAI0k72fZ2gmfu2dWcblbKtlSmthbFoJiolNUDMDDWy2vSs7z5d43nhEUs7Eq28UE+yAApurMo6NzuPL0RS7GiKOZGrDFjFgFE7fMM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TqsD+V0e; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TqsD+V0e" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2c0ea57fea7so2315596eec.0 for ; Fri, 20 Mar 2026 08:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774021762; x=1774626562; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=1noh5STaRC1HybhuYlkIMhR1r7TUdhM17pEfO/82ZhA=; b=TqsD+V0efLCtHkR1v28WRt0ZjiiW/DszxVXs02Ss3Npx+nBeLDXahfbuKHiLDCTLSe inyjk1ptvRR6l54nMhspWFgyvXYAUxbWUYiolNYh9Qa1qGeooZziXfx+RfI9uXO2njsA PIpZtIu7oWFT6pEsus+o8J8qjU+m5TpUDuoHorrWyc0ytHXUY8FhseaZTO8w+V5uKNYY a7o8ojWZZeV2eg031HmOhxAtE60w6Jg0HANc8MKeFab2GPPV44poRCB9TV1I26WLeYov WLaN85UITDG7rFc9tb0RrZC4GSNptfEm1lkkFmW71Hpg0Y6NXP4QijvMFvn72cUC5MRc tQgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774021762; x=1774626562; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1noh5STaRC1HybhuYlkIMhR1r7TUdhM17pEfO/82ZhA=; b=pIp8kjFQOtT61ItsLV6S9JOzV81wdYh66LMPttqqX0nYAiCtuh9R1hdTJFgMVb9KBr PpvuWKJi6JmRUuuEkp+9yq7wo0Lg3/JyC9p5DnPGBq/yGzWUEQdR2+28IDAxC8KwmyOA yHSeC32+UW/4sgrqDRGMhHwgekjbsZxmdTxPWyjRlH3uC7uRVda7mNBG6wdFaZbdqWCl c1FBz0AGd/WWUlYntkKk1Zg3rG2sOu33QaQ1C/vYLQI2akeOBGRhuMxZtK9HQ/hZanZO edZMJSqdHy1bXn92hWIKBtqeruefGdrCKs0H7Un2oNmgjcB5fTaPadg/aXKtreoCjik+ qWsA== X-Forwarded-Encrypted: i=1; AJvYcCVYZTrEkGGT+bWg2NbPxVnW5Z6AQw1hul1+phsBgocrAwnRqPZA/wzr9aU5UDgFO4kw2SeJOkI=@vger.kernel.org X-Gm-Message-State: AOJu0YwidhgWhDMMsN+bB92M39sb1S+4nWXzqPLxwR3xTaQwvU+sVssx rozAI6O3T+QXat8HMtnUf3YfMF5BG6OyOAmuAtFNQlUBR5JrGnnOSjs= X-Gm-Gg: ATEYQzwFBE9Z0xLzIfb416YMFMzdb7vUuMsEFB+RfGwP4cPh5Ifg1xABD4O5KDzO8sN pGn4drZqkOT4E2P634Wz5qBatO4S1YhPei9yynh4P9GGGTEsynHNaupbtPIy7hnUKcNLFLyLl89 FeIUUM4RASSBOBmbmFlpend2fSz0rcjdAJdmbsjjY3JcFi9PSvbM4wMVx7ra4nLkOyfED4UrVTU 47uS0w2SQGNfAIU4M2nHQL0WugWVrPzpCaA6Mp1AjRvhhE2lk1uTA3yU2vXpm0g+IeiyZa/zLkn +H89Sag3Ez2xLqq9Z2JvZt0a6+3rfGeHOS31Qu467mCrOglmuP31UttRjmHj6hTh69yIlKuJ63v sfWfm8HVAreh2YNFJaKwnL+lK8LR1bDln3vhaGJP+orPhhi33ZpBR46cwjg6pfs3VHDE6SayTYl olsI5XY851Gq7bJHjj4Bnfq3QMVsc6qimCcIs2UrgE7XXQUR7RM2JjsEIQNpv5JB9tMHf4Gx42j 9X7uKiWrUXBu/1DMgUfZJ/Y5rc9 X-Received: by 2002:a05:693c:3106:b0:2b7:b7e7:9025 with SMTP id 5a478bee46e88-2c10980a36dmr1639723eec.31.1774021762125; Fri, 20 Mar 2026 08:49:22 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b17b1b8sm3724371eec.8.2026.03.20.08.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 08:49:21 -0700 (PDT) Date: Fri, 20 Mar 2026 08:49:20 -0700 From: Stanislav Fomichev To: "Loktionov, Aleksandr" Cc: Stanislav Fomichev , "netdev@vger.kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "corbet@lwn.net" , "skhan@linuxfoundation.org" , "andrew+netdev@lunn.ch" , "michael.chan@broadcom.com" , "pavan.chebbi@broadcom.com" , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , "saeedm@nvidia.com" , "tariqt@nvidia.com" , "mbloch@nvidia.com" , "alexanderduyck@fb.com" , "kernel-team@meta.com" , "johannes@sipsolutions.net" , "sd@queasysnail.net" , "jianbol@nvidia.com" , "dtatulea@nvidia.com" , "mohsin.bashr@gmail.com" , "Keller, Jacob E" , "willemb@google.com" , "skhawaja@google.com" , "bestswngs@gmail.com" , "kees@kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "leon@kernel.org" Subject: Re: [Intel-wired-lan] [PATCH net-next v3 03/13] net: introduce ndo_set_rx_mode_async and dev_rx_mode_work Message-ID: Mail-Followup-To: Stanislav Fomichev , "Loktionov, Aleksandr" , Stanislav Fomichev , "netdev@vger.kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "corbet@lwn.net" , "skhan@linuxfoundation.org" , "andrew+netdev@lunn.ch" , "michael.chan@broadcom.com" , "pavan.chebbi@broadcom.com" , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , "saeedm@nvidia.com" , "tariqt@nvidia.com" , "mbloch@nvidia.com" , "alexanderduyck@fb.com" , "kernel-team@meta.com" , "johannes@sipsolutions.net" , "sd@queasysnail.net" , "jianbol@nvidia.com" , "dtatulea@nvidia.com" , "mohsin.bashr@gmail.com" , "Keller, Jacob E" , "willemb@google.com" , "skhawaja@google.com" , "bestswngs@gmail.com" , "kees@kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "leon@kernel.org" References: <20260320012501.2033548-1-sdf@fomichev.me> <20260320012501.2033548-4-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On 03/20, Loktionov, Aleksandr wrote: > > > > -----Original Message----- > > From: Intel-wired-lan On Behalf > > Of Stanislav Fomichev > > Sent: Friday, March 20, 2026 2:25 AM > > To: netdev@vger.kernel.org > > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > > pabeni@redhat.com; horms@kernel.org; corbet@lwn.net; > > skhan@linuxfoundation.org; andrew+netdev@lunn.ch; > > michael.chan@broadcom.com; pavan.chebbi@broadcom.com; Nguyen, Anthony > > L ; Kitszel, Przemyslaw > > ; saeedm@nvidia.com; tariqt@nvidia.com; > > mbloch@nvidia.com; alexanderduyck@fb.com; kernel-team@meta.com; > > johannes@sipsolutions.net; sd@queasysnail.net; jianbol@nvidia.com; > > dtatulea@nvidia.com; sdf@fomichev.me; mohsin.bashr@gmail.com; Keller, > > Jacob E ; willemb@google.com; > > skhawaja@google.com; bestswngs@gmail.com; Loktionov, Aleksandr > > ; kees@kernel.org; linux- > > doc@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired- > > lan@lists.osuosl.org; linux-rdma@vger.kernel.org; linux- > > wireless@vger.kernel.org; linux-kselftest@vger.kernel.org; > > leon@kernel.org > > Subject: [Intel-wired-lan] [PATCH net-next v3 03/13] net: introduce > > ndo_set_rx_mode_async and dev_rx_mode_work > > > > Add ndo_set_rx_mode_async callback that drivers can implement instead > > of the legacy ndo_set_rx_mode. The legacy callback runs under the > > netif_addr_lock spinlock with BHs disabled, preventing drivers from > > sleeping. The async variant runs from a work queue with rtnl_lock and > > netdev_lock_ops held, in fully sleepable context. > > > > When __dev_set_rx_mode() sees ndo_set_rx_mode_async, it schedules > > dev_rx_mode_work instead of calling the driver inline. The work > > function takes two snapshots of each address list (uc/mc) under the > > addr_lock, then drops the lock and calls the driver with the work > > copies. After the driver returns, it reconciles the snapshots back to > > the real lists under the lock. > > > > Reviewed-by: Aleksandr Loktionov > > Signed-off-by: Stanislav Fomichev > > --- > > Documentation/networking/netdevices.rst | 8 +++ > > include/linux/netdevice.h | 20 ++++++ > > net/core/dev.c | 95 +++++++++++++++++++++++- > > - > > 3 files changed, 116 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/networking/netdevices.rst > > b/Documentation/networking/netdevices.rst > > index 35704d115312..dc83d78d3b27 100644 > > --- a/Documentation/networking/netdevices.rst > > +++ b/Documentation/networking/netdevices.rst > > @@ -289,6 +289,14 @@ struct net_device synchronization rules > > ndo_set_rx_mode: > > Synchronization: netif_addr_lock spinlock. > > Context: BHs disabled > > ... > > > to > > +device > > + * and configure RX filtering. > > + * @dev: device > > + * > > + * When the device doesn't support unicast filtering it is put in > > +promiscuous > > + * mode while unicast addresses are present. > > */ > > void __dev_set_rx_mode(struct net_device *dev) { > > const struct net_device_ops *ops = dev->netdev_ops; > > > > /* dev_open will call this function so the list will stay sane. > > */ > > - if (!(dev->flags&IFF_UP)) > > + if (!netif_up_and_present(dev)) > > return; > > > > - if (!netif_device_present(dev)) > > + if (ops->ndo_set_rx_mode_async) { > > + queue_work(rx_mode_wq, &dev->rx_mode_work); > > return; > This early return skips the legacy core fallback below. > Before this patch, __dev_set_rx_mode() continued into the > existing unicast-filter handling when the device did not > advertise IFF_UNICAST_FLT. > > After this patch, any driver that implements > ndo_set_rx_mode_async but does not set IFF_UNICAST_FLT > will never hit that fallback path. I believe this is addressed later in "net: move promiscuity handling into dev_rx_mode_work"? That should take care of doing __dev_set_promiscuity for !IFF_UNICAST_FLT+ndo_set_rx_mode_async. Not sure if there is a better way to rearrange the chunks in the patches. if (ops->ndo_set_rx_mode_async) { ... + promisc_inc = dev_uc_promisc_update(dev); + + netif_addr_unlock_bh(dev); + } else { + netif_addr_lock_bh(dev); + promisc_inc = dev_uc_promisc_update(dev); + netif_addr_unlock_bh(dev); + } + + if (promisc_inc) + __dev_set_promiscuity(dev, promisc_inc, false); +