From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sean Chang <seanwascoding@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
Anna Schumaker <anna@kernel.org>,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] nfsd: remove obsolete __maybe_unused from variables
Date: Fri, 20 Mar 2026 21:17:45 +0200 [thread overview]
Message-ID: <ab2dWegGmQOX61nA@ashevche-desk.local> (raw)
In-Reply-To: <20260320180955.150696-6-seanwascoding@gmail.com>
On Sat, Mar 21, 2026 at 02:09:55AM +0800, Sean Chang wrote:
> Now that dprintk() has been refactored to use no_printk(), variables
> used only for debugging are properly referenced by the compiler even
> when CONFIG_SUNRPC_DEBUG is disabled.
>
> Therefore, the __maybe_unused attributes added in commit ebae102897e7
> ("nfsd: Mark variable __maybe_unused to avoid W=1 build break") are
> no longer necessary. This patch removes them to clean up the code.
Just make it a revert: proper Subject like 'Revert: "..."' and
the Git added line "This reverts ...".
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-20 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 18:09 [PATCH v4 0/5] sunrpc/nfs: cleanup redundant debug checks and refactor macros Sean Chang
2026-03-20 18:09 ` [PATCH v4 1/5] sunrpc: Fix dprintk type mismatch using do-while(0) Sean Chang
2026-03-20 18:09 ` [PATCH v4 2/5] nfsd/lockd: Remove redundant debug checks Sean Chang
2026-03-20 18:09 ` [PATCH v4 3/5] svcrdma: remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Sean Chang
2026-03-20 18:09 ` [PATCH v4 4/5] nfs: refactor nfs_errorf macros and remove unused ones Sean Chang
2026-03-20 19:22 ` Andy Shevchenko
2026-03-20 18:09 ` [PATCH v4 5/5] nfsd: remove obsolete __maybe_unused from variables Sean Chang
2026-03-20 19:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2dWegGmQOX61nA@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andrew@lunn.ch \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=seanwascoding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox