From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0F7CA9ED0 for ; Fri, 1 Nov 2019 12:16:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EEC72085B for ; Fri, 1 Nov 2019 12:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728334AbfKAMQg (ORCPT ); Fri, 1 Nov 2019 08:16:36 -0400 Received: from www62.your-server.de ([213.133.104.62]:36196 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727279AbfKAMQg (ORCPT ); Fri, 1 Nov 2019 08:16:36 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iQVr0-0004Q6-5f; Fri, 01 Nov 2019 13:16:34 +0100 Received: from [178.197.249.38] (helo=pc-63.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1iQVqz-0008n3-Tb; Fri, 01 Nov 2019 13:16:33 +0100 Subject: Re: [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files without read permission" To: Jakub Kicinski , alexei.starovoitov@gmail.com Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, bpf@vger.kernel.org, jiri@resnulli.us References: <20191101005127.1355-1-jakub.kicinski@netronome.com> From: Daniel Borkmann Message-ID: Date: Fri, 1 Nov 2019 13:16:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191101005127.1355-1-jakub.kicinski@netronome.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25620/Fri Nov 1 10:04:15 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/1/19 1:51 AM, Jakub Kicinski wrote: > This reverts commit 5bc60de50dfe ("selftests: bpf: Don't try to read > files without read permission"). > > Quoted commit does not work at all, and was never tested. > Script requires root permissions (and tests for them) > and os.access() will always return true for root. > > The correct fix is needed in the bpf tree, so let's just > revert and save ourselves the merge conflict. > > Signed-off-by: Jakub Kicinski Applied, thanks!