From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:35984 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbeBUGfY (ORCPT ); Wed, 21 Feb 2018 01:35:24 -0500 Received: by mail-lf0-f67.google.com with SMTP id t79so803856lfe.3 for ; Tue, 20 Feb 2018 22:35:24 -0800 (PST) Subject: Re: [PATCH iproute2-next v2 3/7] iplink: Use "dev" and "name" parameters interchangeable when possible To: Stephen Hemminger Cc: netdev@vger.kernel.org, dsahern@gmail.com References: <1519162649-22449-1-git-send-email-serhe.popovych@gmail.com> <1519162649-22449-4-git-send-email-serhe.popovych@gmail.com> <20180220150426.2d2527c5@xeon-e3> From: Serhey Popovych Message-ID: Date: Wed, 21 Feb 2018 08:35:15 +0200 MIME-Version: 1.0 In-Reply-To: <20180220150426.2d2527c5@xeon-e3> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7YmfqGm3D5jZa9WTl5ygODqZe6tLjhPB4" Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7YmfqGm3D5jZa9WTl5ygODqZe6tLjhPB4 Content-Type: multipart/mixed; boundary="3YCd3LLIFxQKv5A66vJUi8Tab2t1Wdp7r"; protected-headers="v1" From: Serhey Popovych To: Stephen Hemminger Cc: netdev@vger.kernel.org, dsahern@gmail.com Message-ID: Subject: Re: [PATCH iproute2-next v2 3/7] iplink: Use "dev" and "name" parameters interchangeable when possible References: <1519162649-22449-1-git-send-email-serhe.popovych@gmail.com> <1519162649-22449-4-git-send-email-serhe.popovych@gmail.com> <20180220150426.2d2527c5@xeon-e3> In-Reply-To: <20180220150426.2d2527c5@xeon-e3> --3YCd3LLIFxQKv5A66vJUi8Tab2t1Wdp7r Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Stephen Hemminger wrote: > On Tue, 20 Feb 2018 23:37:25 +0200 > Serhey Popovych wrote: >=20 >> Both of them accept network device name as argument, but have differen= t >> meaning: >> >> dev - is a device by it's name, >> name - name for specific device device. >> >> The only case where they treated separately is network device rename >> case where need to specify both ifindex and new name. In rest of the >> cases we can assume that dev =3D=3D name. >=20 > I would rather keep name as only being a valid argument for set command= =2E > And reject use of: >=20 > ip li show name eth0 >=20 But ip-link(8) man page is full of examples where "name" is used instead of "dev". I suppose there are lot of configuration we can broke when explicitly disabling "name" as an alternative to "dev". Especially on the first lines in man page we have: ip link add [ link DEVICE ] [ name ] NAME =2E.. and there is no reference to "dev". What do you think? --3YCd3LLIFxQKv5A66vJUi8Tab2t1Wdp7r-- --7YmfqGm3D5jZa9WTl5ygODqZe6tLjhPB4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJajRMoAAoJEBTawMmQ61bBhegH/jPJqpJIGh7qz/1BQRq9dNFs KYyrT8BlcBfgIzO7uEtssrjeZgbHCw2+KU18Pyb2erB0mUFLnqJGQ2oHhfnpdthr baz9WyfI63u49o34S7/b4WsHj2F06/K47KGcOL9sXdHgCGZz0BjPGL2P/SP+1rXd tqY98WnczQcMGEI0DXaLov3ZIESabe/W9HXBXmdNQAfFoeZY3J0hEor05WHXP0LM 9WGtYAgh2MlkePUYdnLfSK9HSY/Clr6N+Dxwk2JyHyEqpdm+PYWuSPmE6X+ZnSDR c3uakQa3M/pcOu05k3xs6PYFgMSSZIypfZ/L8oxKmsaidrwVsNVi6o3tILt2wzw= =MhhM -----END PGP SIGNATURE----- --7YmfqGm3D5jZa9WTl5ygODqZe6tLjhPB4--