From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934472E9ED6 for ; Wed, 20 May 2026 06:23:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779258211; cv=none; b=ne/C4cjHTA5ymxMv2MdeplOH0DdixBxASln/nrAwgftXfC0VTfQ6h7xC+WX65kYfmnkgo/XTK6hLMfB+6DECnk0oUgrVAlddYMMGBfiArxWVORYoKa43iAn3oUVyrsrmpc7TJn/YBEj1OR8Y/UgYsnLDkP8aXO5dxFsf4l97mUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779258211; c=relaxed/simple; bh=7Q4R3furNO4h7Yab4Zal4eqQik4zrrk78QCoGOUHkXo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WKc7oB5h+ExJygCvkiMsUwD1J29T8NMxW8LUq2sOPnvPsvvorSasCSaU0BXZsRRPyXj5gRyZfEF8VT/iUgCTmDKj8KAnVoV2O9Vqv3NpJF5CRp7En672szVaG8FGo9zlCxdQv5b93kzMLKe5+Lflk/1HSPfR1YAbg/f8Rzrm9BI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=HCgskJps; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="HCgskJps" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id D084E1A363B; Wed, 20 May 2026 06:23:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 92FA26070E; Wed, 20 May 2026 06:23:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0C18E107E9C49; Wed, 20 May 2026 08:23:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1779258205; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=rOjeYYdRzTDpwvWM8Id5nwUl+GQuplW0764wBAzrADA=; b=HCgskJpsQG8gVXl9+SoAB/vz+1ZCE4A/g7IhpEWm8/f9oQkUwG8VKMQkOML4lNgjkXfeoX mCBOGBiXzTg/FAF3nkVINXZE6TNVJ4GVDHF6Q0xsZOvcdpaiSYj/UnsdFCo9M46YG3IrQS QNCJGN79f8H/94dxfb+iSWNeVKeERPgcj7XFXp6nv3KmHv2r6Z2c1kkiLoSWWg2cQWGrFV m6jRWKJGncBKVl3B7i7XsNDL2/sQarb+fARZi2fcdOimMjCD43bDhBARPDWcj9zhpCl0Vp ZvphHVhb+vFPVAKXT+zOudfER/Cowypdjax6OB9GIZZ0sMy9A1MN5RmIaVxU7w== Message-ID: Date: Wed, 20 May 2026 08:23:20 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/8] net: dsa: microchip: don't reset on shutdown or driver removal To: Jakub Kicinski Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , Richard Cochran , Pascal Eberhard , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , Tristram Ha , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Oltean References: <20260515-clean-ksz-2nd-series-v2-0-35a968a739f6@bootlin.com> <20260515-clean-ksz-2nd-series-v2-1-35a968a739f6@bootlin.com> <20260519191006.01f83aed@kernel.org> Content-Language: en-US From: Bastien Curutchet In-Reply-To: <20260519191006.01f83aed@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jakub, On 5/20/26 4:10 AM, Jakub Kicinski wrote: > On Fri, 15 May 2026 10:38:36 +0200 Bastien Curutchet wrote: >> @@ -4170,16 +4170,15 @@ int ksz_set_wol(struct dsa_switch *ds, int port, >> * the wol_enabled flag accordingly to reflect whether WoL is active on any >> * port. >> */ >> -static void ksz_wol_pre_shutdown(struct ksz_device *dev, bool *wol_enabled) >> +static void ksz_wol_pre_shutdown(struct ksz_device *dev) > > this needs a kdoc update, did I not report it on v1? > Maybe I forgot. scripts/kernel-doc is buggy, unfortunately > and doesn't catch it. The fix is on the way. Ok, I'll fix it in v3. I don't think that you reported it on v1. Best regards, Bastien