From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status
Date: Sun, 31 Mar 2019 17:05:35 +0200 [thread overview]
Message-ID: <ab8a25a6-5bc6-731d-4f58-0a775881b3cf@gmail.com> (raw)
In-Reply-To: <20190331145813.GD20636@lunn.ch>
On 31.03.2019 16:58, Andrew Lunn wrote:
>> - In auto-neg case, skip populating lp_advertising if we
>> don't have a link. This avoids quite some unnecessary
>> MDIO reads in case of phylib polling mode.
>
> Hi Heiner
>
> Could it be that we don't have a link because what the partner is
> advertising does not intersect with what we are advertising?
>
Interesting point. Yes, I think I missed that scenario.
> Hence knowing what it is adverting is actually useful in this case?
>
> Andrew
>
Heiner
next prev parent reply other threads:[~2019-03-31 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 9:22 [PATCH net-next] net: phy: improve genphy_read_status Heiner Kallweit
2019-03-31 14:52 ` Andrew Lunn
2019-03-31 14:59 ` Heiner Kallweit
2019-03-31 15:33 ` Andrew Lunn
2019-03-31 14:58 ` Andrew Lunn
2019-03-31 15:05 ` Heiner Kallweit [this message]
2019-04-02 17:39 ` Heiner Kallweit
2019-04-02 1:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab8a25a6-5bc6-731d-4f58-0a775881b3cf@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).