From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44107C43381 for ; Sun, 31 Mar 2019 15:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 113552086C for ; Sun, 31 Mar 2019 15:05:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oas4JKAJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731290AbfCaPFn (ORCPT ); Sun, 31 Mar 2019 11:05:43 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36153 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731240AbfCaPFn (ORCPT ); Sun, 31 Mar 2019 11:05:43 -0400 Received: by mail-wr1-f67.google.com with SMTP id y13so8598004wrd.3 for ; Sun, 31 Mar 2019 08:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kedslvWEJGss7fjDf6CemlalTRHlpMtbrxGMxQgGrEk=; b=Oas4JKAJK2285IyEnRcrBJg5jircjrFJtmCIy+a4Ca1QiVyl1sjdcbW+qIQAQVGBk9 PEDyb7efGjqMNokty8h9/kQ3TC3C6JzLFPj+5FGes0NSpQkn+PHDIWjZ5RikUVAVFhNS YuqMjVdX5+/TObxKg6hWhbSSvjuq+ofGpanKm7YRucw4Iuk1DzUEWxq1VYt7CoU0nh7o DetvhfkyHYRr+lrs42ylGBPV0I7mtUnb3v0Uz+oGcLulQsnr76N1lcwxta5uqI4dTtxt 6ulpCxmUUQbALAI0icwLanvIjOU1yCGt4mXgE6CZWcHiFrofM01rtYK6GmvJLWKdA7vG gTVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kedslvWEJGss7fjDf6CemlalTRHlpMtbrxGMxQgGrEk=; b=dVjqNFjnTDBVz54lOULKt87eezvh3AcWhqrYO3AL/U1jHiGcqfYr0xr1WRBEL2LcuE +Qyn0OVAJUCnNzuBQdgABa46j/cGf/rVB08Gk7Z6s9xfwG5LaUjXuOfl45ZaCs/meS4y 0OGsEshUPydN0PdEPfPaPTJhaTAm/r2cB9fulwSewItt5V6lbgb0mX+7XeAirzrmrQMV sy0SxtDnsWPoR9zso4OigHsmQJq3r01iDZDNuc1GC4skkuWoUevwKyqZeeLMCFwgvde0 F8mB5nSxy7yv3/XM+eBBdREAIH+pUIshSbDnsFqidxcxjjjL1jnVdxFMms38/qISStn5 n5Sg== X-Gm-Message-State: APjAAAWInkYz2tRpJkUiPLo1zTLZQJYjKCihXAw90xvGb2D411FGSBeV /H5l7dPGkmsKkFsWvOXC0x0OoSEQ X-Google-Smtp-Source: APXvYqw8MgQ/ztu3cDLmbGwPt8S9KCgz0XJKkq2DOA0aaq7fscclBS9RQxBGYA6ypOX6S957l4gUAg== X-Received: by 2002:a5d:400c:: with SMTP id n12mr37486452wrp.31.1554044741233; Sun, 31 Mar 2019 08:05:41 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:a4e7:3af3:db88:50bb? (p200300EA8BE1DD00A4E73AF3DB8850BB.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:a4e7:3af3:db88:50bb]) by smtp.googlemail.com with ESMTPSA id k9sm9639032wru.55.2019.03.31.08.05.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 08:05:40 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <36da82de-6dad-939e-7604-d3c0b93f54c8@gmail.com> <20190331145813.GD20636@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sun, 31 Mar 2019 17:05:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190331145813.GD20636@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 31.03.2019 16:58, Andrew Lunn wrote: >> - In auto-neg case, skip populating lp_advertising if we >> don't have a link. This avoids quite some unnecessary >> MDIO reads in case of phylib polling mode. > > Hi Heiner > > Could it be that we don't have a link because what the partner is > advertising does not intersect with what we are advertising? > Interesting point. Yes, I think I missed that scenario. > Hence knowing what it is adverting is actually useful in this case? > > Andrew > Heiner