Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Zxyan Zhu" <zxyan0222@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Björn Töpel" <bjorn@kernel.org>
Subject: Re: [PATCH net-next] net: phylink: add phylink_pcs_loopback() method for PCS loopback support
Date: Fri, 24 Jul 2026 15:05:10 +0200	[thread overview]
Message-ID: <ab95d5f7-dddb-4980-91c6-5be12172534c@lunn.ch> (raw)
In-Reply-To: <42606cde-cdef-420d-adf4-b28c353d564b@bootlin.com>

> Besides that, I don't see and PCS that supports that loopback, I think
> it would be nice to also have the PCS code for loopback as well...

That is pretty much required for merging. We want to see both sides of
a new API.

There has also been discussion about in which direction should it
loopback. Towards the media or towards the host. For self test you
want host side, but as an exposed feature for user space to enable,
media side could also be interesting. So you should think about what
the internal API looks like to be able to specify the loop direction.

    Andrew

  reply	other threads:[~2026-07-24 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  8:52 [PATCH net-next] net: phylink: add phylink_pcs_loopback() method for PCS loopback support Zxyan Zhu
2026-07-24  9:25 ` Maxime Chevallier
2026-07-24 13:05   ` Andrew Lunn [this message]
2026-07-27  9:38 ` [PATCH net-next v2] " Zxyan Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab95d5f7-dddb-4980-91c6-5be12172534c@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bjorn@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=zxyan0222@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox