From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sean Chang <seanwascoding@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
Anna Schumaker <anna@kernel.org>,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sunrpc: simplify dprintk() macros and cleanup redundant debug guards
Date: Wed, 11 Mar 2026 23:47:17 +0200 [thread overview]
Message-ID: <abHi5SOPaaly-v1l@ashevche-desk.local> (raw)
In-Reply-To: <20260303140725.86260-1-seanwascoding@gmail.com>
On Tue, Mar 03, 2026 at 10:07:25PM +0800, Sean Chang wrote:
> Following David Laight's suggestion, simplify the macro definitions by
> removing the unnecessary 'fmt' argument and using no_printk(__VA_ARGS__)
> directly.
>
> Verification with .lst files under -O2 confirms that the compiler
> successfully performs "dead code elimination". Even when variables
> (like char buf[] in nfsfh.c) or static helper functions (like
> nlmdbg_cookie2a() in svclock.c) are declared without #ifdef, they are
> completely optimized out (no stack allocation, no symbol references in
> the final executable) as they are only referenced within no_printk().
Does this patch fixes also 202603110038.P6d14oxa-lkp@intel.com?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-11 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 14:07 [PATCH v2] sunrpc: simplify dprintk() macros and cleanup redundant debug guards Sean Chang
2026-03-11 21:47 ` Andy Shevchenko [this message]
2026-03-12 13:19 ` Chuck Lever
2026-03-12 15:54 ` Sean Chang
2026-03-12 16:14 ` Andy Shevchenko
2026-03-12 17:52 ` Chuck Lever
2026-03-17 13:04 ` Sean Chang
2026-03-17 14:20 ` Andy Shevchenko
2026-03-18 16:21 ` Sean Chang
2026-03-18 16:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abHi5SOPaaly-v1l@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andrew@lunn.ch \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=seanwascoding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox