From: Inochi Amaoto <inochiama@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Inochi Amaoto <inochiama@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Richard Cochran <richardcochran@gmail.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Yao Zi <me@ziyao.cc>, Yanteng Si <siyanteng@cqsoftware.com.cn>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Chen-Yu Tsai <wens@kernel.org>,
Shangjuan Wei <weishangjuan@eswincomputing.com>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH net-next v9 3/4] net: stmmac: Add glue layer for Spacemit K3 SoC
Date: Fri, 13 Mar 2026 10:43:05 +0800 [thread overview]
Message-ID: <abN5Xn5GCa_UqCbO@inochi.infowork> (raw)
In-Reply-To: <20260312193801.61c30de4@kernel.org>
On Thu, Mar 12, 2026 at 07:38:01PM -0700, Jakub Kicinski wrote:
> Some nit picks only to be addressed in case the AI complaint on patch 1
> is legit..
>
> On Thu, 12 Mar 2026 09:22:25 +0800 Inochi Amaoto wrote:
> > +config DWMAC_SPACEMIT
> > + tristate "Spacemit dwmac support"
> > + depends on OF && (ARCH_SPACEMIT || COMPILE_TEST)
> > + select MFD_SYSCON
> > + default m if ARCH_SPACEMIT
>
> I know other STMMAC sub-drivers do it but isn't the defconfig for
> the platform the right place to add this sort of default?
>
> > + apmu = syscon_regmap_lookup_by_phandle_args(pdev->dev.of_node,
> > + "spacemit,apmu", 2,
> > + offset);
> > + if (IS_ERR(apmu))
> > + return dev_err_probe(dev, PTR_ERR(apmu),
> > + "Failed to get apmu regmap\n");
>
> looks mis-aligned
Yes, that's true. I will fix this.
Regards,
Inochi
next prev parent reply other threads:[~2026-03-13 2:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 1:22 [PATCH net-next v9 0/4] riscv: spacemit: Add ethernet support for K3 Inochi Amaoto
2026-03-12 1:22 ` [PATCH net-next v9 1/4] dt-bindings: net: Add support for Spacemit K3 dwmac Inochi Amaoto
2026-03-13 2:34 ` [net-next,v9,1/4] " Jakub Kicinski
2026-03-12 1:22 ` [PATCH net-next v9 2/4] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string Inochi Amaoto
2026-03-12 1:22 ` [PATCH net-next v9 3/4] net: stmmac: Add glue layer for Spacemit K3 SoC Inochi Amaoto
2026-03-13 2:38 ` Jakub Kicinski
2026-03-13 2:43 ` Inochi Amaoto [this message]
2026-03-12 1:22 ` [PATCH net-next v9 4/4] MAINTAINERS: add entry for SpacemiT DWMAC glue layer Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abN5Xn5GCa_UqCbO@inochi.infowork \
--to=inochiama@gmail.com \
--cc=alex@ghiti.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=boon.khai.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=dlan@kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=looong.bin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=me@ziyao.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peppe.cavallaro@st.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quentin.schulz@cherry.de \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=siyanteng@cqsoftware.com.cn \
--cc=spacemit@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=weishangjuan@eswincomputing.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox