From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: airoha: select QDMA block according LAN/WAN configuration
Date: Fri, 13 Mar 2026 12:35:16 +0100 [thread overview]
Message-ID: <abP2dLNIw6zqkxL4@lore-desk> (raw)
In-Reply-To: <20260312172248.68742f98@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
> On Thu, 12 Mar 2026 22:14:36 +0100 Lorenzo Bianconi wrote:
> > > Is this a bug fix?
> > > If so, perhaps it is for net with a fixes tag.
> >
> > I guess we do not need to target net tree since airoha_eth driver currently
> > supports just the LAN interface via the MT7530 DSA switch connected to GDM1
> > and there are no WAN interfaces officially supported (PCS/external phy is not
> > merged mainline yet, it is only available in OpenWrt).
> >
> > >
> > > And at any rate, could you add some description of the before and after
> > > behaviour?
> >
> > Theoretically, before this patch, GDM ports were equally distributed between
> > QDMA0 and QDMA1 while this patch assigns LAN interfaces to QDMA0 and WAN
> > interface to QDMA1. However, for the reason explained above, this change is
> > not currently visible to the user.
>
> Please update the commit message. And please try harder to explain
> the patches, this happens a lot with your submissions..
ack, fine. Sorry for not beeing very clear about this (and other
patches), I will pay more attention in the future.
Do you think we should target net-next or net for this patch?
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-13 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 14:46 [PATCH net-next] net: airoha: select QDMA block according LAN/WAN configuration Lorenzo Bianconi
2026-03-12 17:24 ` Simon Horman
2026-03-12 21:14 ` Lorenzo Bianconi
2026-03-13 0:22 ` Jakub Kicinski
2026-03-13 11:35 ` Lorenzo Bianconi [this message]
2026-03-13 14:30 ` Simon Horman
2026-03-13 15:25 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abP2dLNIw6zqkxL4@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox