From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6A1F3659FF; Fri, 13 Mar 2026 09:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.8 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773394180; cv=fail; b=XXalcGJe0yd0/Prh9A7DHQm7MaHfqVIJvGgjuJ3eddHboVdxvPM9npfZoyRd9NGu/2ab3jFcPuCDdkpXpPt/dQ1c2DakswJq1HnmF1wejXmgjhv+cXvi5ZtUwDi8uOETwHN27ad5U1oO78DAPFXhKFSs5g4Sjlvxk8tHbYoIn7Q= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773394180; c=relaxed/simple; bh=I+yhEyX2XNK/DDce+V1xEfbqJoy6Dubi03RFSn0mzfo=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=n7ZYVuNOuswu2/3iSzshlWYHbZrdHTtf2mhskHIvmP3ctOT/XOI4jeGDjvvYfhcCyqIihV/ML/SX08ylAm42JwFQ7Rg0DIDpII9BFHAUBu9qDH2TKr2CvLODZfBfnnfmLurDEwwyiVv5FCSzna7GdewiaEeazZY2OX58hsf0LTs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jpdnsUF3; arc=fail smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jpdnsUF3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773394179; x=1804930179; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=I+yhEyX2XNK/DDce+V1xEfbqJoy6Dubi03RFSn0mzfo=; b=jpdnsUF3shUqKSKvdTZdP/DVv6QHW8QLKOpsRBPzv6HZxzMDg0IFO48C 51H5hIiAmZfJK4eDSj3iCaxpqgL74GF9EKxGiPpg8duysqZZF4tss/uf/ Qm78RXFr8tq6zRYWPwVCX0meno+mhHbe4wZ1/MEAB/pLGu1H9ZhCXQfC3 RXU7Zs6C8ZaBOGbwUcPvDamKuS5GKBHTqmv+OJIe6H5wm0OF02Pdr0CcB VQGqmyUR7UnO+ZG99FoaPGrOCbUR+FDYj89iw8gW20S9dJp9y755qagKw OmEwpwbGMoZJRoPbi9ILDBHoGRuJ6yd0F1bK6HZiofDaEZGtaJT800Ccu A==; X-CSE-ConnectionGUID: xmGYUrfTR5+wIiQlwKWBcQ== X-CSE-MsgGUID: Y7+WYPIiQEOaYSHoeDMrrw== X-IronPort-AV: E=McAfee;i="6800,10657,11727"; a="92074373" X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="92074373" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 02:29:38 -0700 X-CSE-ConnectionGUID: mYaI19+7SviSLE077SOy6g== X-CSE-MsgGUID: QYqBI0uISxyhNVtSlRKBlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="223480233" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 02:29:38 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 13 Mar 2026 02:29:37 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 13 Mar 2026 02:29:37 -0700 Received: from CH1PR05CU001.outbound.protection.outlook.com (52.101.193.65) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 13 Mar 2026 02:29:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g2zl+jFFEmPXXNqTqcgWF1tMnNn+iNAqvZplXDZfBSr1CUPHmy+UOc2iAaEiGTh347KgU2C8i3L4Xveo5DMKdF9OffJj326Lk9FcCbMCrbbwjukW+fa1awAEwuI4YJgZOgAGaLoCIxyGhN3OtApd75avfu9knyP6XTyEOt5GFCwyGOLMdUaaJiM60ATxHjmw7KZMMG8aAeam3ZocAkKZR2mf7NZtZTFtivBR1Bf5yobS/im/NON6ZunTqDY6UTpnK7PveHO7Q+ye0sCkmXxJ5joKs58cFegBkUmA1wlnnEyrtyAyWiJeorsNFKdbXAL7PT5Z6eZO3F1GcQ5w/RAzWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=awDTM8tzrqubVtSyTxWezmswJLPDX5W6ql76cQ40CL0=; b=NhN0JiVic5DuI16pYnaob+1hj9iNc7S8t7c8PLaLI1+H+EZCpznxaHOgEiaNeDXg8zCw9PCtzi1dd2U2HgvlIPuD6zucgnogARdGegfIn6083X30iORZxxJY3Mant9AK5msixDdFKWBO/3ltbKCZ+SvoFvsV6+xtpOVJmT/tTg8wI1QnnxTQgsbJ586LO9R+zcqZOy/M7uV0g7VGQshuQstvRROGqYKT6R6HRyw+nHgEUjcR8KD18S73euTWktIKQyDWar535xNXlb2SoDG60HTharggKAyxohfs1GnzKBsBSzRgUpqyYKHzVWyXD0mvTfDxO4mPqtx7YH3ftS9DHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) by SA2PR11MB5178.namprd11.prod.outlook.com (2603:10b6:806:fa::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.4; Fri, 13 Mar 2026 09:29:35 +0000 Received: from IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::61e9:afe6:c2c0:722]) by IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::61e9:afe6:c2c0:722%6]) with mapi id 15.20.9723.004; Fri, 13 Mar 2026 09:29:35 +0000 Date: Fri, 13 Mar 2026 10:29:29 +0100 From: Maciej Fijalkowski To: Alex Dvoretsky CC: , , , , , , Subject: Re: [PATCH net v3] igb: remove napi_synchronize() in igb_down() Message-ID: References: <20260312135257.71610-1-advoretsky@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260312135257.71610-1-advoretsky@gmail.com> X-ClientProxiedBy: VI1PR0102CA0003.eurprd01.prod.exchangelabs.com (2603:10a6:802::16) To IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB6097:EE_|SA2PR11MB5178:EE_ X-MS-Office365-Filtering-Correlation-Id: bf338161-b623-4a56-f360-08de80e30a46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: P6OnlOm1+Wva83yG4ZPzpfDDfHwvBTQqjcRbJexZuZXMOgRW9ZwVeeFcEJNiTn3x5IPLSH9wWvGxoFUKKgE+QTVCJB18ltZRn85Y6UEri9zPCro6JnCsRdk5cYgkXCQ7zFKvFIGo8L1iPiep8sRVNuusumbhs1ACL6SPgQqS68+4bHBVst4XAqoADMUFhJKOgg9MVMA1I8IXDiKNlXUl4JEaaP/b1fqI/+sJQiPS8Sg62nagHJx/IFCWGPECG6SFvN0WdDzUHMvAu0RfAQaA7kQ/p3KteS1tnpKGgOCiAoGnFUIwI8zhEm0V3Ci61yAKYs4mTwhBiPI2NBa8i+02S++96ie0xVyair/5cgSES6FSCEB+EcsGT80l0FGA34k/P8X16RZdp6a6BSSI2drjDzaXpVhFkwfHV0LTCCJFtZ/f7p8hwGMDkAiFhTipUngIsh65cTP8HSd2c2nvzqW4cgpr2dWh0WMSZFVfG1jWZArPH2lzlc+sfKGLyRHhUvV79ehny6avWvYcz3xsxyWIOOb+Yhm+B+lB49J6I7mGIOHLWDgpL/ap2taUQ+uvJg0nVdw6nJpzd+tfLcwWmOisnkmiPxwaG+n+PcnarILCCIEMQhpGMQRg5eVXPCKQCe+IztCgbvsDwahiAan/Pk3q+TaLOH1NJR0pcdeTHqY6XT/FdwAz+nKWtt6LZYVF4oKLEw5KX0DZiPKNjx5t1ugmucRlptscSCKvv8v9H19zUVI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6097.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(7053199007)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YndJQ2h3MUpIdFZNdUFJUm8rc2tPcUh0NDlDYWUxemROTGlrUVhuYXhpUWpH?= =?utf-8?B?bDVjelYzQmU1NGZ4QmtHb0pBbVNoOHdKU1l4V29hd25mTmo3T1dQZUU2OTZa?= =?utf-8?B?bXViNzFGRmJwa3B4dTRXemw4RXlvdkdnM09BZktkRlMxN3VWcDd1ZUU1SjNB?= =?utf-8?B?YU1oZVdINEZINkIwU0F4TEtYaEszMkNNb054T096RVl0UndpZlpXYlluVWtI?= =?utf-8?B?RDk0ZCtmcVArb1lTK0cwZ3NvbXNROHp6dzROaGd5M043eEl4VFY3MUs4cldH?= =?utf-8?B?WXdKR2l1dU8wZkJqMlV1dmFNTjFtM01naUl5MmdUa3ZIT3A4KzhNRjlzaXEx?= =?utf-8?B?Nm1YeGhNaHcyV3FSK1FVdHdKYmI5RGlHbGtMWWhLZjZHcVhsT0U2blo2a0NQ?= =?utf-8?B?T3oveE5ENFhEZThHUlplUGpTR1RDZzEybVJYdkV3S1FlSDVTajEyUCtReVFV?= =?utf-8?B?WVNHZmdOdjNJazZxVGhiaUV0OG5xci9qa3c4YjM5RHE1WWRHZGFFdFBzbHV0?= =?utf-8?B?MmNLZWo3anYvZ2JyUDhjMzluYVQrbDNzdUxqSEEvL3dlcGc2bGR1bmUzdWtx?= =?utf-8?B?UHBoLzdHT01rSDRwOU5PeXptZlhsSGtKWnFVc2l2NWNJdk9ZUmMrZ21QQkpM?= =?utf-8?B?U1YxaVlHV2d1WEZqcG0xM01leUx5ajVJdEtUb2c1cW9OKzlEVitlNmsxQ25y?= =?utf-8?B?TUQrNFB6endlaDFseStCU0dINDlHRjF0aXdZdW91VGt4RmYwNHpjeGUwempZ?= =?utf-8?B?MGRBM1UxNVRlVTRIM2tyWkF6Wm54blBHbWVreXNrZm5lbWdwbXVaeGdnaFlt?= =?utf-8?B?ZUF4NnEyVUF5MlE4d1pkTHA3WENSZ3hmZVhtOWh4RUVMS254Mlo4aU9lZzlz?= =?utf-8?B?ZjhvWkRDbW5RdEVuUFZWVzZSbytySDlIdU5hWXh2K3hYM3NNN0xtaXdwdWtG?= =?utf-8?B?anVzTUFqYU0yUlBqbXR1OEdBaGpjTHkxb2N6aEhhRDdQcFlOY0NDOEhyd0U3?= =?utf-8?B?S2g2OFZOaWlqVCtqQW9WYmFkSEZRdGZrRG4vc0QvVVFCNEY4RkRXMEFOUk1n?= =?utf-8?B?eXlPTG1KdmZOOVNnN3lMeG94VDRGS2t6WHJUbmpDVjZUVEhZazFNalZyclRJ?= =?utf-8?B?UEl4R20wNmg5U2tIUVZOWVYzd3dLdVJWRjVFNnJjZUxSQzhpVUtEcndyRVE0?= =?utf-8?B?WFdVekpsdlAwUWJFWHNhMzV3UGJyZ2tZS1ROaEtaTGQ2ZDAwSytxY0x5WWFm?= =?utf-8?B?bHZpMzhGYTdRL2pYdldsUmtYZm40STN0MHROQnBiN1dNQUFCOExJcWlhd1F6?= =?utf-8?B?cUh1OEo1S0VJMElBd2VJQk9qSk0rOVdmeTZvTVBpK01Ic0lPUjFMVkc1elRO?= =?utf-8?B?TDE1dFBiVHdDZHhQMHVtc1p3OTZDakxOb1NxbDExbkFIOWVJVWlIY2xkQSsv?= =?utf-8?B?MFRaM3V2R2ZWbmV4ZXRJWFc4RWhpaC91ajdFNHBta0tHVFpHVzZBUDZFNThP?= =?utf-8?B?L0RNTFREakU0NzBIL25TbnBHdFRtZCtEMHN1RXVmRmxka2NVdHNkSnlPcGhm?= =?utf-8?B?RFpjVEUyejJLNlVacFpSeUJjZVorSWt0bGFBK3ZGb3FqSVk4Rk1hSVZqYk1n?= =?utf-8?B?SW5KMnI5RTh1YXdrZTkxSXB0VDJCaG5qVXk2MWt1cjN5RkQzb3NNQjdNVEU0?= =?utf-8?B?aG5GYnl4dWIyd2RFc1UwYjRyTVU5Y0I0eTZqYndpVFQ0RVEwL1VWcUxaNXM0?= =?utf-8?B?L3h5aWxmNnhyQmxVRkhEUjNjUHRUNDZJejl0UUV4S0dCVXJncnE4dHlGUzda?= =?utf-8?B?TENyOVRndFVKSUVzNDdOdWpRMzdSZ004YW5WSW5kRWtkMUJvU1lyRmhua2N2?= =?utf-8?B?bDNTTVBXZ21vWGpDOVphbkROTCs2ZnVucW1jZXJpMnhpSkF0bUhtbHJHcm41?= =?utf-8?B?Q09FWkt5YjYvcCtUenROSEw5czB2K0Q5clNScFM0NGZLRTJ3anphUldpa0pv?= =?utf-8?B?M2ozSE1uWCtGVmFlaFB4ZlluMFpHUWNDNlFmcUt2cm5ROCtremlVTXlDNHd6?= =?utf-8?B?UVVCVURRTHF5Ty9Sd3VQSnVuOVBlQ3JDOXdrUXNpYkRyM3lVZ3JjcWRJbyti?= =?utf-8?B?OE43eXdqODV2Z1o5RVlKdkNndmxrVktiVkZacHprQVV2c1pYaHgvVHZRb1Qr?= =?utf-8?B?Z1dINHdnSDJqakN4QUdPVDRZZ1B5aFR5SW15aEovNGF0VjJBVnB5MTZzbFZ1?= =?utf-8?B?OE9mMVdYUkFPSTRTZEpsMVdEcmQwU3VVZVIrNTl0eVZIU3hyRC9oYVdqdm81?= =?utf-8?B?Zmo1SUk2WFNKT1c1NnJMSjV6eERieEFQZEt2aEFkekxMN3F0dlprcEVORGgz?= =?utf-8?Q?VPhWPqz6Yh8RPUGo=3D?= X-Exchange-RoutingPolicyChecked: Svk0wDa/myM+3oxVa+yLNo8nhs4BNAM0uZHFbirTpWDZqyJoYgxGWx+sssmLVFch+xLlPIj2D3Qx+bMAXgATFklVKmhyoiZ4rGGA9k43RlMA0AJwVuVxxCebr8I6lGR1Ne3gR/d3B4WeHR30U2H9pwsDrnLjHH8jYMkRQMODOYzd2gzpUZtY3z8HEv9CMPG/BAECfC7xh8Cmpr9y7bE6mVHhD7tclBptZMogWC8gDOj5lSatLkhAnh/t5uxmQs/UAn4PHbpZFJ6GvgYxgnwuc7nP+mYKO6HuCXNE05S640pjKBO2Ztl63J2R3spg7hbKr1QGROW1DO0ke3KgxvVNNw== X-MS-Exchange-CrossTenant-Network-Message-Id: bf338161-b623-4a56-f360-08de80e30a46 X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2026 09:29:35.2849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ToLodVoCRlbpbFnfkjxb/pLuxsJ7w4cwSxYaVi4Ywqe5LQn5IKmDDtp9nVZ3lSrZIW8nXPGHMEc4EQHJ11215PiZxkIGdGAgzMcscjzlEEA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5178 X-OriginatorOrg: intel.com On Thu, Mar 12, 2026 at 02:52:55PM +0100, Alex Dvoretsky wrote: > When an AF_XDP zero-copy application terminates abruptly (e.g., kill -9), > the XSK buffer pool is destroyed but NAPI polling continues. > igb_clean_rx_irq_zc() repeatedly returns the full budget, preventing > napi_complete_done() from clearing NAPI_STATE_SCHED. > > igb_down() calls napi_synchronize() before napi_disable() for each queue > vector. napi_synchronize() spins waiting for NAPI_STATE_SCHED to clear, > which never happens. igb_down() blocks indefinitely, the TX watchdog > fires, and the TX queue remains permanently stalled. > > napi_disable() already handles this correctly: it sets NAPI_STATE_DISABLE. > After a full-budget poll, __napi_poll() checks napi_disable_pending(). If > set, it forces completion and clears NAPI_STATE_SCHED, breaking the loop > that napi_synchronize() cannot. > > napi_synchronize() was added in commit 41f149a285da ("igb: Fix possible > panic caused by Rx traffic arrival while interface is down"). > napi_disable() provides stronger guarantees: it prevents further > scheduling and waits for any active poll to exit. > Other Intel drivers (ixgbe, ice, i40e) use napi_disable() without a > preceding napi_synchronize() in their down paths. > > Remove redundant napi_synchronize() call and reorder napi_disable() > before igb_set_queue_napi() so the queue-to-NAPI mapping is only > cleared after polling has fully stopped. > > Fixes: 2c6196013f84 ("igb: Add AF_XDP zero-copy Rx support") > Cc: stable@vger.kernel.org > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Alex Dvoretsky Suggested-by: Maciej Fijalkowski Reviewed-by: Maciej Fijalkowski > --- > Agreed, that looks cleaner — no reason to touch the NAPI plumbing while > the poll could still be running. > > v3: > - Reorder napi_disable() before igb_set_queue_napi() per Aleksandr > Loktionov's suggestion. > > v2: > - Replaced 3-patch series with single napi_synchronize() removal, > per Maciej Fijalkowski's suggestion. napi_disable() handles the > stuck NAPI poll via NAPI_STATE_DISABLE, making the __IGB_DOWN > checks in igb_clean_rx_irq_zc() and igb_tx_timeout(), and the > transition guards in igb_xdp_setup(), all unnecessary. > - Tested on Intel I210 (igb) with AF_XDP zero-copy: full E2E > traffic suite, graceful shutdown, and 5x kill-9 stress cycles. > Zero tx_timeout events. > > drivers/net/ethernet/intel/igb/igb_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index 7c41e32256fa..0793842cb937 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -2203,9 +2203,8 @@ void igb_down(struct igb_adapter *adapter) > > for (i = 0; i < adapter->num_q_vectors; i++) { > if (adapter->q_vector[i]) { > - napi_synchronize(&adapter->q_vector[i]->napi); > - igb_set_queue_napi(adapter, i, NULL); > napi_disable(&adapter->q_vector[i]->napi); > + igb_set_queue_napi(adapter, i, NULL); > } > } > > -- > 2.51.0 >