From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C2BC22A4F1; Fri, 13 Mar 2026 11:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773400112; cv=none; b=jFS7aVmz8VEhh3l0KDk2PxJHHsBkjO5B6T54giCRM2AeW3+EHgnmXZ8E5mj4n27no53mJ5Qu6R31qr7OsZNKBKZTr0XTAqoEZrN8yFLUDOp1GzR+dd5GKE6vClzOCxS5fWgMfVoXYvTnMnjdBn2HiFrNmszSTLA071+O7djVTT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773400112; c=relaxed/simple; bh=6W6MWfjsIP0eFjA9jzPaP7CtxT1x9oxbzBwhb1w9owQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ARNIlqSQA4kj8XGngTmIvn956Jymq2r4mq9hmBH9rA9AY2ViDfEQfRaaUjnbg1rlnSgn4dP1Xaj9vHsNCVeE+Kk0oXjNvAVQwNeuQj4mYhihLFtZdJygth+aCkuazxWOMSJ/ogGmB/n/5E+DigxvCRbGsVriUwWyRIs0z4FXhrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=tlJw/A1U; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="tlJw/A1U" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=04gqaMJ7nWJ/la8QtGxvljhh8gpBd2Y7ie/l7eGhAn4=; b=tlJw/A1UbK0Q9vbFr93ejntT8I Nx2iJiwkgP75sChivKom8AZW7s/EOxvo/Ru3oDOMoC69QkTIzdqfG1XBfEkGwV4Q5o7EcXv1a117s R+1GRBsMit93xU/oBixJPaXPcmjmf8Q5R1UwEHvJN8hX1QcWhFMEp3+9CD0tgSS9DHHmCtWyTjflZ myvFkHzbjmwpr67coCFDb2rlXm0aTx13cfyLaumHRkiNpG2ZvCtrSio0v0fHkPHH/WJ98ZTHygxIv /pVJpimEzyjiqdOo1EOcgj52QvpqQ5ovJNa1nHHdp+0e798YiZEJ2Pjzs0n9AazKO/XUdL4QNT2Ny pKctI1AA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53580) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w10NP-000000000o3-05kB; Fri, 13 Mar 2026 11:08:19 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w10NK-0000000089x-2nw7; Fri, 13 Mar 2026 11:08:14 +0000 Date: Fri, 13 Mar 2026 11:08:14 +0000 From: "Russell King (Oracle)" To: Christophe Roullier Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , linusw@kernel.org, antonio.borneo@foss.st.com, Maxime Chevallier , Vladimir Oltean , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] net: stmmac: fix pinctrl management during suspend/resume Message-ID: References: <20260313105718.359614-1-christophe.roullier@foss.st.com> <20260313105718.359614-2-christophe.roullier@foss.st.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260313105718.359614-2-christophe.roullier@foss.st.com> Sender: Russell King (Oracle) On Fri, Mar 13, 2026 at 11:57:16AM +0100, Christophe Roullier wrote: > In the deepest low-power modes, the pinctrl configuration is lost > and is never restored if the interface is down. > This commit ensures that the pinctrl state is set in all cases. Shouldn't the pin state be restored by the pinctrl layer? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!