[PATCH v2 net-next] xsk: remove repeated defines

[PATCH v2 net-next] xsk: remove repeated defines

[Maciej Fijalkowski]

Seems we have been carrying around repeated defines for unaligned mode
logic. Remove redundant ones.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
v2: remove another repeated define (Stan, Paolo)
---
 include/net/xsk_buff_pool.h | 7 -------
 net/xdp/xsk.h               | 7 -------
 2 files changed, 14 deletions(-)

diff --git a/include/net/xsk_buff_pool.h b/include/net/xsk_buff_pool.h
index 0b1abdb99c9e..ccb3b350001f 100644
--- a/include/net/xsk_buff_pool.h
+++ b/include/net/xsk_buff_pool.h
@@ -174,13 +174,6 @@ static inline void xp_dma_sync_for_device(struct xsk_buff_pool *pool,
 	dma_sync_single_for_device(pool->dev, dma, size, DMA_BIDIRECTIONAL);
 }
 
-/* Masks for xdp_umem_page flags.
- * The low 12-bits of the addr will be 0 since this is the page address, so we
- * can use them for flags.
- */
-#define XSK_NEXT_PG_CONTIG_SHIFT 0
-#define XSK_NEXT_PG_CONTIG_MASK BIT_ULL(XSK_NEXT_PG_CONTIG_SHIFT)
-
 static inline bool xp_desc_crosses_non_contig_pg(struct xsk_buff_pool *pool,
 						 u64 addr, u32 len)
 {
diff --git a/net/xdp/xsk.h b/net/xdp/xsk.h
index a4bc4749faac..7c811b5cce76 100644
--- a/net/xdp/xsk.h
+++ b/net/xdp/xsk.h
@@ -4,13 +4,6 @@
 #ifndef XSK_H_
 #define XSK_H_
 
-/* Masks for xdp_umem_page flags.
- * The low 12-bits of the addr will be 0 since this is the page address, so we
- * can use them for flags.
- */
-#define XSK_NEXT_PG_CONTIG_SHIFT 0
-#define XSK_NEXT_PG_CONTIG_MASK BIT_ULL(XSK_NEXT_PG_CONTIG_SHIFT)
-
 struct xdp_ring_offset_v1 {
 	__u64 producer;
 	__u64 consumer;
-- 
2.43.0

Re: [PATCH v2 net-next] xsk: remove repeated defines

[Stanislav Fomichev]

On 03/13, Maciej Fijalkowski wrote:
> Seems we have been carrying around repeated defines for unaligned mode
> logic. Remove redundant ones.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> v2: remove another repeated define (Stan, Paolo)

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

Re: [PATCH v2 net-next] xsk: remove repeated defines

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 13 Mar 2026 12:19:31 +0100 you wrote:
> Seems we have been carrying around repeated defines for unaligned mode
> logic. Remove redundant ones.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> v2: remove another repeated define (Stan, Paolo)
> 
> [...]

Here is the summary with links:
  - [v2,net-next] xsk: remove repeated defines
    https://git.kernel.org/netdev/net-next/c/cc6421acd97f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html