From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 414E93DEFE0; Fri, 13 Mar 2026 18:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427347; cv=none; b=X6ZtADEy2NR8P4/uiiW0cwS33uXuCEnMzelzHWb6UIlOqae55JfrvlClPl8+gGFFrZ66MwSAnLBThiGt2xb7Xm2arAiIQDh3YfoP7UQWcQGky9bxB8UsEiQHLmyD+1Ser3mwIaGXpFvvPgbvk7q1c0C6pOrakqtxhxMFFK5F3gU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773427347; c=relaxed/simple; bh=1hBR7tyfafcC4/nQN+G4eGQznYpRC+Kh+gvdChubNv8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FK8snrxW2FIdK/V4N5l/Zx63HTIuFYcmQ4SuRymulQy9TFZSKVh6V4AAoAY+9Z9csjPqy5FlRCwlm4PLJCIin8X4sGfhdUNwmOSUgi8+Ob/0isjCELB/etxPl4wPnWBnmpOt8YdRGV2xDnIcVUBeLOTcNaAJGWSBxu5FqxQa29I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=k0QvlEX9; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="k0QvlEX9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6tdpzCjfd9Ry9f1CUsXXFtWyu0Swm3ZLAk7lZVu01fo=; b=k0QvlEX9IYsfeTo+hPcc2ovRdk E3ERkxj1kciouvsK0NuqjZC2XrplYyqUqMJakrTRYFPPB5s21rLvjoN5A+I+hhrLvk+iCJo6QdfWp tPAiSpAdnyzYKnClPN/vQzFaswO01+mHVby6ji+Tww2Rx2lbhVQlNTXAPKV7IqRNhkHk7YtUHJsec w2gwBldUXZYtBFnXXzqfSwL4UlI7iuFDKdNbGKOm4Qq9roL++w/Sn8TodY+0H0q9kbi1gQePDeUhN jNEKg4FpGInqMpWjyH4sP4cD39rBbcY9I3d3BSaidaM+dSDXhitpMEb9XQnngRAKTuIwHCELdlSFz 29NWMItA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54202) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w17Sk-000000001PR-2lDL; Fri, 13 Mar 2026 18:42:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w17Si-000000008RT-2T8o; Fri, 13 Mar 2026 18:42:16 +0000 Date: Fri, 13 Mar 2026 18:42:16 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next 8/8] net: stmmac: report PCS configuration changes Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Fri, Mar 13, 2026 at 12:29:31PM +0000, Russell King (Oracle) wrote: > +#define REPORT_BIT(x) \ > + if (diff & GMAC_AN_CTRL_##x) \ > + pr_warn("dwmac: %8s %u -> %u\n", #x, \ > + !!(old & GMAC_AN_CTRL_##x), \ > + !!(value & GMAC_AN_CTRL_##x)) > + REPORT_BIT(ANE); > + REPORT_BIT(SGMRAL); > +#undef REPORT_BIT I see checkpatch wants the if() inside the macro to be wrapped in a do-while loop, which is overkill for this - this is not a macro that is used throughout the kernel, it's only used in the next two lines where we can plainly see that this is safe. There is no need to make this unnecessarily more complex - and thus less readable. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!