Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Steffen Bätz - Innosonix GmbH" <steffen@innosonix.de>
Cc: Fabio Estevam <festevam@gmail.com>,
	olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org,
	netdev@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [RFC] net: dsa: mv88e6xxx disable IGMP snooping on cpu port
Date: Mon, 27 Mar 2023 17:26:10 +0200	[thread overview]
Message-ID: <aba08f9a-899c-4608-b441-27789bcd7ebd@lunn.ch> (raw)
In-Reply-To: <CAK5sFAXDY0RP5NEwHoUBTam73cjU8yEMaZYO1d5yEBLD_TEoEA@mail.gmail.com>

On Mon, Mar 27, 2023 at 04:51:20PM +0200, Steffen Bätz - Innosonix GmbH wrote:
> Hi Andrew,
> Yes, strangely, this piece of code has stayed the same for years.
> But we only face this behaviour if you add a bridge interface on top of the DSA
> ports.
> The setup looks like: eth0 (physical port of the imx8mn) <-> lan3/lan4 (DSA
> ports of the mv88e6320)
> 
> ip link add br0 type bridge
> ip link set br0 up
> ip link set lan3 master br0
> ip link set lan4 master br0
> ip link set lan3 up
> ip link set lan4 up
> dhcpcd -b br0
> 
> If now you try to receive an audio multicast stream, like from 239.255.84.1,
> the neighbour bridge will not forward this stream to our board. And there is no
> entry in the MDB of the external switch.

Ah, O.K. That is not actually IGMP snooping. It is normal usage of
IGMP. I probably did not test that. I think all my multicast source
and sinks where on switch ports, and i tested that the switch did not
flood multicast to all ports, just ports with listeners.

So your change looks O.K, but as i said, it probably should apply to
DSA ports as well as CPU ports. And i suggest you reword the commit
message to differentiate between IGMP snooping and an IGMP listener on
the bridge.

    Andrew

      parent reply	other threads:[~2023-03-27 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 13:48 [RFC] net: dsa: mv88e6xxx disable IGMP snooping on cpu port Fabio Estevam
2023-03-27 13:55 ` Andrew Lunn
     [not found]   ` <CAK5sFAXDY0RP5NEwHoUBTam73cjU8yEMaZYO1d5yEBLD_TEoEA@mail.gmail.com>
2023-03-27 15:26     ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aba08f9a-899c-4608-b441-27789bcd7ebd@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=steffen@innosonix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox