From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:36826 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933415AbeCGWbx (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 7 Mar 2018 17:31:53 -0500
Subject: Re: [RFC v3 iproute2 3/3] tc: Add support for the TBS Qdisc
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
        jiri@resnulli.us, Vinicius Costa Gomes <vinicius.gomes@intel.com>
References: <20180307011608.24186-1-jesus.sanchez-palencia@intel.com>
 <20180307011608.24186-3-jesus.sanchez-palencia@intel.com>
 <20180306175149.223614ab@xeon-e3>
From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
Message-ID: <aba3eda3-ca71-8bd7-fd59-00b99f12124c@intel.com>
Date: Wed, 7 Mar 2018 14:29:23 -0800
MIME-Version: 1.0
In-Reply-To: <20180306175149.223614ab@xeon-e3>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi,


On 03/06/2018 05:51 PM, Stephen Hemminger wrote:
> On Tue,  6 Mar 2018 17:16:08 -0800
> Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> wrote:
> 
>> atic int tbs_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
>> +{
>> +	struct rtattr *tb[TCA_TBS_MAX+1];
>> +	struct tc_tbs_qopt *qopt;
>> +
>> +	if (opt == NULL)
>> +		return 0;
>> +
>> +	parse_rtattr_nested(tb, TCA_TBS_MAX, opt);
>> +
>> +	if (tb[TCA_TBS_PARMS] == NULL)
>> +		return -1;
>> +
>> +	qopt = RTA_DATA(tb[TCA_TBS_PARMS]);
>> +	if (RTA_PAYLOAD(tb[TCA_TBS_PARMS])  < sizeof(*qopt))
>> +		return -1;
>> +
>> +	fprintf(f, "clockid ");
>> +	if (qopt->clockid == CLOCKID_INVALID)
>> +		fprintf(f, "invalid ");
>> +	else
>> +		fprintf(f, "%d ", qopt->clockid);
>> +
>> +	fprintf(f, "delta %d ", qopt->delta);
>> +	fprintf(f, "offload %s ", (qopt->flags & TC_TBS_OFFLOAD_ON) ?
>> +					"on" : "off");
>> +	fprintf(f, "sorting %s", (qopt->flags & TC_TBS_SORTING_ON) ?
>> +					"on" : "off");
>> +
>> +	return 0;
>> +}
> 
> All new print code in iproute2 should support JSON output.
> Look at other code using json_print.h for simple way to handle this.
> 


Fixed, thanks. I'm assuming that only applies to print code from print_qopt()
implementations. Please let me know if otherwise.