From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F40840DFBA for ; Sun, 15 Mar 2026 14:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.212.198.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773583798; cv=none; b=l9c65OnFg7sNwnyvxaSM1zqaieEjU3FwSQNO9hDniOzuhJcegc9qO6qTcZLitiR9EgGZaPw3//dswCALXjY86dxV7kKiOPAMlLNjchuAXkVsJBY886UIzX4t7JEFGYyVJhk+EcmeHmHCd3lbAqOsn5bIKo10BUq+xoHjmAdt4Gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773583798; c=relaxed/simple; bh=uiVd/+fGXelR1p5pfl5rk+Zt1I69vhzR86HcazMH88M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d77ZGZ6WTxHNVusSh42zGGFGjajTxL0R1LhmghDQA4VfwqnTfABtTOqm2GK6mJdyz9H2OrdZolbcV/PJx1WM7MmPFCTXhixrcHB5eX9Vn69JfnwkyIO5wN4uixDYZmy/Kf1uSRtVLzso461Jr7O6l2TXjpvBaZ+sDtiqZxvD2M0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp; spf=pass smtp.mailfrom=enjuk.jp; dkim=pass (2048-bit key) header.d=enjuk.jp header.i=@enjuk.jp header.b=YXZpGz/X; arc=none smtp.client-ip=49.212.198.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enjuk.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enjuk.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=enjuk.jp header.i=@enjuk.jp header.b="YXZpGz/X" Received: from x1 (168.25.31.150.dy.iij4u.or.jp [150.31.25.168]) (authenticated bits=0) by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 62FE9mRs025689 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Mar 2026 23:09:50 +0900 (JST) (envelope-from kohei@enjuk.jp) DKIM-Signature: a=rsa-sha256; bh=RcLrErX1O4pkT2Qd0Kt1wtzixyuWXIGtCs14H59Vd08=; c=relaxed/relaxed; d=enjuk.jp; h=From:Message-ID:To:Subject:Date; s=rs20251215; t=1773583790; v=1; b=YXZpGz/XTHPMvGFL9MKXfc/wBYEcHYF9aPl9MKrn6PgZcv1VNLWwwjptSe9SNY9o e3sCICn5ZJqWeYnejX0Lm7IFi0bGoPThpSLVLmYQ0D6J9FEO88rBr7/ecwwKbYoH kADFsD6cMIHee9Frk7LXOv5cRwCxe9scKpAbgoUIhYhkf6fXppz/KcNz80ipF0Wx bIWYGCXE6DasmIRJCvLmQVwlLSM/b9C9TcOE9789BcaUrJhLN3Nan9zrmB5AmojY f9fq038F4iNf09EZfaFxOOM/eWkfDMGwjq38I0y+L02WelZ7MMsiclJHlZgFMmqC w2Z47VWjlSLstnvbulfkVQ== Date: Sun, 15 Mar 2026 23:09:48 +0900 From: Kohei Enju To: "Ruinskiy, Dima" Cc: "Loktionov, Aleksandr" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "kohei.enju@gmail.com" Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 1/2] igc: set RX hardware timestamps in igc_build_skb() Message-ID: References: <20260307182808.155027-1-kohei@enjuk.jp> <20260307182808.155027-2-kohei@enjuk.jp> <25df2a93-07c8-477e-9717-fb4a815cff2c@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <25df2a93-07c8-477e-9717-fb4a815cff2c@intel.com> On 03/15 15:56, Ruinskiy, Dima wrote: [...] > > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c > > > b/drivers/net/ethernet/intel/igc/igc_main.c > > > index ebd831a4ff53..3a4c1ebe4faa 100644 > > > --- a/drivers/net/ethernet/intel/igc/igc_main.c > > > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > > > @@ -1964,13 +1964,16 @@ static void igc_add_rx_frag(struct igc_ring > > > *rx_ring, > > > > > > static struct sk_buff *igc_build_skb(struct igc_ring *rx_ring, > > > struct igc_rx_buffer *rx_buffer, > > > - struct xdp_buff *xdp) > > > + struct igc_xdp_buff *ctx) > > > { > > > - unsigned int size = xdp->data_end - xdp->data; > > > - unsigned int truesize = igc_get_rx_frame_truesize(rx_ring, > > > size); > > > - unsigned int metasize = xdp->data - xdp->data_meta; > > > + unsigned int size, truesize, metasize; > > > + struct xdp_buff *xdp = &ctx->xdp; > > > struct sk_buff *skb; > > > > > > + size = xdp->data_end - xdp->data; > > > + truesize = igc_get_rx_frame_truesize(rx_ring, size); > > > + metasize = xdp->data - xdp->data_meta; > > > + > In the spirit of consistency, would it be possible to restructure the > variable initialization to match that of igc_construct_skb()? Initialize xdp > first, and then all the size variable inits can stay as they are. It would > make the net change smaller. I followed the reverse christmas tree convention used in netdev, but your suggestion make sense as well. I'll make that change in v2.