From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EBA7C282D8 for ; Fri, 1 Feb 2019 21:33:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6502520869 for ; Fri, 1 Feb 2019 21:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbfBAVd3 (ORCPT ); Fri, 1 Feb 2019 16:33:29 -0500 Received: from www62.your-server.de ([213.133.104.62]:39860 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfBAVd3 (ORCPT ); Fri, 1 Feb 2019 16:33:29 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gpgR9-0008St-OY; Fri, 01 Feb 2019 22:33:23 +0100 Received: from [178.197.249.18] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gpgR9-000MxY-H1; Fri, 01 Feb 2019 22:33:23 +0100 Subject: Re: Co-existing XDP generic and native mode? (Re: [PATCH bpf-next v5 5/8] xdp: Provide extack messages when prog attachment failed) To: Jakub Kicinski , Jesper Dangaard Brouer Cc: ast@kernel.org, David Miller , Maciej Fijalkowski , netdev@vger.kernel.org, john.fastabend@gmail.com, David Ahern , Saeed Mahameed References: <20190201001954.4130-1-maciej.fijalkowski@intel.com> <20190201001954.4130-6-maciej.fijalkowski@intel.com> <20190131191101.2e9dc9f6@cakuba.hsd1.ca.comcast.net> <20190201080236.446d84d4@redhat.com> <20190201104738.7a3b33d6@cakuba.hsd1.ca.comcast.net> From: Daniel Borkmann Message-ID: Date: Fri, 1 Feb 2019 22:33:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190201104738.7a3b33d6@cakuba.hsd1.ca.comcast.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25347/Fri Feb 1 12:05:35 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/01/2019 07:47 PM, Jakub Kicinski wrote: [...] >> These are only refactor ideas, so if you can argue why your internal >> feature request for simultaneous generic and native make more sense, >> then I'm open for allowing this ? > > The request was actually to enable xdpoffload and xdpgeneric at the > same time. I'm happy to have that as another HW offload exclusive > for now :) The latter is probably fine, though what's the concrete use case? :) Reason we kept native vs generic separate is mainly so that native XDP drivers are discouraged to punt missing features to generic hook instead of properly implementing them in native mode. Thanks, Daniel