[PATCH v2 0/2] Fix typos in comments in Intel Ethernet drivers (igb, igc)

[PATCH v2 0/2] Fix typos in comments in Intel Ethernet drivers (igb, igc)

[Maximilian Pezzullo via B4 Relay]

This is v2, adding a typo fix noticed by Joe Damato in e1000_defines.h
("Device Reset Aserted" -> "Device Reset Asserted").

Changes in v2:
- igb: also fix 'Aserted' -> 'Asserted' in e1000_defines.h (suggested by Joe Damato)

Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
---
Maximilian Pezzullo (2):
      igb: fix typos in comments
      igc: fix typos in comments

 drivers/net/ethernet/intel/igb/e1000_defines.h | 2 +-
 drivers/net/ethernet/intel/igb/e1000_mac.c     | 2 +-
 drivers/net/ethernet/intel/igb/e1000_mbx.h     | 2 +-
 drivers/net/ethernet/intel/igb/e1000_nvm.c     | 2 +-
 drivers/net/ethernet/intel/igc/igc_diag.c      | 2 +-
 drivers/net/ethernet/intel/igc/igc_main.c      | 4 ++--
 6 files changed, 7 insertions(+), 7 deletions(-)
---
base-commit: af4e9ef3d78420feb8fe58cd9a1ab80c501b3c08
change-id: 20260304-fix-typos-in-comments-in-intel-ethernet-drivers-igb-igc-3b497b0df47d

Best regards,
-- 
Maximilian Pezzullo <maximilianpezzullo@gmail.com>

[PATCH v2 1/2] igb: fix typos in comments

[Maximilian Pezzullo via B4 Relay]

From: Maximilian Pezzullo <maximilianpezzullo@gmail.com>

Fix spelling errors in code comments:
 - e1000_nvm.c: 'likley' -> 'likely'
 - e1000_mac.c: 'auto-negotitation' -> 'auto-negotiation'
 - e1000_mbx.h: 'exra' -> 'extra'
 - e1000_defines.h: 'Aserted' -> 'Asserted'

Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
---
 drivers/net/ethernet/intel/igb/e1000_defines.h | 2 +-
 drivers/net/ethernet/intel/igb/e1000_mac.c     | 2 +-
 drivers/net/ethernet/intel/igb/e1000_mbx.h     | 2 +-
 drivers/net/ethernet/intel/igb/e1000_nvm.c     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/e1000_defines.h b/drivers/net/ethernet/intel/igb/e1000_defines.h
index fa028928482f..7e6f9aa2d57b 100644
--- a/drivers/net/ethernet/intel/igb/e1000_defines.h
+++ b/drivers/net/ethernet/intel/igb/e1000_defines.h
@@ -442,7 +442,7 @@
 /* Interrupt Cause Set */
 #define E1000_ICS_LSC       E1000_ICR_LSC       /* Link Status Change */
 #define E1000_ICS_RXDMT0    E1000_ICR_RXDMT0    /* rx desc min. threshold */
-#define E1000_ICS_DRSTA     E1000_ICR_DRSTA     /* Device Reset Aserted */
+#define E1000_ICS_DRSTA     E1000_ICR_DRSTA     /* Device Reset Asserted */
 
 /* Extended Interrupt Cause Set */
 /* E1000_EITR_CNT_IGNR is only for 82576 and newer */
diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c
index fa3dfafd2bb1..2bcce6eef0c7 100644
--- a/drivers/net/ethernet/intel/igb/e1000_mac.c
+++ b/drivers/net/ethernet/intel/igb/e1000_mac.c
@@ -1581,7 +1581,7 @@ s32 igb_disable_pcie_master(struct e1000_hw *hw)
  *  igb_validate_mdi_setting - Verify MDI/MDIx settings
  *  @hw: pointer to the HW structure
  *
- *  Verify that when not using auto-negotitation that MDI/MDIx is correctly
+ *  Verify that when not using auto-negotiation that MDI/MDIx is correctly
  *  set, which is forced to MDI mode only.
  **/
 s32 igb_validate_mdi_setting(struct e1000_hw *hw)
diff --git a/drivers/net/ethernet/intel/igb/e1000_mbx.h b/drivers/net/ethernet/intel/igb/e1000_mbx.h
index 178e60ec71d4..9e44527f5eea 100644
--- a/drivers/net/ethernet/intel/igb/e1000_mbx.h
+++ b/drivers/net/ethernet/intel/igb/e1000_mbx.h
@@ -30,7 +30,7 @@
 /* Indicates that VF is still clear to send requests */
 #define E1000_VT_MSGTYPE_CTS	0x20000000
 #define E1000_VT_MSGINFO_SHIFT	16
-/* bits 23:16 are used for exra info for certain messages */
+/* bits 23:16 are used for extra info for certain messages */
 #define E1000_VT_MSGINFO_MASK	(0xFF << E1000_VT_MSGINFO_SHIFT)
 
 #define E1000_VF_RESET		0x01 /* VF requests reset */
diff --git a/drivers/net/ethernet/intel/igb/e1000_nvm.c b/drivers/net/ethernet/intel/igb/e1000_nvm.c
index c8638502c2be..cf4e5d0e9417 100644
--- a/drivers/net/ethernet/intel/igb/e1000_nvm.c
+++ b/drivers/net/ethernet/intel/igb/e1000_nvm.c
@@ -405,7 +405,7 @@ s32 igb_read_nvm_eerd(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)
  *  Writes data to EEPROM at offset using SPI interface.
  *
  *  If e1000_update_nvm_checksum is not called after this function , the
- *  EEPROM will most likley contain an invalid checksum.
+ *  EEPROM will most likely contain an invalid checksum.
  **/
 s32 igb_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)
 {

-- 
Git-155)

[PATCH v2 2/2] igc: fix typos in comments

[Maximilian Pezzullo via B4 Relay]

From: Maximilian Pezzullo <maximilianpezzullo@gmail.com>

Fix spelling errors in code comments:
 - igc_diag.c: 'autonegotioation' -> 'autonegotiation'
 - igc_main.c: 'revisons' -> 'revisions' (two occurrences)

Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
---
 drivers/net/ethernet/intel/igc/igc_diag.c | 2 +-
 drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c b/drivers/net/ethernet/intel/igc/igc_diag.c
index a43d7244ee70..031561fdce49 100644
--- a/drivers/net/ethernet/intel/igc/igc_diag.c
+++ b/drivers/net/ethernet/intel/igc/igc_diag.c
@@ -172,7 +172,7 @@ bool igc_link_test(struct igc_adapter *adapter, u64 *data)
 
 	*data = 0;
 
-	/* add delay to give enough time for autonegotioation to finish */
+	/* add delay to give enough time for autonegotiation to finish */
 	ssleep(5);
 
 	link_up = igc_has_link(adapter);
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 27e5c2109138..de3f3d95de19 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -1793,7 +1793,7 @@ static const enum pkt_hash_types igc_rss_type_table[IGC_RSS_TYPE_MAX_TABLE] = {
 	[IGC_RSS_TYPE_HASH_UDP_IPV6_EX] = PKT_HASH_TYPE_L4,
 	[10] = PKT_HASH_TYPE_NONE, /* RSS Type above 9 "Reserved" by HW  */
 	[11] = PKT_HASH_TYPE_NONE, /* keep array sized for SW bit-mask   */
-	[12] = PKT_HASH_TYPE_NONE, /* to handle future HW revisons       */
+	[12] = PKT_HASH_TYPE_NONE, /* to handle future HW revisions       */
 	[13] = PKT_HASH_TYPE_NONE,
 	[14] = PKT_HASH_TYPE_NONE,
 	[15] = PKT_HASH_TYPE_NONE,
@@ -7021,7 +7021,7 @@ static enum xdp_rss_hash_type igc_xdp_rss_type[IGC_RSS_TYPE_MAX_TABLE] = {
 	[IGC_RSS_TYPE_HASH_UDP_IPV6_EX] = XDP_RSS_TYPE_L4_IPV6_UDP_EX,
 	[10] = XDP_RSS_TYPE_NONE, /* RSS Type above 9 "Reserved" by HW  */
 	[11] = XDP_RSS_TYPE_NONE, /* keep array sized for SW bit-mask   */
-	[12] = XDP_RSS_TYPE_NONE, /* to handle future HW revisons       */
+	[12] = XDP_RSS_TYPE_NONE, /* to handle future HW revisions       */
 	[13] = XDP_RSS_TYPE_NONE,
 	[14] = XDP_RSS_TYPE_NONE,
 	[15] = XDP_RSS_TYPE_NONE,

-- 
Git-155)

RE: [Intel-wired-lan] [PATCH v2 1/2] igb: fix typos in comments

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Maximilian Pezzullo via B4 Relay
> Sent: Wednesday, March 4, 2026 8:21 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Joe Damato <joe@dama.to>; Maximilian Pezzullo
> <maximilianpezzullo@gmail.com>
> Subject: [Intel-wired-lan] [PATCH v2 1/2] igb: fix typos in comments
> 
> From: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> 
> Fix spelling errors in code comments:
>  - e1000_nvm.c: 'likley' -> 'likely'
>  - e1000_mac.c: 'auto-negotitation' -> 'auto-negotiation'
>  - e1000_mbx.h: 'exra' -> 'extra'
>  - e1000_defines.h: 'Aserted' -> 'Asserted'
> 
> Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> ---
>  drivers/net/ethernet/intel/igb/e1000_defines.h | 2 +-
>  drivers/net/ethernet/intel/igb/e1000_mac.c     | 2 +-
>  drivers/net/ethernet/intel/igb/e1000_mbx.h     | 2 +-
>  drivers/net/ethernet/intel/igb/e1000_nvm.c     | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/e1000_defines.h
> b/drivers/net/ethernet/intel/igb/e1000_defines.h
> index fa028928482f..7e6f9aa2d57b 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_defines.h
> +++ b/drivers/net/ethernet/intel/igb/e1000_defines.h
> @@ -442,7 +442,7 @@
>  /* Interrupt Cause Set */
>  #define E1000_ICS_LSC       E1000_ICR_LSC       /* Link Status Change
> */
>  #define E1000_ICS_RXDMT0    E1000_ICR_RXDMT0    /* rx desc min.
> threshold */
> -#define E1000_ICS_DRSTA     E1000_ICR_DRSTA     /* Device Reset
> Aserted */
> +#define E1000_ICS_DRSTA     E1000_ICR_DRSTA     /* Device Reset
> Asserted */
> 
>  /* Extended Interrupt Cause Set */
>  /* E1000_EITR_CNT_IGNR is only for 82576 and newer */ diff --git
> a/drivers/net/ethernet/intel/igb/e1000_mac.c
> b/drivers/net/ethernet/intel/igb/e1000_mac.c
> index fa3dfafd2bb1..2bcce6eef0c7 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_mac.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_mac.c
> @@ -1581,7 +1581,7 @@ s32 igb_disable_pcie_master(struct e1000_hw *hw)
>   *  igb_validate_mdi_setting - Verify MDI/MDIx settings
>   *  @hw: pointer to the HW structure
>   *
> - *  Verify that when not using auto-negotitation that MDI/MDIx is
> correctly
> + *  Verify that when not using auto-negotiation that MDI/MDIx is
> + correctly
>   *  set, which is forced to MDI mode only.
>   **/
>  s32 igb_validate_mdi_setting(struct e1000_hw *hw) diff --git
> a/drivers/net/ethernet/intel/igb/e1000_mbx.h
> b/drivers/net/ethernet/intel/igb/e1000_mbx.h
> index 178e60ec71d4..9e44527f5eea 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_mbx.h
> +++ b/drivers/net/ethernet/intel/igb/e1000_mbx.h
> @@ -30,7 +30,7 @@
>  /* Indicates that VF is still clear to send requests */
>  #define E1000_VT_MSGTYPE_CTS	0x20000000
>  #define E1000_VT_MSGINFO_SHIFT	16
> -/* bits 23:16 are used for exra info for certain messages */
> +/* bits 23:16 are used for extra info for certain messages */
>  #define E1000_VT_MSGINFO_MASK	(0xFF << E1000_VT_MSGINFO_SHIFT)
> 
>  #define E1000_VF_RESET		0x01 /* VF requests reset */
> diff --git a/drivers/net/ethernet/intel/igb/e1000_nvm.c
> b/drivers/net/ethernet/intel/igb/e1000_nvm.c
> index c8638502c2be..cf4e5d0e9417 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_nvm.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_nvm.c
> @@ -405,7 +405,7 @@ s32 igb_read_nvm_eerd(struct e1000_hw *hw, u16
> offset, u16 words, u16 *data)
>   *  Writes data to EEPROM at offset using SPI interface.
>   *
>   *  If e1000_update_nvm_checksum is not called after this function ,
> the
> - *  EEPROM will most likley contain an invalid checksum.
> + *  EEPROM will most likely contain an invalid checksum.
>   **/
>  s32 igb_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16
> *data)  {
> 
> --
> Git-155)
> 


Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

RE: [Intel-wired-lan] [PATCH v2 2/2] igc: fix typos in comments

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Maximilian Pezzullo via B4 Relay
> Sent: Wednesday, March 4, 2026 8:21 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Joe Damato <joe@dama.to>; Maximilian Pezzullo
> <maximilianpezzullo@gmail.com>
> Subject: [Intel-wired-lan] [PATCH v2 2/2] igc: fix typos in comments
> 
> From: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> 
> Fix spelling errors in code comments:
>  - igc_diag.c: 'autonegotioation' -> 'autonegotiation'
>  - igc_main.c: 'revisons' -> 'revisions' (two occurrences)
> 
> Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> ---
>  drivers/net/ethernet/intel/igc/igc_diag.c | 2 +-
> drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c
> b/drivers/net/ethernet/intel/igc/igc_diag.c
> index a43d7244ee70..031561fdce49 100644
> --- a/drivers/net/ethernet/intel/igc/igc_diag.c
> +++ b/drivers/net/ethernet/intel/igc/igc_diag.c
> @@ -172,7 +172,7 @@ bool igc_link_test(struct igc_adapter *adapter,
> u64 *data)
> 
>  	*data = 0;
> 
> -	/* add delay to give enough time for autonegotioation to finish
> */
> +	/* add delay to give enough time for autonegotiation to finish
> */
>  	ssleep(5);
> 
>  	link_up = igc_has_link(adapter);
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
> b/drivers/net/ethernet/intel/igc/igc_main.c
> index 27e5c2109138..de3f3d95de19 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -1793,7 +1793,7 @@ static const enum pkt_hash_types
> igc_rss_type_table[IGC_RSS_TYPE_MAX_TABLE] = {
>  	[IGC_RSS_TYPE_HASH_UDP_IPV6_EX] = PKT_HASH_TYPE_L4,
>  	[10] = PKT_HASH_TYPE_NONE, /* RSS Type above 9 "Reserved" by HW
> */
>  	[11] = PKT_HASH_TYPE_NONE, /* keep array sized for SW bit-mask
> */
> -	[12] = PKT_HASH_TYPE_NONE, /* to handle future HW revisons
> */
> +	[12] = PKT_HASH_TYPE_NONE, /* to handle future HW revisions
> */
>  	[13] = PKT_HASH_TYPE_NONE,
>  	[14] = PKT_HASH_TYPE_NONE,
>  	[15] = PKT_HASH_TYPE_NONE,
> @@ -7021,7 +7021,7 @@ static enum xdp_rss_hash_type
> igc_xdp_rss_type[IGC_RSS_TYPE_MAX_TABLE] = {
>  	[IGC_RSS_TYPE_HASH_UDP_IPV6_EX] = XDP_RSS_TYPE_L4_IPV6_UDP_EX,
>  	[10] = XDP_RSS_TYPE_NONE, /* RSS Type above 9 "Reserved" by HW
> */
>  	[11] = XDP_RSS_TYPE_NONE, /* keep array sized for SW bit-mask
> */
> -	[12] = XDP_RSS_TYPE_NONE, /* to handle future HW revisons
> */
> +	[12] = XDP_RSS_TYPE_NONE, /* to handle future HW revisions
> */
>  	[13] = XDP_RSS_TYPE_NONE,
>  	[14] = XDP_RSS_TYPE_NONE,
>  	[15] = XDP_RSS_TYPE_NONE,
> 
> --
> Git-155)
> 

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

Re: [PATCH v2 1/2] igb: fix typos in comments

[Joe Damato]

On Wed, Mar 04, 2026 at 08:21:19AM +0100, Maximilian Pezzullo via B4 Relay wrote:
> From: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> 
> Fix spelling errors in code comments:
>  - e1000_nvm.c: 'likley' -> 'likely'
>  - e1000_mac.c: 'auto-negotitation' -> 'auto-negotiation'
>  - e1000_mbx.h: 'exra' -> 'extra'
>  - e1000_defines.h: 'Aserted' -> 'Asserted'
> 
> Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> ---
>  drivers/net/ethernet/intel/igb/e1000_defines.h | 2 +-
>  drivers/net/ethernet/intel/igb/e1000_mac.c     | 2 +-
>  drivers/net/ethernet/intel/igb/e1000_mbx.h     | 2 +-
>  drivers/net/ethernet/intel/igb/e1000_nvm.c     | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Joe Damato <joe@dama.to>

Re: [PATCH v2 2/2] igc: fix typos in comments

[Joe Damato]

On Wed, Mar 04, 2026 at 08:21:20AM +0100, Maximilian Pezzullo via B4 Relay wrote:
> From: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> 
> Fix spelling errors in code comments:
>  - igc_diag.c: 'autonegotioation' -> 'autonegotiation'
>  - igc_main.c: 'revisons' -> 'revisions' (two occurrences)
> 
> Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> ---
>  drivers/net/ethernet/intel/igc/igc_diag.c | 2 +-
>  drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Joe Damato <joe@dama.to>

Re: [Intel-wired-lan] [PATCH v2 2/2] igc: fix typos in comments

[Dahan, AvigailX]

On 04/03/2026 9:21, Maximilian Pezzullo via B4 Relay wrote:
> From: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> 
> Fix spelling errors in code comments:
>   - igc_diag.c: 'autonegotioation' -> 'autonegotiation'
>   - igc_main.c: 'revisons' -> 'revisions' (two occurrences)
> 
> Signed-off-by: Maximilian Pezzullo <maximilianpezzullo@gmail.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_diag.c | 2 +-
>   drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 

Tested-by: Avigail Dahan <avigailx.dahan@intel.com>