* [PATCH iproute2-next] rdma: Add driver QP type string
@ 2019-08-04 8:07 Gal Pressman
2019-08-04 9:52 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gal Pressman @ 2019-08-04 8:07 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, linux-rdma, Leon Romanovsky, Gal Pressman
RDMA resource tracker now tracks driver QPs as well, add driver QP type
string to qp_types_to_str function.
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
rdma/res.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/rdma/res.c b/rdma/res.c
index ef863f142eca..97a7b9640185 100644
--- a/rdma/res.c
+++ b/rdma/res.c
@@ -148,9 +148,11 @@ const char *qp_types_to_str(uint8_t idx)
"UC", "UD", "RAW_IPV6",
"RAW_ETHERTYPE",
"UNKNOWN", "RAW_PACKET",
- "XRC_INI", "XRC_TGT" };
+ "XRC_INI", "XRC_TGT",
+ [0xFF] = "DRIVER",
+ };
- if (idx < ARRAY_SIZE(qp_types_str))
+ if (idx < ARRAY_SIZE(qp_types_str) && qp_types_str[idx])
return qp_types_str[idx];
return "UNKNOWN";
}
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH iproute2-next] rdma: Add driver QP type string
2019-08-04 8:07 [PATCH iproute2-next] rdma: Add driver QP type string Gal Pressman
@ 2019-08-04 9:52 ` Leon Romanovsky
2019-08-05 19:08 ` David Ahern
2019-08-07 19:07 ` David Ahern
2 siblings, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2019-08-04 9:52 UTC (permalink / raw)
To: Gal Pressman; +Cc: Stephen Hemminger, netdev, linux-rdma
On Sun, Aug 04, 2019 at 11:07:56AM +0300, Gal Pressman wrote:
> RDMA resource tracker now tracks driver QPs as well, add driver QP type
> string to qp_types_to_str function.
>
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
> rdma/res.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next] rdma: Add driver QP type string
2019-08-04 8:07 [PATCH iproute2-next] rdma: Add driver QP type string Gal Pressman
2019-08-04 9:52 ` Leon Romanovsky
@ 2019-08-05 19:08 ` David Ahern
2019-08-06 6:41 ` Gal Pressman
2019-08-07 19:07 ` David Ahern
2 siblings, 1 reply; 6+ messages in thread
From: David Ahern @ 2019-08-05 19:08 UTC (permalink / raw)
To: Gal Pressman, Stephen Hemminger; +Cc: netdev, linux-rdma, Leon Romanovsky
On 8/4/19 2:07 AM, Gal Pressman wrote:
> RDMA resource tracker now tracks driver QPs as well, add driver QP type
> string to qp_types_to_str function.
"now" means which kernel release? Leon: should this be in master or -next?
>
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
> rdma/res.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/rdma/res.c b/rdma/res.c
> index ef863f142eca..97a7b9640185 100644
> --- a/rdma/res.c
> +++ b/rdma/res.c
> @@ -148,9 +148,11 @@ const char *qp_types_to_str(uint8_t idx)
> "UC", "UD", "RAW_IPV6",
> "RAW_ETHERTYPE",
> "UNKNOWN", "RAW_PACKET",
> - "XRC_INI", "XRC_TGT" };
> + "XRC_INI", "XRC_TGT",
> + [0xFF] = "DRIVER",
> + };
>
> - if (idx < ARRAY_SIZE(qp_types_str))
> + if (idx < ARRAY_SIZE(qp_types_str) && qp_types_str[idx])
> return qp_types_str[idx];
> return "UNKNOWN";
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next] rdma: Add driver QP type string
2019-08-05 19:08 ` David Ahern
@ 2019-08-06 6:41 ` Gal Pressman
2019-08-06 6:54 ` Leon Romanovsky
0 siblings, 1 reply; 6+ messages in thread
From: Gal Pressman @ 2019-08-06 6:41 UTC (permalink / raw)
To: David Ahern, Stephen Hemminger; +Cc: netdev, linux-rdma, Leon Romanovsky
On 05/08/2019 22:08, David Ahern wrote:
> On 8/4/19 2:07 AM, Gal Pressman wrote:
>> RDMA resource tracker now tracks driver QPs as well, add driver QP type
>> string to qp_types_to_str function.
>
> "now" means which kernel release? Leon: should this be in master or -next?
Now means the patch is merged to RDMA's for-rc branch (5.3).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next] rdma: Add driver QP type string
2019-08-06 6:41 ` Gal Pressman
@ 2019-08-06 6:54 ` Leon Romanovsky
0 siblings, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2019-08-06 6:54 UTC (permalink / raw)
To: Gal Pressman; +Cc: David Ahern, Stephen Hemminger, netdev, linux-rdma
On Tue, Aug 06, 2019 at 09:41:37AM +0300, Gal Pressman wrote:
> On 05/08/2019 22:08, David Ahern wrote:
> > On 8/4/19 2:07 AM, Gal Pressman wrote:
> >> RDMA resource tracker now tracks driver QPs as well, add driver QP type
> >> string to qp_types_to_str function.
> >
> > "now" means which kernel release? Leon: should this be in master or -next?
>
> Now means the patch is merged to RDMA's for-rc branch (5.3).
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/infiniband?id=52e0a118a20308dd6aa531e20a5ab5907d2264c8
David,
I think that it is better to apply this patch to iproute2-rc just
to be on the same page with kernel patch.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next] rdma: Add driver QP type string
2019-08-04 8:07 [PATCH iproute2-next] rdma: Add driver QP type string Gal Pressman
2019-08-04 9:52 ` Leon Romanovsky
2019-08-05 19:08 ` David Ahern
@ 2019-08-07 19:07 ` David Ahern
2 siblings, 0 replies; 6+ messages in thread
From: David Ahern @ 2019-08-07 19:07 UTC (permalink / raw)
To: Gal Pressman, Stephen Hemminger; +Cc: netdev, linux-rdma, Leon Romanovsky
On 8/4/19 2:07 AM, Gal Pressman wrote:
> RDMA resource tracker now tracks driver QPs as well, add driver QP type
> string to qp_types_to_str function.
>
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
> rdma/res.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
applied to iproute2-next. Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-07 19:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-04 8:07 [PATCH iproute2-next] rdma: Add driver QP type string Gal Pressman
2019-08-04 9:52 ` Leon Romanovsky
2019-08-05 19:08 ` David Ahern
2019-08-06 6:41 ` Gal Pressman
2019-08-06 6:54 ` Leon Romanovsky
2019-08-07 19:07 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).