From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246E025228D for ; Mon, 16 Mar 2026 10:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656042; cv=none; b=eWxYhHiza1+ql0qckFUrM1JoquN8MYKKwRCYCzgawgH0exkmR8JLpLC7+zAF6OU1TeiY/irGhsdyYU0usHH1eLiYOPbS4v+di2BVkQScU0hqcRfrRSPhXrPJIwAmSfrF+giyGGp7ND1B6+nlmOF8Hospu2+KGIz80VjdDdTg2vU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656042; c=relaxed/simple; bh=9UVAHyAbT5Sl+MiwTQMn4EfKjFoBsfxG62joT2TEEqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i9HJssbhNyLTtISbC6DlyjVU2t0OQ2eE6DQ5P/y2IM3Hl/DaKVybQzJsIDOYfL8lSfvFtRK8Y4STIYaXirYJQTEP5z+qrG/awugz09DSV0YRkG8j4jYhMth3/8Mj6xoc/TfRTfmlxZ+AEAiaKxEGFBxmNIQHZ/ZNdk59Xp9HkGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=WTeO48+c; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=fQAsmXCy; arc=none smtp.client-ip=202.12.124.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="WTeO48+c"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="fQAsmXCy" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfout.stl.internal (Postfix) with ESMTP id 3DB4B1D0004A; Mon, 16 Mar 2026 06:13:59 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Mon, 16 Mar 2026 06:13:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1773656038; x= 1773742438; bh=1q+7/EaTjQmDo/ZmOZRbd0ZccTDZu8hG3QPNlueC+aQ=; b=W TeO48+cucFO5iv3RkV0uJKgrQiEqT6mQuBKfpxS/FUqNyihesKOGueY2T4RADPnz x8prxOAI4veSOXKh4sRs8Zu5HcZAZgJSzFi2jptAN6/770OgU5C0j+UOthycVsBk dbJq8jo4jJfshh3yvgLQBP4sM4AVOuRvdMHExgIH97P86oBMw7BGq43iW76T7bI+ fGvLIWV5rPkQ8gBLn1odvGiL4FyTY1lcHE9YiR7lYJxNz3AFFkZB6lL+rGjvgpbs 8mga+Q1o2rdcY9T0GPZMWwG4HvH8ptujEiWkHBp/OR+iwJr67Dw2WXQlNAvF/7lh +zinf+9S04iJnZQaSMahQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773656038; x=1773742438; bh=1q+7/EaTjQmDo/ZmOZRbd0ZccTDZu8hG3QP NlueC+aQ=; b=fQAsmXCywf0eDhkC/VU5EKJJLMEcLDl8e3FNmgegH6h0aiRdU9Q IMaVXptoBftMW2KJ7nvapHZMKdZ/M4YBsv/5uPjnKFQe0iZRSBP94ybAOon6gJ+S Gz12KwbMh7iUsMEC3iC0xlM1wuD2u//+AZwaSiCV9J/5amkWW7QICE8kNd99UhJ/ MjT8TEoSzuOEiS+mqrv8lj12sfcf6BORO5P8JM6oQHWzlTFxHh+7nMnKAqdcjISw +yqa3FwwP2Cb8MZqvjLpI1OSlhcZhkw3USl6HDFZ/VSYcUvUd8/DLSMDWeifgpQI 4eU+RzSrIazsmfpkgIV3AEN6r7N/Id02KhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvleekudduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopeejpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopegtvghlsehkvghrnhgvlhdrohhrghdprhgtph htthhopehjohhhnhdrfhgrshhtrggsvghnugesghhmrghilhdrtghomhdprhgtphhtthho pehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepnhgvthguvghvsehvghgvrh drkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhgvrhhnvghlqdhtlhhsqdhhrghnughs hhgrkhgvsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtoheptghhuhgtkhdrlh gvvhgvrhesohhrrggtlhgvrdgtohhmpdhrtghpthhtohephhgrrhgvsehsuhhsvgdruggv X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 Mar 2026 06:13:57 -0400 (EDT) Date: Mon, 16 Mar 2026 11:13:56 +0100 From: Sabrina Dubroca To: Chuck Lever Cc: john.fastabend@gmail.com, kuba@kernel.org, netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev, Chuck Lever , Hannes Reinecke Subject: Re: [PATCH v3 1/8] tls: Factor tls_decrypt_async_drain() from recvmsg Message-ID: References: <20260312014804.5083-1-cel@kernel.org> <20260312014804.5083-2-cel@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260312014804.5083-2-cel@kernel.org> 2026-03-11, 21:47:57 -0400, Chuck Lever wrote: > From: Chuck Lever > > The recvmsg path pairs tls_decrypt_async_wait() with > __skb_queue_purge(&ctx->async_hold). Bundling the two into > tls_decrypt_async_drain() gives later patches a single call for > async teardown. I was wondering if tls_decrypt_async_wait() without __skb_queue_purge() is ever the right thing. Once we've waited for all pending decryptions, async_hold's job is done, we don't need to keep all that memory around anymore. Should we just move recvmsg's __skb_queue_purge() into tls_decrypt_async_wait()? -- Sabrina