From: David Christensen <drc@linux.vnet.ibm.com>
To: Manish Chopra <manishc@marvell.com>,
Netdev <netdev@vger.kernel.org>, Ariel Elior <aelior@marvell.com>,
Sudarsana Reddy Kalluru <skalluru@marvell.com>
Subject: Re: [EXT] EEH Causes bnx2x to Hang in napi_disable
Date: Wed, 20 Apr 2022 10:23:28 -0700 [thread overview]
Message-ID: <abffa0b0-300d-8ecd-8319-c99621198c86@linux.vnet.ibm.com> (raw)
In-Reply-To: <BY3PR18MB4612CB2F82889E5B155BD03EABEE9@BY3PR18MB4612.namprd18.prod.outlook.com>
>> ----------------------------------------------------------------------
>> Experiencing an inaccessible system when bnx2x attempts to recover from an
>> injected EEH error. This is a POWER10 system running SLES 15 SP3
>> (5.3.18-150300.59.49-default) with a BCM57810 dual port NIC.
>>
> Thanks for reporting this issue, I tried to reproduce the same issue where in my case it leaded to system crash but it was not exactly the same
> symptom of hang/stuck in napi_disable(). But I believe they all have the same root cause for different issues as you stated about the incorrect
> sequence of NAPI API usage in this particular driver flow (unlike in regular unload flow (ndo_stop()) where it deletes NAPI after it disables the NAPI).
> So driver actually needs to disable NAPI first and delete the NAPI afterwards, I tried below change which fixed the crash which I was always seeing on
> my setup.
>
> Can you please try this below change to see if that helps for the issue you reported or not ?
Glad to report that it fixed our problem as well. Thanks for the help.
Dave
prev parent reply other threads:[~2022-04-20 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 18:06 EEH Causes bnx2x to Hang in napi_disable David Christensen
2022-04-15 14:48 ` [EXT] " Manish Chopra
2022-04-20 17:23 ` David Christensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abffa0b0-300d-8ecd-8319-c99621198c86@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=aelior@marvell.com \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox