* [PATCH v1 net-next] fou: Remove IPPROTO_UDPLITE check in gue_err() and gue6_err().
@ 2026-03-16 13:31 Kuniyuki Iwashima
2026-03-16 16:27 ` Joe Damato
2026-03-17 23:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Kuniyuki Iwashima @ 2026-03-16 13:31 UTC (permalink / raw)
To: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Simon Horman, Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
UDP-Lite has been removed, and its error handler is no
longer found in either inet_protos[IPPROTO_UDPLITE] or
inet6_protos[IPPROTO_UDPLITE].
The recursion fixed by the protocol check in gue_err()
and gue6_err() no longer occurs with UDP-Lite.
Let's remove the checks.
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
---
net/ipv4/fou_core.c | 3 +--
net/ipv6/fou6.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/fou_core.c b/net/ipv4/fou_core.c
index 3baaa4df7e42..5bae3cf7fe76 100644
--- a/net/ipv4/fou_core.c
+++ b/net/ipv4/fou_core.c
@@ -1150,8 +1150,7 @@ static int gue_err(struct sk_buff *skb, u32 info)
* recursion. Besides, this kind of encapsulation can't even be
* configured currently. Discard this.
*/
- if (guehdr->proto_ctype == IPPROTO_UDP ||
- guehdr->proto_ctype == IPPROTO_UDPLITE)
+ if (guehdr->proto_ctype == IPPROTO_UDP)
return -EOPNOTSUPP;
skb_set_transport_header(skb, -(int)sizeof(struct icmphdr));
diff --git a/net/ipv6/fou6.c b/net/ipv6/fou6.c
index 430518ae26fa..157765259e2f 100644
--- a/net/ipv6/fou6.c
+++ b/net/ipv6/fou6.c
@@ -141,8 +141,7 @@ static int gue6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
* recursion. Besides, this kind of encapsulation can't even be
* configured currently. Discard this.
*/
- if (guehdr->proto_ctype == IPPROTO_UDP ||
- guehdr->proto_ctype == IPPROTO_UDPLITE)
+ if (guehdr->proto_ctype == IPPROTO_UDP)
return -EOPNOTSUPP;
skb_set_transport_header(skb, -(int)sizeof(struct icmp6hdr));
--
2.53.0.851.ga537e3e6e9-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net-next] fou: Remove IPPROTO_UDPLITE check in gue_err() and gue6_err().
2026-03-16 13:31 [PATCH v1 net-next] fou: Remove IPPROTO_UDPLITE check in gue_err() and gue6_err() Kuniyuki Iwashima
@ 2026-03-16 16:27 ` Joe Damato
2026-03-17 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Joe Damato @ 2026-03-16 16:27 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, Kuniyuki Iwashima, netdev
On Mon, Mar 16, 2026 at 01:31:25PM +0000, Kuniyuki Iwashima wrote:
> UDP-Lite has been removed, and its error handler is no
> longer found in either inet_protos[IPPROTO_UDPLITE] or
> inet6_protos[IPPROTO_UDPLITE].
>
> The recursion fixed by the protocol check in gue_err()
> and gue6_err() no longer occurs with UDP-Lite.
>
> Let's remove the checks.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
> ---
> net/ipv4/fou_core.c | 3 +--
> net/ipv6/fou6.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Joe Damato <joe@dama.to>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net-next] fou: Remove IPPROTO_UDPLITE check in gue_err() and gue6_err().
2026-03-16 13:31 [PATCH v1 net-next] fou: Remove IPPROTO_UDPLITE check in gue_err() and gue6_err() Kuniyuki Iwashima
2026-03-16 16:27 ` Joe Damato
@ 2026-03-17 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-17 23:20 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: davem, dsahern, edumazet, kuba, pabeni, horms, kuni1840, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 16 Mar 2026 13:31:25 +0000 you wrote:
> UDP-Lite has been removed, and its error handler is no
> longer found in either inet_protos[IPPROTO_UDPLITE] or
> inet6_protos[IPPROTO_UDPLITE].
>
> The recursion fixed by the protocol check in gue_err()
> and gue6_err() no longer occurs with UDP-Lite.
>
> [...]
Here is the summary with links:
- [v1,net-next] fou: Remove IPPROTO_UDPLITE check in gue_err() and gue6_err().
https://git.kernel.org/netdev/net-next/c/e3f741f587a9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-17 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-16 13:31 [PATCH v1 net-next] fou: Remove IPPROTO_UDPLITE check in gue_err() and gue6_err() Kuniyuki Iwashima
2026-03-16 16:27 ` Joe Damato
2026-03-17 23:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox