From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C65573921EA for ; Tue, 17 Mar 2026 07:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773733326; cv=none; b=HlKfifaeJm5n0OzLHfph8dJZOMakOLvxZeJGuoP+Vh6V6LDo0ezyrremKkJyDMT09wyDR6DoJLMZQkCH3FfilRUyAADnMRpnjlVhJ042S0S9yztPH2X4DhlXeq1AE5PBd+mSsPvJDzRUuhLt2dX930v52in9F7OBx7w4cLhlU5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773733326; c=relaxed/simple; bh=xg9tpnpgfg5SClBenXIK/4GssEYnuYsuYHsNrY8UiCY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lYmuJiiM0Y09LXvtR57R5nRpMGM9lMjxAmWbwWlNq+m7qdSqM4JtmtZDGMxd5M7zL5vRgwqT/QO/l85eJidt2AG4lATPd5jbnqkG8L/JGzOt+HvpGp+K+5FJSiLPzzM5tScjOQeyZ7Q9+cieNmf4BWCJGg1YYmCNgzG+VwzT3lA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JpcIVgEC; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JpcIVgEC" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-827270d50d4so5073548b3a.3 for ; Tue, 17 Mar 2026 00:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773733324; x=1774338124; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3gTRwPvoaoGKMWruMLfYdpsxbqLbc2avIWpIrbVdsbs=; b=JpcIVgECwDFb+TNPexhIipO6ke7VswbUB0j0IrxMxTVU9yWPxZ1M3pFpxFTfMjHRqu 7OZ52HKI2W/WDmfJXv8tRfrAtZTQH1cVshLQZjnz6X2BfQEpaeGA0yrMZHKGVwVTw/LN o2j1Gk4n5jTGZYb6s4xRWFmZyZmCJx9ejOVorc98HrPG+w9sGSh5Hh2b2w7iVXGd6fwb hGQkvYeQIOG0yUmdr9Ib6Nh3qdLtJTCHc59g3vJX/rxVjXNa+zN7b+hgQ/OyMIdOvfJr +DYDXJfmltmdO5ilOMDCzSTlz09u6B2rDcaojNAv7st/53wwMwLe35MSZG1gZDJvT6Aw GjBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773733324; x=1774338124; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3gTRwPvoaoGKMWruMLfYdpsxbqLbc2avIWpIrbVdsbs=; b=VyFf67+KGKny5axFqrLMSqsYs5c3VpsqWbEpvWymFOA4ZSmTo+yPOAQVQPx+6Ya8rv xYp5w6IJLufnH4gvWcsdaLWY5HG+NS1enu31olbo3LI0KtzYOXpNi/IYwZPL/dLZFASh EPcYX5esipUnl2D6Hw9WMJE1YFJSaZPfQEBgupM7fScv3LBJvM6z9bjeq8MCqmFGp9eI WZb1eRYje/7NFGi0WN73wt1ImRAL9jlG69YKrap6gYAKbstGa9Mk17RAWn8FjtAnqzw/ jlKh37tIpt7BIwwmkvzT95Wq0npMbD71wgEK36/+MuWnrMtDp+9c9LdMh+gDbKwyuGZc xVUQ== X-Forwarded-Encrypted: i=1; AJvYcCV2U/4xfCml1QyEYRM5L0rdpKBIaIHiTGH+qcbBiTbMwVLp+D4HGTsrQIPAICvHYhRptPpj/Cs=@vger.kernel.org X-Gm-Message-State: AOJu0YxK0NdJv/iDZgDrsckGTR+W5wl1scNpvtCJmm9RXqHSix+y0VHt GVwioweqSImkVn+gJCMIqQ2BSb+tRStu2Uxd2gg1LvADb7etHS1jM2xw X-Gm-Gg: ATEYQzx7Bw+QjZWnMdmU+sa2HxezSNuVtm95fEJ6QwteWKWRLVON8nqFojqsz7VhxpW fAqnwuYlRgSlbqE/WlAofdWTyVdE+6AMrvMTV/9BdncqY9yS5qQAwGEei7zmSHawsAAA6UlPSuq HDMnaOwo+w7zwxP/dbV/1ocbPVgsFcMNgEim/ZOWwCMd9ibz2Ov7rzPjaE7r81DGQ97XvHEW2kC MvFertwmIRwqBzl8ckk+ATE8LGg5EUxEiGH7tqJhv/aage4QnfoNoa600+sXfU6MCliYEzgdNAq uiMTA3PG5Nu8/0EJO0BGJuNoyZ7/RdnDT6fimc/qhowUyFtRt0e7IZ1uY5BSAEHh4cucb0c6gZh bXWEj3AFVF+Q1vj1qvemi2FhIznPhMiPasN5SiZ7Y/sPtHHMmceXDRs2JTDy3kc2isbPPpUQoxY deIXhUGlNcYp8fBCUXr0xEP7E= X-Received: by 2002:aa7:88c9:0:b0:81f:4675:c2a9 with SMTP id d2e1a72fcca58-82a1957f3b6mr14731969b3a.0.1773733324070; Tue, 17 Mar 2026 00:42:04 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0736deb4sm15367325b3a.44.2026.03.17.00.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 00:42:03 -0700 (PDT) Date: Tue, 17 Mar 2026 15:41:56 +0800 From: Inochi Amaoto To: Jakub Kicinski , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Russell King (Oracle)" , Yao Zi , Yanteng Si , Vladimir Oltean , Lad Prabhakar , Shangjuan Wei , Chen-Yu Tsai , Zhi Li , Boon Khai Ng , Maxime Chevallier , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [PATCH net-next v10 1/4] dt-bindings: net: Add support for Spacemit K3 dwmac Message-ID: References: <20260316010041.164360-1-inochiama@gmail.com> <20260316010041.164360-2-inochiama@gmail.com> <20260316202147.431d9aeb@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316202147.431d9aeb@kernel.org> On Mon, Mar 16, 2026 at 08:21:47PM -0700, Jakub Kicinski wrote: > On Mon, 16 Mar 2026 09:00:37 +0800 Inochi Amaoto wrote: > > The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare > > MAC (version 5.40a) with some extra clock. > > > > Add necessary compatible string for this device. > > In the previous version the AI reviewer complained that we're not > adding the new entry to the select at the top of the file. Other > compatibles appear in 3 places in > Documentation/devicetree/bindings/net/snps,dwmac.yaml > > Also I asked whether we can drop the "default m" > For the Kconfig, I think it is better to keep the thing the same as others. And I guess this question may be related to some compromise that I do not know, and it is a hard thing for me to answer. > Did you disagree with those comments or did you miss them? > stmmac is a strange beast I don't really know what's going on in > the binding, so just double checking this is intentional.. Oh, I have forgot to reply to the binding. Currently, I disagree to add something in the select, as a new binding is always required for a new device. Even if it is already supported in the existing kernel, the new device is required to add at least a new compatiable string for it. Regards, Inochi