From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 345163B776A; Tue, 17 Mar 2026 11:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773748742; cv=none; b=pEik2o/fWZW/GL2AfHRgLcywF27RXKYeANLFa6f1ZDuYeNrCIp/zWVG5cTl1kefd39oJHnMpvZv0DxooYLG7B/YgXbx4C3aI9Yt2qRE8Qxlitq9URyFUSKgUZ8kEe6mFpEM5zO8/7/jRMNQIs6s/aVbfJ07iASTpTU/5PX2Z/as= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773748742; c=relaxed/simple; bh=WzpohQTFAg+/+5fjgYupL5nMEp8YLjnG0HBxCA/Fido=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NKmB6nUrjVLGIjA7GhjAFBhgp6ltcQqGCNbFNi+uc8CnvfysVXBO68c5GLVMFUFmhrj8OUSbrZAQLkiN47uFTeVwx3S2Tftl2EzYpnrkhKolnSxiupUJCziZykxKuCPatxJSGW1XiO27gIgd/U7JRq0Fvvoxx+DKQcwiYoPq9lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=sBGSXHmV; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=KoFhcBVO; arc=none smtp.client-ip=202.12.124.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="sBGSXHmV"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KoFhcBVO" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id A68CB1D00175; Tue, 17 Mar 2026 07:58:57 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Tue, 17 Mar 2026 07:58:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1773748737; x= 1773835137; bh=LQKKJmXb+zrz4f+7W1idnzMcDl0vzLq+F8OkS2Y6DOc=; b=s BGSXHmVDI4CGagxvI+Aqoo7MErNV32aqTztJ67/hkY/49eLmgh9irqikMUvyhSKd 6gmh5uc96OUkfeWNgy3NTMsIqVWaJxsO1vOz6YhUMUGK62zxxepU0D4Zxt75vTWe 2kpbTiSJYg9NPmxmCD3xaPPTRzaY30OS2eoPxPEz5EQY6BfpELg0HKQGFD9a2ZT/ +tvyZMsp9LCO+9mCAVVJ9ZCwGpBQFwINaoWUiMFhayV728yi7OQVSMFZWxNLOCCI RkXIZc30LOVfmPr/w4qQN+Z4ee5+vyelKDJm/WVUJBqdKPtLNUL3ezrmMOPOb0gy 2AoYGXlrUKSsTtg+75tYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773748737; x=1773835137; bh=LQKKJmXb+zrz4f+7W1idnzMcDl0vzLq+F8O kS2Y6DOc=; b=KoFhcBVOcfAMJPRVhaorXh8apoVVymXAMIWNkDwQZ+MdwTs7WmE GwrJMTQZ44hKVUSw0DHXYRlc7z5ZvfFF7HdEo5S2Uc4lg1inmKqAfGt622Ez8NY8 wshjKtNBgcUYFhbnQLh2UVWLgKPWZdT79gNvwgclu0jK8UuOqCv+M5koNif8TV3Y HSJWGjbmVXHpfxA2dTs33tjd4s5/snXNzeXZnr5yIdxpoiJZhbj9QdKU7ZdsW1da zOBGjRa8ZReTxjeb/3AMSvBnw02FNceMANYpdBuVMK7JJ2k/wfRqUMaZek2ITJgy ocwnf7Ud/Qhxv9XaTfYpQxtOxYGAleJurhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdduudelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopeduhedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhiuhhhrghnghgsihhnsehgmhgrihhlrd gtohhmpdhrtghpthhtohepjhhvsehjvhhoshgsuhhrghhhrdhnvghtpdhrtghpthhtohep rghnughrvgifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmse gurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhl vgdrtghomhdprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoh epphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehjihhrihesrhgvshhn uhhllhhirdhushdprhgtphhtthhopehrrgiiohhrsegslhgrtghkfigrlhhlrdhorhhg X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Mar 2026 07:58:55 -0400 (EDT) Date: Tue, 17 Mar 2026 12:58:54 +0100 From: Sabrina Dubroca To: Hangbin Liu Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Nikolay Aleksandrov , Ido Schimmel , Simon Horman , Sridhar Samudrala , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev Subject: Re: [PATCH net-next v3 3/5] macsec: move netdev_upper_dev_link() after macsec_changelink_common() Message-ID: References: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> <20260316-offload_compute-v3-3-a5d4a07d86d3@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260316-offload_compute-v3-3-a5d4a07d86d3@gmail.com> 2026-03-16, 12:26:11 +0800, Hangbin Liu wrote: > After calling netdev_change_features() in __netdev_upper_dev_link(), > the call stack looks like: > > - netdev_upper_dev_link > - __netdev_upper_dev_link > - netdev_change_features > - notifier_call_chain > - rtnetlink_event > - rtmsg_ifinfo_event > - rtmsg_ifinfo_build_skb > > In macsec, we call netdev_upper_dev_link() before > macsec_changelink_common(), which causes the fields of the MACsec > Security Entity to be uninitialized. Later, macsec_fill_info() returns > -EMSGSIZE and triggers WARN_ON() in rtmsg_ifinfo_build_skb. > > Fix this by moving netdev_upper_dev_link() after > macsec_changelink_common(), and return 0 if secy->key_len is not > initialized yet. > > Suggested-by: Sabrina Dubroca > Signed-off-by: Hangbin Liu > --- > drivers/net/macsec.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) I'm not sure I'll manage to look at the rest of the series before it's applied, but for this patch: Reviewed-by: Sabrina Dubroca Thanks Hangbin. -- Sabrina