From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39B173C1996; Tue, 17 Mar 2026 14:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758932; cv=none; b=BWar9UrMczjbgRhN3hQjjC24lWfopjGYwyw/DMzjwt7085aE0rBWY5N6kbmF9w023R3OpxtVMF4hsDsMDfuvXm7Ipqnne6fcUT3vF/gxAdzy5N+5mCn33t7gtmN+emRxWL15QMD1tE4ZY4ycEQlgSzmDpAU1FlMnvCS/jNmDaOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758932; c=relaxed/simple; bh=NcLRT2jfRcS3/EWO8ugDg/YDV4/gGMzfDy/lruWgLuk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PM1Ee2iu1crXvmKUYBxIKqVFOfhQ7HtUrReBOZ/EbserjNV2wxuSWgUBhhl8ARVNKayLtUs3AsGk3g492dmtR7kYiHmvtUsSqhkaSB/dXJx4BcdmSpQUT7crZq+m5BTLYCgyFDruAkEaeqjRO7rtHhJsGN6tEZKCjyJ5oOKTub4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=1vSt24yX; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="1vSt24yX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uBLyAAnBvC4Y6dlPU+VQ8J/Go3H/Rpdcc6gQ7q2rdNM=; b=1vSt24yX6OiavMjiOSTcAQRqR1 uA/E2DbMceTjg7uSYVVHh1h7VuI7SW2cB08Wg235S2FUZtHr7U2bo9BoKDmtDo8L1VqLGQTDw4Bzk Jkh4Y4/J4K3ze0MRStvQgKEo0bXeI+ErvXEcOt7viJ/rRGdNxsWtnSob1I+uGztbeLmvU+yMoJu52 /aLtGZsfQYgflkyudQ87Rg/H/lr5MZQslAae89dvQEPjb+w9pnikmzu5jbrf7WuDXTzX1vl8OnZhq v8c0jCPEGj4cONRgAZiQiuVuhpQr2JFNdDJeaUrnYuuLwvQTbWGpk3DvyDge2poLH5L5af+LKg45p TwfCWwdQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42608) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w2Vis-000000005NL-3Zzy; Tue, 17 Mar 2026 14:48:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w2Vip-0000000067Q-3LVa; Tue, 17 Mar 2026 14:48:39 +0000 Date: Tue, 17 Mar 2026 14:48:39 +0000 From: "Russell King (Oracle)" To: Mohd Ayaan Anwar Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH net-next 0/8] net: stmmac: improve PCS support Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Mon, Mar 16, 2026 at 01:11:23AM +0000, Russell King (Oracle) wrote: > This will be because we're not attaching any PHYs when phylink is > being told to operate in 2500BASE-X with inband, since it thinks > that's the media. That, and, because stmmac has a long history, it > needed a special phylink_expects_phy() check added in stmmac_init_phy() > which his what prevents the PHY being attached. Okay, another idea that I hope will work. Please drop the "net: stmmac: qcom-ethqos: enable inband mode for SGMII" patch so we go back to using outband mode for everything. Then, disable the call to ethqos_pcs_set_inband() so inband mode doesn't get enabled for SGMII - as phylink will be telling the PHY to disable inband mode. Does that result in functional 100M, 1G and 2.5G speeds? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!