From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Mina Almasry <almasrymina@google.com>, Wei Wang <weibunny@fb.com>,
David Wei <dw@davidwei.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
Bobby Eshleman <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next 5/6] selftests: drv-net: add netkit devmem RX test
Date: Tue, 17 Mar 2026 17:54:04 -0700 [thread overview]
Message-ID: <abn3rJGXXyDYSNzA@devvm11784.nha0.facebook.com> (raw)
In-Reply-To: <abns9COj7WagFtZ8@mini-arch>
On Tue, Mar 17, 2026 at 05:08:20PM -0700, Stanislav Fomichev wrote:
> On 03/16, Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@meta.com>
> >
> > Add tests for devmem RX over a netkit device with a leased queue. This
> > is the same as the other devmem RX test except for ncdevmem executes in
> > a namespace, binds to a netkit, and skips the ethtool NIC configuration
> > steps (relying on the test runner for that setup).
> >
> > The RX path is setup as the following:
> >
> > RX Path
> > -------
> >
> > Remote Physical NIC Netkit Host Netkit Guest (netns)
> > | | | |
> > |--- TCP send ------>| | |
> > |-------------------->| |
> > dmabuf |--- BPF redirect -->|
> >
>
> Is it too messy to parametrize the existing test to run both with and
> without the namespaces? Feels like should be somewhat doable in python?
IIUC, we could have main() do something like:
for env [NetDrvContEnv, NetDrvEpEnv]:
with env as cfg:
[...]
ksft_run(tests, args=(cfg,))
And then the tests could call helpers that check cfg.netns to use the
nk_{guest,host}_ip6 addresses when true, otherwise use the regular
addresses?
It should be doable if I'm following your drift.
Best,
Bobby
next prev parent reply other threads:[~2026-03-18 0:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 22:29 [PATCH net-next 0/6] net: devmem: support devmem with netkit devices Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 1/6] net: devmem: support TX through netkit leased queues Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 2/6] selftests: drv-net: extract _find_bss_map_id helper in NetDrvContEnv Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 3/6] selftests: drv-net: add skip-config flag to ncdevmem Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 4/6] selftests: drv-net: add primary RX redirect support to NetDrvContEnv Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 5/6] selftests: drv-net: add netkit devmem RX test Bobby Eshleman
2026-03-18 0:08 ` Stanislav Fomichev
2026-03-18 0:54 ` Bobby Eshleman [this message]
2026-03-18 14:59 ` Stanislav Fomichev
2026-03-18 16:21 ` Bobby Eshleman
2026-03-18 23:10 ` Jakub Kicinski
2026-03-19 0:01 ` Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 6/6] selftests: drv-net: add netkit devmem TX test Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abn3rJGXXyDYSNzA@devvm11784.nha0.facebook.com \
--to=bobbyeshleman@gmail.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
--cc=weibunny@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox