From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D533F65F5 for ; Wed, 18 Mar 2026 16:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773850598; cv=none; b=YzWIKVmRO+mm5Zba8o3kjCKc7OgqDCcQCMiUjyc9K8wqt3BwDAHKBJ4juMWGhuuDcQlHkh1Xg3E2q1FqlbVB106iHiC/vxFg8gsIGiRsqNFDgh1SpQaGB2kxjpTikvrMwthVqu07a0QQdCEwa5GXVH29JWodK+wVzmaY4uixeMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773850598; c=relaxed/simple; bh=cVJluK3TyDFVcOJa07LmzKrKJzuXgnk0YMFEuT5VkI4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q/bG4sKrcTUT3EY0m/vaGK+Z0hGjEod1b9eCx+nTYe14eFqjdC2AMdrEODj0EiquBpHh5di/f9k/KWYmAJFcPOm/pkrWtOO0CA5NPn6Q2wfUU9VrlxdSI4EbZOiLXFYBhRvXHcgghp1G4c35QdR5IdrjbTyh0bka8xl+3EbsXKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AoSz+IWV; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AoSz+IWV" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2c0d36f3888so126117eec.0 for ; Wed, 18 Mar 2026 09:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773850587; x=1774455387; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=Dla1BTbyc4l54nWX3/vfHTdXPEelTK/vnnV7aOlfzTg=; b=AoSz+IWVLDGje93UL+/laOx3Mm0bxjDxLZJaDpknBN4X8GKG9GRLRfG7DxLwpZjh+5 dJV1k8J7EkT4oSMBi2qaQTnxP8BhAtdYbcLnuf75ASSnQ8dmIc+Lyh8cElL5B02r13Po LOZ4JY7M6r+bLWm7dHU0ExjewkvCEXrXAWzJdHMiQvti0m7mOkrONr/hn/m1pmpQGSrk GTydgAkOkKDELZQ2TztMxAnRJnEvqdes/NdSkDwOHACBTXTCEM3QIYyy/JKWlQlwyucA ycNIKH81TaqjKFEiaSmD1KzL+/zx1SaBO2bYv7IwkRw5Vh1CvAKBaM9VhN/1+xtGkYs2 FuOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773850587; x=1774455387; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dla1BTbyc4l54nWX3/vfHTdXPEelTK/vnnV7aOlfzTg=; b=BouVtfWa7+PAi7yEnXMmBZjxaUAFe7aTR310prFIWepdQwVeoxVCQtekrTHAmFp9Lk iDMBj982OS1LLZ+Vg8VU61rreR+SSR3XF5Vi2VjDzLrrZlgMyxMb4r6m1G/L9p6OfqLh D+++wdza/eTJCvkWXnwt9K13debexZJ8ZsaGR2zd2VWXETKT7nnPgeCSfS0yNbu4yKrV 07RTZD06bfjejtZqN9arc47vU3TyIkOTjlJLR2agLFJ7vh3nGRmc1vE2FDnTrmhI3wgP BVkEuBeI/RPwRHa3K36bW6Tfh55mSRRQ8BqOpfWdokX2EO6cOxPZ79jyrDCf9VruR95Z OGPA== X-Gm-Message-State: AOJu0YyQtVnYPpA2oz+MuLzEP1al5sfRa2q1yNvrJVGJ/URB5rsnlqWq CQDFje6lQ+NognJ9nCjsRSRmLN6/1PY/taj/z1e2liTjok3ChqHBo8A= X-Gm-Gg: ATEYQzzxg9ncymfUOZJ20aco+fG8JBMTQnRl5Xz6OhtfJ5cW2SbJA2W397VAa66PfsA tCW7gFHmQtIF43DjyP+N5ZqiiJ4Z8YypjfS2NiArG1QUnVc59ouLH5dU9PzL8PPPboh5JSfDrb6 YTW9lec0rfX8eAl5LXI393Y6GHj/Ut3qyy2TbIHVr/3WBjZNG3+HJpbrFLi5aMWjcNhMEO+pizH wywT9G3rswi7b+A3HdSep4frE/a9qhMTrtLjaRuFnqRQpO7YtxYZmRzY2F1aAMLfY9ZIvfLewap ka794vQTA+5Un8esFjHnELhkKKyObU0MlVIlTsjHMGLYR2nrmpzXEesrfumJ33eLp1SYBHtheTd uyEimlDRZyFtJSghE1y+bFbPUTf2jyirnGVpmvYJu+GHchpJy8r+XV/h5f/WLE7GugRR9dU9kcZ oCW54M9U/p54KEd+Uhp9CgT+jOAs1KyjGu/i+Z35ZBNVcw0wDqQvEzhq+5eX0tO/jjxdOfj++Pk KXh7l25OYoTvlflew== X-Received: by 2002:a05:7022:6a5:b0:128:d471:8c1 with SMTP id a92af1059eb24-1299ba3e555mr1770451c88.17.1773850586365; Wed, 18 Mar 2026 09:16:26 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129b41289e7sm3582603c88.10.2026.03.18.09.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 09:16:25 -0700 (PDT) Date: Wed, 18 Mar 2026 09:16:24 -0700 From: Stanislav Fomichev To: Stanislav Fomichev Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: Re: [PATCH net-next v2 02/13] wifi: cfg80211: use __rtnl_unlock in nl80211_pre_doit Message-ID: Mail-Followup-To: Stanislav Fomichev , Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org References: <20260318150305.123900-1-sdf@fomichev.me> <20260318150305.123900-3-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260318150305.123900-3-sdf@fomichev.me> On 03/18, Stanislav Fomichev wrote: > nl80211_pre_doit acquires rtnl_lock and then wiphy_lock, releasing > rtnl while keeping wiphy_lock held until post_doit. With the > introduction of rx_mode_wq and its flush in netdev_run_todo, calling > rtnl_unlock here creates a circular lock dependency: > > Chain exists of: > (wq_completion)rx_mode_wq --> rtnl_mutex --> &rdev->wiphy.mtx > > Possible unsafe locking scenario: > > CPU0 CPU1 > ---- ---- > lock(&rdev->wiphy.mtx); > lock(rtnl_mutex); > lock(&rdev->wiphy.mtx); > lock((wq_completion)rx_mode_wq); > > Switch to __rtnl_unlock to skip netdev_run_todo in nl80211_pre_doit. > This seems safe because we run before the op. > > Link: http://lore.kernel.org/netdev/69b5ad67.a00a0220.3b25d1.001a.GAE@google.com > Signed-off-by: Stanislav Fomichev > --- > net/wireless/nl80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index 2225f5d0b124..ce5f25d4c87e 100644 > --- a/net/wireless/nl80211.c > +++ b/net/wireless/nl80211.c > @@ -18192,7 +18192,7 @@ static int nl80211_pre_doit(const struct genl_split_ops *ops, > __release(&rdev->wiphy.mtx); > } > if (!(internal_flags & NL80211_FLAG_NEED_RTNL)) > - rtnl_unlock(); > + __rtnl_unlock(); > > return 0; > out_unlock: > -- > 2.53.0 > ERROR: modpost: "__rtnl_unlock" [net/wireless/cfg80211.ko] undefined! Gonna re-run local nipa ingest locally to see if anything else pops up. --- pw-bot: cr