From: Joe Damato <joe@dama.to>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Mengyuan Lou <mengyuanlou@net-swift.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Kees Cook <kees@kernel.org>,
Michal Kubiak <michal.kubiak@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
Abdun Nihaal <abdun.nihaal@gmail.com>,
Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH net-next v5 01/11] net: ngbe: remove netdev->ethtool->wol_enabled setting
Date: Wed, 18 Mar 2026 12:59:25 -0700 [thread overview]
Message-ID: <absEHbnLK+k0Bmps@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20260317073827.4300-2-jiawenwu@trustnetic.com>
On Tue, Mar 17, 2026 at 03:38:17PM +0800, Jiawen Wu wrote:
> netdev->ethtool->wol_enabled is set in ethtool core code, so remove the
> redundant setting in ngbe_set_wol().
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/ethernet/wangxun/ngbe/ngbe_ethtool.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2026-03-18 19:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 7:38 [PATCH net-next v5 00/11] Wangxun improvement and new support Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 01/11] net: ngbe: remove netdev->ethtool->wol_enabled setting Jiawen Wu
2026-03-17 9:46 ` Breno Leitao
2026-03-18 19:59 ` Joe Damato [this message]
2026-03-17 7:38 ` [PATCH net-next v5 02/11] net: ngbe: move the WOL functions to libwx Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 03/11] net: ngbe: remove redundant macros Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 04/11] net: ngbe: improve the reset flow Jiawen Wu
2026-03-19 11:25 ` Paolo Abeni
2026-03-24 6:40 ` Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 05/11] net: wangxun: move reusable PCI driver ops functions into libwx Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 06/11] net: txgbe: add power management support Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 07/11] net: wangxun: move ethtool_ops.set_channels into libwx Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 08/11] net: wangxun: delete service_timer before cancel service_work Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 09/11] net: wangxun: add Tx timeout process Jiawen Wu
2026-03-19 11:31 ` Paolo Abeni
2026-03-17 7:38 ` [PATCH net-next v5 10/11] net: wangxun: improve flow control setting Jiawen Wu
2026-03-17 7:38 ` [PATCH net-next v5 11/11] net: wangxun: implement pci_error_handlers ops Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=absEHbnLK+k0Bmps@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=abdun.nihaal@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=leitao@debian.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox