From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02B682D4B40 for ; Wed, 18 Mar 2026 20:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773864674; cv=none; b=GsaDzsS0Zjj6QKYvVLk0pCF3u2lcv2DvH6LZb7oKveD2pAbR+x42vgvBk1wTlj0a1uXXao2h5u1n9gbMGCeUICMHmzqdzfa3B3a9HfHM8Gip3muD3tjGL1yFGTEhjTDe0FNw9gkov+rG/4oFYktzuoQoRznrsGIGJ12Wfyk5pLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773864674; c=relaxed/simple; bh=7V+tpJcHPHKkKArRby9B/AEvv+A6I5U8x69esMrCnRU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TLhZNqHUGisYKq9Fs+4oRpbKj2EaGBkqYLF7uKX5UBJldhlUUBAQmxxxpZcBrVOpz37tO/oqhsVX+bvavhaMbL4cWTZtLxq2c77sOQZsZqMM6WxLzA3Q/ZQqpZ9AE2EuqjnFkFUXnfyYEgHu9/McODS5U6S4SN24PmpQyQuZ13c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=DkWczbrN; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="DkWczbrN" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-82418b0178cso200564b3a.1 for ; Wed, 18 Mar 2026 13:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1773864672; x=1774469472; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=tcrjf6o6BBsskimuOBs0/X8mHwc2XWl98zNiH3etscg=; b=DkWczbrNIQVEjlE5M+pjSo5y5lJ+by1T8j93RepF68fSx2hJNsN3z/LP14spf2xTxD GjHNvBYIMtS9I1INUMEa9oAH70XyhYqcm42elsdox7gMSJoDGd57sSjTB5mSan9qvCsV eFlvtmd5JdQXQs1kjwSyZQPsYqDcKk4aFGRq7Dg4FgPkLrQBkMQ35JwbJbhSV8s2I33p ndebk4WsWZ/wndb1k/sYfJTDKIYBd//H3X325h17nxGmnatVLHabxX2djDTegEdlLaOq jvApSI+LinleIAO+nE8hXcutT4HnR+QMWsgbX152KBdlxgJt5fhGeLLe9LsBOYOLnIdH 05zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773864672; x=1774469472; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tcrjf6o6BBsskimuOBs0/X8mHwc2XWl98zNiH3etscg=; b=UDqOlcleyW7tdTPcx2XNn7TTwWT7BkYTQhaANSU+AfmFxL5zwFOU55BP4GfTkFNhHY p2HPQpexSNIdAtT7K1JtjsINEu/XaegerYgo3Z+3xTdZlLoCcZ79R9Th7Q6U0RmjZb7j 4h6rD3dn/2k40ODhvC0+1BhBQaD7R6NoZKmfXVolBEujxriJbUHo3Gf6wRuWKzt4MRz1 A3Vu0wyRrVS544SQVPomgv7C05svCqN76BSLvPPu9M17oTbupKbdszeF1p8A8WUpDkZW r1j8Q0ieMHUse15dnGO6HUEgWCKLif/AB0ZdaChHSvFERxhRQ7stqO3KdBEMH0XB6+69 wG8Q== X-Forwarded-Encrypted: i=1; AJvYcCXC+BnkaR2WSnT/Y1DEdDmFRQkQPuLEdicPOuoX/sZkk+IugwkDc7uSafhE3oO258UhUV9tpYw=@vger.kernel.org X-Gm-Message-State: AOJu0YyLuMYoXYeq6zHvBzlK95+aiTFYFIj7Tu1jC53MyjqkwnjkkasK ljENVPGAc69wknsQNXHU8gLmXlsBNwVPxRwFt4SiW5fKJkKZSrkmeNh7F2G+3+rGnr8= X-Gm-Gg: ATEYQzwFRVU74FzRrdNBCMWOYURwgp0KTNg7IF0yHpHfGBHuTe2SNsTtCxjyD7U93tK fLu7ORUCdFBhzCQOl2/BWxnBUVzTLCTV7uo4VJVHlFdvJ6NXxO9kBM2vNG2HUCDoQXHbupMP1pX XX7Gm0ovedo5jj8cxtwEtH3Euag0g3d6E43hJxb9xdEwdSSy8mx95+ugfEVvACv+m3/WBJQcvhp qx+aLbKIe22IgqYZNOQUX5y5HYo4hnUdKAZIUibd76xqGsldPlRMN6qJOS9Uir53X498vMved6C i8sL9wWYGbwfLr+oxnSBww7r+fjXVYSB8e8Tbsh7yl3C4CqLbaCkBmD0vFnxpnDGFtepbXoG2l/ YEHMz+YhrQgTEBbRIqlzIXw99RvVqNV01xQgYc/IN9G7WngUHa0Bxx2kjx2DpLnj0+FPaF3y+yY NfWXU= X-Received: by 2002:a05:6a00:2183:b0:829:9c9c:1720 with SMTP id d2e1a72fcca58-82a6ae70a0dmr4132616b3a.38.1773864672197; Wed, 18 Mar 2026 13:11:12 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:8::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bbe1869sm4227445b3a.40.2026.03.18.13.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 13:11:11 -0700 (PDT) Date: Wed, 18 Mar 2026 13:11:11 -0700 From: Joe Damato To: Tariq Toukan Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" , Saeed Mahameed , Mark Bloch , Leon Romanovsky , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman , Moshe Shemesh , Nimrod Oren , Carolina Jubran , Dragos Tatulea Subject: Re: [PATCH net-next] net/mlx5e: Add hds-thresh query support via ethtool Message-ID: Mail-Followup-To: Joe Damato , Tariq Toukan , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" , Saeed Mahameed , Mark Bloch , Leon Romanovsky , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman , Moshe Shemesh , Nimrod Oren , Carolina Jubran , Dragos Tatulea References: <20260317104934.16124-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317104934.16124-1-tariqt@nvidia.com> On Tue, Mar 17, 2026 at 12:49:34PM +0200, Tariq Toukan wrote: > From: Nimrod Oren > > Add support for reporting HDS (Header-Data Split) threshold via > ethtool. When applicable, mlx5 hardware splits packets of all sizes with > no configurable threshold, so report both hds-thresh and hds-thresh-max > as 0 (i.e. always split regardless of size). > > Signed-off-by: Nimrod Oren > Reviewed-by: Carolina Jubran > Reviewed-by: Dragos Tatulea > Signed-off-by: Tariq Toukan > --- > drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > index 4a8dc85d5924..bb61e2179078 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > @@ -371,6 +371,9 @@ void mlx5e_ethtool_get_ringparam(struct mlx5e_priv *priv, > param->tx_max_pending = 1 << MLX5E_PARAMS_MAXIMUM_LOG_SQ_SIZE; > param->rx_pending = 1 << priv->channels.params.log_rq_mtu_frames; > param->tx_pending = 1 << priv->channels.params.log_sq_size; > + > + kernel_param->hds_thresh = 0; I think this is populated by the core before the call to get_ringparam and it looks like it is defaulted to 0, so I think this assignment is unnecessary. But everything else seems fine, so: Reviewed-by: Joe Damato