From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b8-smtp.messagingengine.com (fhigh-b8-smtp.messagingengine.com [202.12.124.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A977836BCD9 for ; Thu, 19 Mar 2026 09:31:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773912683; cv=none; b=ogw7iJ1EVU2UOY1tjo38VtSs3mYXAp013ASDlu1N8FqvmDEPaXUpnKpH7xVGS9/MilENRpQaiHh8Ffq8VhGLa97GI7/n1FIyAv67Gx59xB+6zBnuq9a7k8IQUQW2444i9uLv8P9149iQkNHCsJaHA/LD/OetxMvySkhx2cgI38I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773912683; c=relaxed/simple; bh=g0UxsdjxOubFnTre0WWAoZemhlwBPWubs5+CfWaZws0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s25OztUkiu+vVzWnO+mXatJMTfQsv48TjGOlrR/Z9s8AzLXSgT4gHEbUwxvv/IDwRjCtLF300Gvb6ZJBtHiaWv51Csmi9NcvN01ofmhDlPSd/JUaMpJM67Ue1pHkQVbTnOcx5aBGP8pTWzy1oZC5RfYm4ElLTyRqF78ipaD8XR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=W/vFM7XR; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=3etQwQ1m; arc=none smtp.client-ip=202.12.124.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="W/vFM7XR"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="3etQwQ1m" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id ABDD17A01F7; Thu, 19 Mar 2026 05:31:18 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Thu, 19 Mar 2026 05:31:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1773912678; x= 1773999078; bh=sklSja91ZrsragPCLIBWZEBM9NRmmC3AzswbyXGvzac=; b=W /vFM7XRhsq354zRAlkxI/rqyd1t6ebaG9nuDR52rmdjx+sA6P2J3IRfvIACp3SHX OJWc4xuRM9eVCJxqBjxKteGGm5rd5u5YfqJPuxREAgPY1oGPaB+BX8Z4FYpeh13S LX3h6Kd2qEIhP1jkh8oYmwvN57vnI8uVpM70fOZrEg0gl/QdlsgQ7pyb0zxqFNkj XMgvOMdGy+GwnB4jK53KTO9W8Jc5kb4dYgZCu6CkOjCGL/ZdN3UlXW36xkza+UtT 5rd5N0+E2Jriiq/VMbxfSpqCUnCBcgcSLJi6O9atvdkTssMtjg9V5fP4wHPfgTOS 7VMatt6+t95qS83NAq8HQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773912678; x=1773999078; bh=sklSja91ZrsragPCLIBWZEBM9NRmmC3Azsw byXGvzac=; b=3etQwQ1mQS8ewFqrILRA4TflYGzNbPIdNCul6BpBJWkgY7jcvg0 nQ8howvJ6X67Zz5CEgghDrG0+tnW1XObQFxEQSICzM8V30o2OuRtGDtMV4XvMU9I bXM/V+g/dbUAKQXf/wQHGbya7eKkXzDryCDjHctEVyfmPoskzQj1s+Q+D6CH0Zc0 qLXqoGuIJz5XllRuPBvxcGHWIcs1WMobBOh12L2I4GrevU32WaSv+C2o65wjVwTK 1XoMFyVO9tVlx6Y+Go0z5iAKLa16hWaQjHgR1QA6QlDsFC9BOKd2w5kGAwuR/7uu vEPNavruX6uy4iXYdy00fMQSkHKGdcYnOXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdeiieeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopeegpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopehrhigriigrnhhovhdrshdrrgesghhmrghilh drtghomhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrghdp rhgtphhtthhopehjohhhrghnnhgvshdrsggvrhhgsehinhhtvghlrdgtohhmpdhrtghpth htoheplhhoihgtrdhpohhulhgrihhnsehlihhnrghrohdrohhrgh X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Mar 2026 05:31:17 -0400 (EDT) Date: Thu, 19 Mar 2026 10:31:16 +0100 From: Sabrina Dubroca To: Sergey Ryazanov Cc: netdev@vger.kernel.org, Johannes Berg , Loic Poulain Subject: Re: [PATCH net 1/2] rtnetlink: count IFLA_PARENT_DEV_{NAME,BUS_NAME} in if_nlmsg_size Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: 2026-03-19, 08:59:47 +0200, Sergey Ryazanov wrote: > On March 18, 2026 12:45:52 PM, Sabrina Dubroca wrote: > >Commit 00e77ed8e64d ("rtnetlink: add IFLA_PARENT_[DEV|DEV_BUS]_NAME") > >added those attributes to rtnl_fill_ifinfo, but forgot to extend > >if_nlmsg_size. > > Nice catch! Please find an implementation question below. > > >Fixes: 00e77ed8e64d ("rtnetlink: add IFLA_PARENT_[DEV|DEV_BUS]_NAME") > >Signed-off-by: Sabrina Dubroca > >--- > > net/core/rtnetlink.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > >diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > >index dad4b1054955..a116362f5f32 100644 > >--- a/net/core/rtnetlink.c > >+++ b/net/core/rtnetlink.c > >@@ -1267,6 +1267,21 @@ static size_t rtnl_dpll_pin_size(const struct net_device *dev) > > return size; > > } > > > >+static size_t rtnl_dev_parent_size(const struct net_device *dev) > >+{ > >+ size_t size = 0; > >+ > >+ /* IFLA_PARENT_DEV_NAME */ > >+ if (dev->dev.parent) > >+ size += strlen(dev_name(dev->dev.parent)) + 1; > > Shall we use nla_total_size() to account alignment? Oops, thanks for catching my brainfart (it's not alignment but the attribute header). I'll send a v2 later today. -- Sabrina